From: Julia Lawall <julia@diku.dk>
To: Paulo Marques <pmarques@grupopie.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/3] Use kasprintf
Date: Mon, 18 Oct 2010 22:02:53 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1010182202260.22877@ask.diku.dk> (raw)
In-Reply-To: <4CBC8D4E.90008@grupopie.com>
On Mon, 18 Oct 2010, Paulo Marques wrote:
> Julia Lawall wrote:
> > These patches convert a sequence of kmalloc and memcpy to use kasprintf
> > instead.
>
> Aren't these patches just a more convoluted way of doing a kstrdup?
>
> I would imagine that a kasprintf would make more sense when the format
> string is more complex than "%s", or am I missing something?
They have all already been changed to either kmemdup or kstrdup.
thanks,
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia@diku.dk>
To: Paulo Marques <pmarques@grupopie.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/3] Use kasprintf
Date: Mon, 18 Oct 2010 20:02:53 +0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1010182202260.22877@ask.diku.dk> (raw)
In-Reply-To: <4CBC8D4E.90008@grupopie.com>
On Mon, 18 Oct 2010, Paulo Marques wrote:
> Julia Lawall wrote:
> > These patches convert a sequence of kmalloc and memcpy to use kasprintf
> > instead.
>
> Aren't these patches just a more convoluted way of doing a kstrdup?
>
> I would imagine that a kasprintf would make more sense when the format
> string is more complex than "%s", or am I missing something?
They have all already been changed to either kmemdup or kstrdup.
thanks,
julia
next prev parent reply other threads:[~2010-10-18 20:02 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-17 18:48 [PATCH 0/3] Use kasprintf Julia Lawall
2010-10-17 18:48 ` Julia Lawall
2010-10-17 18:48 ` [PATCH 1/3] drivers/staging/cx25821: " Julia Lawall
2010-10-17 18:48 ` Julia Lawall
2010-10-18 7:15 ` walter harms
2010-10-18 7:15 ` walter harms
2010-10-18 8:22 ` Julia Lawall
2010-10-18 8:22 ` Julia Lawall
2010-10-18 9:27 ` walter harms
2010-10-18 9:27 ` walter harms
2010-10-18 12:25 ` [PATCH 1/3] drivers/staging/cx25821: Use kstrdup Julia Lawall
2010-10-18 12:25 ` Julia Lawall
2010-10-18 17:38 ` Joe Perches
2010-10-18 17:38 ` Joe Perches
2010-10-18 17:44 ` Julia Lawall
2010-10-18 17:44 ` Julia Lawall
2010-10-18 17:55 ` Joe Perches
2010-10-18 17:55 ` Joe Perches
2010-10-18 17:58 ` Julia Lawall
2010-10-18 17:58 ` Julia Lawall
2010-10-18 20:43 ` Julia Lawall
2010-10-18 20:43 ` Julia Lawall
2010-10-17 18:48 ` [PATCH 2/3] fs/ceph/xattr.c: Use kasprintf Julia Lawall
2010-10-17 18:48 ` Julia Lawall
2010-10-17 18:54 ` Joe Perches
2010-10-17 18:54 ` Joe Perches
2010-10-17 19:02 ` Julia Lawall
2010-10-17 19:02 ` Julia Lawall
2010-10-17 19:55 ` [PATCH 2/3] fs/ceph/xattr.c: Use kmemdup Julia Lawall
2010-10-17 19:55 ` Julia Lawall
2010-10-17 21:36 ` Sage Weil
2010-10-17 21:36 ` Sage Weil
2010-10-17 18:48 ` [PATCH 3/3] fs/jffs2/dir.c: Use kasprintf Julia Lawall
2010-10-17 18:48 ` Julia Lawall
2010-10-17 18:48 ` Julia Lawall
[not found] ` <1287341849.20968.62.camel@Joe-Laptop>
2010-10-17 19:56 ` [PATCH 3/3] fs/jffs2/dir.c: Use kmemdup Julia Lawall
2010-10-17 19:56 ` Julia Lawall
2010-10-18 3:43 ` Artem Bityutskiy
2010-10-18 3:43 ` Artem Bityutskiy
2010-10-18 18:09 ` [PATCH 0/3] Use kasprintf Paulo Marques
2010-10-18 18:09 ` Paulo Marques
2010-10-18 20:02 ` Julia Lawall [this message]
2010-10-18 20:02 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1010182202260.22877@ask.diku.dk \
--to=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmarques@grupopie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.