From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/5] i2c-sh_mobile non-urgent changes
Date: Sat, 17 Nov 2012 23:27:11 +0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1211180022331.30062@axis700.grange> (raw)
In-Reply-To: <50A5FF0D.4020502@renesas.com>
On Fri, 16 Nov 2012, Shinya Kuribayashi wrote:
> On 11/16/2012 5:07 PM, Wolfram Sang wrote:
> > Looks good to me, like the extensive patch descriptions. I am going to
> > apply it to for-next with patches 2+3 squashed, because after patch 2 we
> > would have a buggy state otherwise. Let me know if you are not okay with
> > that.
>
> It's not that buggy as you/we think, in most cases it work without
> problem. What's more important for me is to record the issue and
> how to solve it. So I'd like to have patch 2 and 3 separately.
I agree with Wolfram. For developers it can be important to know their own
development process, that's true. But for upstream it is an absolute
preference to avoid breakages. So, we should never commit patches, that
are known to contain problems. In this case it means, that patches 2 and 3
should be merged. It is good, that the problem has been detected and fixed
during development or testing, this gives us a chance to avoid breaking
the mainline, which we should certainly use.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
WARNING: multiple messages have this Message-ID (diff)
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Shinya Kuribayashi <shinya.kuribayashi.px@renesas.com>
Cc: w.sang@pengutronix.de, linux-arm-kernel@lists.infradead.org,
magnus.damm@gmail.com, linux-i2c@vger.kernel.org,
ben-linux@fluff.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 0/5] i2c-sh_mobile non-urgent changes
Date: Sun, 18 Nov 2012 00:27:11 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.1211180022331.30062@axis700.grange> (raw)
In-Reply-To: <50A5FF0D.4020502@renesas.com>
On Fri, 16 Nov 2012, Shinya Kuribayashi wrote:
> On 11/16/2012 5:07 PM, Wolfram Sang wrote:
> > Looks good to me, like the extensive patch descriptions. I am going to
> > apply it to for-next with patches 2+3 squashed, because after patch 2 we
> > would have a buggy state otherwise. Let me know if you are not okay with
> > that.
>
> It's not that buggy as you/we think, in most cases it work without
> problem. What's more important for me is to record the issue and
> how to solve it. So I'd like to have patch 2 and 3 separately.
I agree with Wolfram. For developers it can be important to know their own
development process, that's true. But for upstream it is an absolute
preference to avoid breakages. So, we should never commit patches, that
are known to contain problems. In this case it means, that patches 2 and 3
should be merged. It is good, that the problem has been detected and fixed
during development or testing, this gives us a chance to avoid breaking
the mainline, which we should certainly use.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
WARNING: multiple messages have this Message-ID (diff)
From: g.liakhovetski@gmx.de (Guennadi Liakhovetski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] i2c-sh_mobile non-urgent changes
Date: Sun, 18 Nov 2012 00:27:11 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.1211180022331.30062@axis700.grange> (raw)
In-Reply-To: <50A5FF0D.4020502@renesas.com>
On Fri, 16 Nov 2012, Shinya Kuribayashi wrote:
> On 11/16/2012 5:07 PM, Wolfram Sang wrote:
> > Looks good to me, like the extensive patch descriptions. I am going to
> > apply it to for-next with patches 2+3 squashed, because after patch 2 we
> > would have a buggy state otherwise. Let me know if you are not okay with
> > that.
>
> It's not that buggy as you/we think, in most cases it work without
> problem. What's more important for me is to record the issue and
> how to solve it. So I'd like to have patch 2 and 3 separately.
I agree with Wolfram. For developers it can be important to know their own
development process, that's true. But for upstream it is an absolute
preference to avoid breakages. So, we should never commit patches, that
are known to contain problems. In this case it means, that patches 2 and 3
should be merged. It is good, that the problem has been detected and fixed
during development or testing, this gives us a chance to avoid breaking
the mainline, which we should certainly use.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
next prev parent reply other threads:[~2012-11-17 23:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 10:55 [PATCH 0/5] i2c-sh_mobile non-urgent changes Shinya Kuribayashi
2012-10-24 10:55 ` Shinya Kuribayashi
2012-10-24 10:55 ` Shinya Kuribayashi
2012-10-24 10:56 ` [PATCH 1/5] i2c: i2c-sh_mobile: calculate clock parameters at driver probing time Shinya Kuribayashi
2012-10-24 10:56 ` Shinya Kuribayashi
2012-10-24 10:56 ` Shinya Kuribayashi
2012-10-24 10:57 ` [PATCH 2/5] i2c: i2c-sh_mobile: optimize ICCH/ICCL values according to I2C bus speed Shinya Kuribayashi
2012-10-24 10:57 ` Shinya Kuribayashi
2012-10-24 10:57 ` Shinya Kuribayashi
2012-10-24 10:57 ` [PATCH 3/5] i2c: i2c-sh_mobile: fix ICCH to avoid violation of the tHD;STA timing spec Shinya Kuribayashi
2012-10-24 10:57 ` Shinya Kuribayashi
2012-10-24 10:57 ` Shinya Kuribayashi
2012-10-24 10:58 ` [PATCH 4/5] i2c: i2c-sh_mobile: support I2C hardware block with a faster operating clock Shinya Kuribayashi
2012-10-24 10:58 ` Shinya Kuribayashi
2012-10-24 10:58 ` Shinya Kuribayashi
2012-10-24 10:58 ` [PATCH 5/5] i2c: i2c-sh_mobile: fix spurious transfer request timed out Shinya Kuribayashi
2012-10-24 10:58 ` Shinya Kuribayashi
2012-10-24 10:58 ` Shinya Kuribayashi
2012-11-16 8:07 ` [PATCH 0/5] i2c-sh_mobile non-urgent changes Wolfram Sang
2012-11-16 8:07 ` Wolfram Sang
2012-11-16 8:07 ` Wolfram Sang
2012-11-16 8:53 ` Shinya Kuribayashi
2012-11-16 8:53 ` Shinya Kuribayashi
2012-11-16 8:53 ` Shinya Kuribayashi
2012-11-17 23:27 ` Guennadi Liakhovetski [this message]
2012-11-17 23:27 ` Guennadi Liakhovetski
2012-11-17 23:27 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1211180022331.30062@axis700.grange \
--to=g.liakhovetski@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.