From: Chris Brandt <Chris.Brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
Simon Horman
<horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: [PATCH v2 2/3] mmc: sh_mmcif: Document r7s72100 DT bindings
Date: Mon, 26 Sep 2016 20:58:41 +0000 [thread overview]
Message-ID: <SG2PR06MB11650CDC26D69220278ED4C78ACD0@SG2PR06MB1165.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20160923191519.GA28901@rob-hp-laptop>
On 9/23/2016, Rob Herring wrote:
> > diff --git a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> > b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> > index ff611fa..1443edb 100644
> > --- a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> > +++ b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> > @@ -8,12 +8,16 @@ Required properties:
> >
> > - compatible: should be "renesas,mmcif-<soctype>", "renesas,sh-mmcif"
> as a
> > fallback. Examples with <soctype> are:
> > + - "renesas,mmcif-r7s72100" for the MMCIF found in r7s72100 SoCs
> > - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
> > - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
> > - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
> > - "renesas,mmcif-r8a7793" for the MMCIF found in r8a7793 SoCs
> > - "renesas,mmcif-r8a7794" for the MMCIF found in r8a7794 SoCs
> >
> > +- interrupts: either 1 shared interrupt, 2 separate interrupts (error
> > +and int),
> > + or 3 separate interrupts (error, int, card detect)
>
> This should be based on the compatible strings. Surely, 1, 2, or 3 is not
> valid for all compatibles.
That is true. What is your suggestion? Add the specific number of interrupts for each SoC to the documentation so there is no confusion?
For example:
- interrupts: Some SoCs have only 1 shared interrupt, while others have either
2 or 3 individual interrupts (error, int, card detect). Below is the number
of interrupts for each SoC.
3: r7s72100 SoC
2: r8a7740 SoC
1: r8a7790 SoC
1: r8a7791 SoC
1: r8a7793 SoC
1: r8a7794 SoC
Chris
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Chris Brandt <Chris.Brandt@renesas.com>
To: Rob Herring <robh@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Simon Horman <horms+renesas@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2 2/3] mmc: sh_mmcif: Document r7s72100 DT bindings
Date: Mon, 26 Sep 2016 20:58:41 +0000 [thread overview]
Message-ID: <SG2PR06MB11650CDC26D69220278ED4C78ACD0@SG2PR06MB1165.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20160923191519.GA28901@rob-hp-laptop>
On 9/23/2016, Rob Herring wrote:
> > diff --git a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> > b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> > index ff611fa..1443edb 100644
> > --- a/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> > +++ b/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
> > @@ -8,12 +8,16 @@ Required properties:
> >
> > - compatible: should be "renesas,mmcif-<soctype>", "renesas,sh-mmcif"
> as a
> > fallback. Examples with <soctype> are:
> > + - "renesas,mmcif-r7s72100" for the MMCIF found in r7s72100 SoCs
> > - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
> > - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
> > - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
> > - "renesas,mmcif-r8a7793" for the MMCIF found in r8a7793 SoCs
> > - "renesas,mmcif-r8a7794" for the MMCIF found in r8a7794 SoCs
> >
> > +- interrupts: either 1 shared interrupt, 2 separate interrupts (error
> > +and int),
> > + or 3 separate interrupts (error, int, card detect)
>
> This should be based on the compatible strings. Surely, 1, 2, or 3 is not
> valid for all compatibles.
That is true. What is your suggestion? Add the specific number of interrupts for each SoC to the documentation so there is no confusion?
For example:
- interrupts: Some SoCs have only 1 shared interrupt, while others have either
2 or 3 individual interrupts (error, int, card detect). Below is the number
of interrupts for each SoC.
3: r7s72100 SoC
2: r8a7740 SoC
1: r8a7790 SoC
1: r8a7791 SoC
1: r8a7793 SoC
1: r8a7794 SoC
Chris
next prev parent reply other threads:[~2016-09-26 20:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 15:46 [PATCH v2 0/3] r7s72100: dts: enable mmcif Chris Brandt
2016-09-20 15:46 ` [PATCH v2 2/3] mmc: sh_mmcif: Document r7s72100 DT bindings Chris Brandt
[not found] ` <20160920154620.18653-3-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-09-23 19:15 ` Rob Herring
2016-09-23 19:15 ` Rob Herring
2016-09-26 20:58 ` Chris Brandt [this message]
2016-09-26 20:58 ` Chris Brandt
[not found] ` <20160920154620.18653-1-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2016-09-20 15:46 ` [PATCH v2 1/3] ARM: dts: r7s72100: add mmcif to device tree Chris Brandt
2016-09-20 15:46 ` Chris Brandt
2016-09-20 15:46 ` [PATCH v2 3/3] ARM: dts: rskrza1: add mmc DT support Chris Brandt
2016-09-20 15:46 ` Chris Brandt
2016-09-27 7:28 ` Geert Uytterhoeven
2016-09-27 8:11 ` Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SG2PR06MB11650CDC26D69220278ED4C78ACD0@SG2PR06MB1165.apcprd06.prod.outlook.com \
--to=chris.brandt-zm6kxycvzfbbdgjk7y7tuq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.