From: "Nabeel Meeramohideen Mohamed (nmeeramohide)" <nmeeramohide@micron.com> To: Hillf Danton <hdanton@sina.com> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "Steve Moyer (smoyer)" <smoyer@micron.com>, "Greg Becker (gbecker)" <gbecker@micron.com>, "Pierre Labat (plabat)" <plabat@micron.com>, "John Groves (jgroves)" <jgroves@micron.com> Subject: RE: [EXT] Re: [PATCH 01/22] mpool: add utility routines and ioctl definitions Date: Wed, 30 Sep 2020 21:49:36 +0000 [thread overview] Message-ID: <SN6PR08MB4208CA2400FC06C4939D54F9B3330@SN6PR08MB4208.namprd08.prod.outlook.com> (raw) In-Reply-To: <20200930112715.18532-1-hdanton@sina.com> Hi Hillf, On Wednesday, September 30, 2020 5:27 AM, Hillf Danton <hdanton@sina.com> wrote: > On Mon, 28 Sep 2020 11:45:13 -0500 Nabeel M Mohamed wrote: > > > > +/* Rate limited version of mp_pr_err(). */ > > +#define mp_pr_rl(_fmt, _err, ...) \ > > +do { \ > > + static unsigned long mp_pr_rl_state; \ > > We do not need to declare a mp_pr_rl_state per use case of mp_pr_rl. Agreed, will make it a global state to rate limit all messages vs. by call site. > > > + uint dly = msecs_to_jiffies(333); \ > > printk_timed_ratelimit() needs msec as input instead of tick. Nice catch, thanks! Will address both your comments in v2. Thanks, Nabeel
WARNING: multiple messages have this Message-ID (diff)
From: "Nabeel Meeramohideen Mohamed (nmeeramohide)" <nmeeramohide@micron.com> To: Hillf Danton <hdanton@sina.com> Cc: "Steve Moyer \(smoyer\)" <smoyer@micron.com>, "Pierre Labat \(plabat\)" <plabat@micron.com>, "John Groves \(jgroves\)" <jgroves@micron.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, "Greg Becker \(gbecker\)" <gbecker@micron.com> Subject: RE: [EXT] Re: [PATCH 01/22] mpool: add utility routines and ioctl definitions Date: Wed, 30 Sep 2020 21:49:36 +0000 [thread overview] Message-ID: <SN6PR08MB4208CA2400FC06C4939D54F9B3330@SN6PR08MB4208.namprd08.prod.outlook.com> (raw) In-Reply-To: <20200930112715.18532-1-hdanton@sina.com> Hi Hillf, On Wednesday, September 30, 2020 5:27 AM, Hillf Danton <hdanton@sina.com> wrote: > On Mon, 28 Sep 2020 11:45:13 -0500 Nabeel M Mohamed wrote: > > > > +/* Rate limited version of mp_pr_err(). */ > > +#define mp_pr_rl(_fmt, _err, ...) \ > > +do { \ > > + static unsigned long mp_pr_rl_state; \ > > We do not need to declare a mp_pr_rl_state per use case of mp_pr_rl. Agreed, will make it a global state to rate limit all messages vs. by call site. > > > + uint dly = msecs_to_jiffies(333); \ > > printk_timed_ratelimit() needs msec as input instead of tick. Nice catch, thanks! Will address both your comments in v2. Thanks, Nabeel _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-09-30 21:49 UTC|newest] Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-28 16:45 [PATCH 00/22] add Object Storage Media Pool (mpool) nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 01/22] mpool: add utility routines and ioctl definitions nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-30 11:27 ` Hillf Danton 2020-09-30 11:27 ` Hillf Danton 2020-09-30 21:49 ` Nabeel Meeramohideen Mohamed (nmeeramohide) [this message] 2020-09-30 21:49 ` [EXT] " Nabeel Meeramohideen Mohamed (nmeeramohide) 2020-09-30 21:49 ` Nabeel Meeramohideen Mohamed (nmeeramohide) 2020-09-28 16:45 ` [PATCH 02/22] mpool: add in-memory struct definitions nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 03/22] mpool: add on-media " nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 04/22] mpool: add pool drive component which handles mpool IO using the block layer API nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 05/22] mpool: add space map component which manages free space on mpool devices nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 06/22] mpool: add on-media pack, unpack and upgrade routines nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 07/22] mpool: add superblock management routines nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 08/22] mpool: add pool metadata routines to manage object lifecycle and IO nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 09/22] mpool: add mblock lifecycle management and IO routines nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 10/22] mpool: add mlog IO utility routines nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 11/22] mpool: add mlog lifecycle management and IO routines nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 12/22] mpool: add metadata container or mlog-pair framework nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 13/22] mpool: add utility routines for mpool lifecycle management nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 14/22] mpool: add pool metadata routines to create persistent mpools nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 15/22] mpool: add mpool lifecycle management routines nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 16/22] mpool: add mpool control plane utility routines nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 17/22] mpool: add mpool lifecycle management ioctls nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-30 0:13 ` Randy Dunlap 2020-09-30 0:13 ` Randy Dunlap 2020-09-30 0:13 ` Randy Dunlap 2020-09-30 20:00 ` [EXT] " Nabeel Meeramohideen Mohamed (nmeeramohide) 2020-09-30 20:00 ` Nabeel Meeramohideen Mohamed (nmeeramohide) 2020-09-30 20:00 ` Nabeel Meeramohideen Mohamed (nmeeramohide) 2020-09-30 20:00 ` Nabeel Meeramohideen Mohamed (nmeeramohide) 2020-09-28 16:45 ` [PATCH 18/22] mpool: add object " nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 19/22] mpool: add support to mmap arbitrary collection of mblocks nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 20/22] mpool: add support to proactively evict cached mblock data from the page-cache nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 21/22] mpool: add documentation nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` [PATCH 22/22] mpool: add Kconfig and Makefile nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 16:45 ` nmeeramohide 2020-09-28 23:47 ` kernel test robot 2020-09-28 23:47 ` kernel test robot 2020-09-28 23:47 ` kernel test robot 2020-09-28 23:47 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=SN6PR08MB4208CA2400FC06C4939D54F9B3330@SN6PR08MB4208.namprd08.prod.outlook.com \ --to=nmeeramohide@micron.com \ --cc=gbecker@micron.com \ --cc=hdanton@sina.com \ --cc=jgroves@micron.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nvme@lists.infradead.org \ --cc=plabat@micron.com \ --cc=smoyer@micron.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.