All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lu, Brent" <brent.lu@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Support Opensource" <support.opensource@diasemi.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"cychiang@google.com" <cychiang@google.com>,
	"Chiang, Mac" <mac.chiang@intel.com>
Subject: RE: [PATCH] ASoC: da7219: check SRM lock in trigger callback
Date: Tue, 11 Feb 2020 10:19:03 +0000	[thread overview]
Message-ID: <SN6PR11MB26709809E6900F1F1F9F422A97180@SN6PR11MB2670.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200210185905.GD14166@sirena.org.uk>

> 
> Independently of any other discussion trigger is expected to run very fast so
> doesn't feel like a good place to do this - given that we're talking about doing
> this to avoid noise the mute operation seems like a more idiomatic place to
> do this, it exists to avoid playing back glitches from the digitial interface
> during startup.

It still take 50ms waiting for lock on in the trigger so I guess it's not a good
implementation here. And I thought digital mute is called in the pcm_prepare?
I'm afraid it does not work in our case...

Regards,
Brent

WARNING: multiple messages have this Message-ID (diff)
From: "Lu, Brent" <brent.lu@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Takashi Iwai <tiwai@suse.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Chiang, Mac" <mac.chiang@intel.com>,
	"cychiang@google.com" <cychiang@google.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: da7219: check SRM lock in trigger callback
Date: Tue, 11 Feb 2020 10:19:03 +0000	[thread overview]
Message-ID: <SN6PR11MB26709809E6900F1F1F9F422A97180@SN6PR11MB2670.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200210185905.GD14166@sirena.org.uk>

> 
> Independently of any other discussion trigger is expected to run very fast so
> doesn't feel like a good place to do this - given that we're talking about doing
> this to avoid noise the mute operation seems like a more idiomatic place to
> do this, it exists to avoid playing back glitches from the digitial interface
> during startup.

It still take 50ms waiting for lock on in the trigger so I guess it's not a good
implementation here. And I thought digital mute is called in the pcm_prepare?
I'm afraid it does not work in our case...

Regards,
Brent
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2020-02-11 10:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10  8:16 [PATCH] ASoC: da7219: check SRM lock in trigger callback Brent Lu
2020-02-10  8:16 ` [alsa-devel] " Brent Lu
2020-02-10 14:18 ` Pierre-Louis Bossart
2020-02-10 14:18   ` Pierre-Louis Bossart
2020-02-10 15:44   ` Curtis Malainey
2020-02-10 16:07     ` Pierre-Louis Bossart
2020-02-10 16:07       ` Pierre-Louis Bossart
2020-02-10 16:18       ` Curtis Malainey
2020-02-11  4:00         ` Fletcher Woodruff
2020-02-11  4:00           ` Fletcher Woodruff
2020-02-10 14:32 ` Adam Thomson
2020-02-10 14:32   ` [alsa-devel] " Adam Thomson
2020-02-11 10:08   ` Lu, Brent
2020-02-11 10:08     ` [alsa-devel] " Lu, Brent
2020-02-11 16:30     ` Pierre-Louis Bossart
2020-02-11 16:30       ` Pierre-Louis Bossart
2020-02-11 20:37       ` Sridharan, Ranjani
2020-02-11 21:12         ` Pierre-Louis Bossart
2020-02-11 21:12           ` Pierre-Louis Bossart
2020-02-11 21:37           ` Sridharan, Ranjani
2020-02-11 21:49             ` Pierre-Louis Bossart
2020-02-11 21:49               ` Pierre-Louis Bossart
2020-02-12 10:16               ` Adam Thomson
2020-02-12 10:16                 ` Adam Thomson
2020-02-12 11:59                 ` Mark Brown
2020-02-12 11:59                   ` Mark Brown
2020-02-12 15:48                 ` Pierre-Louis Bossart
2020-02-12 15:48                   ` Pierre-Louis Bossart
2020-02-12 17:01                   ` Adam Thomson
2020-02-12 17:01                     ` Adam Thomson
2020-02-19  5:57                 ` Lu, Brent
2020-02-19 10:05                   ` Adam Thomson
2020-02-10 18:59 ` Mark Brown
2020-02-10 18:59   ` [alsa-devel] " Mark Brown
2020-02-11 10:19   ` Lu, Brent [this message]
2020-02-11 10:19     ` Lu, Brent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB26709809E6900F1F1F9F422A97180@SN6PR11MB2670.namprd11.prod.outlook.com \
    --to=brent.lu@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cychiang@google.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mac.chiang@intel.com \
    --cc=perex@perex.cz \
    --cc=support.opensource@diasemi.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.