From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> To: Rob Herring <robh+dt@kernel.org> Cc: Neil Armstrong <narmstrong@baylibre.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Mark Rutland <mark.rutland@arm.com>, Andrzej Hajda <a.hajda@samsung.com>, Simon Horman <horms@verge.net.au>, Geert Uytterhoeven <geert+renesas@glider.be>, Magnus Damm <magnus.damm@gmail.com>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Peter Rosin <peda@axentia.se>, dri-devel <dri-devel@lists.freedesktop.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "open list:MEDIA DRIVERS FOR RENESAS - FCP" <linux-renesas-soc@vger.kernel.org>, Chris Paterson <Chris.Paterson2@renesas.com>, Biju Das <biju.das@bp.renesas.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Jacopo Mondi <jacopo+renesas@jmondi.org> Subject: RE: [PATCH v2 2/4] dt-bindings: display: bridge: Repurpose lvds-encoder Date: Tue, 5 Nov 2019 09:33:28 +0000 [thread overview] Message-ID: <TY1PR01MB1770F97A73768451B2ED8A22C07E0@TY1PR01MB1770.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAL_JsqJ+xus0GDWb0Px6HKDBzOt1yjwCCkQrfMspubwG+LZOdQ@mail.gmail.com> Hello Rob, Thank you for your feedback! > From: Rob Herring <robh+dt@kernel.org> > Sent: 04 November 2019 21:23 > Subject: Re: [PATCH v2 2/4] dt-bindings: display: bridge: Repurpose lvds-encoder > > On Mon, Nov 4, 2019 at 10:58 AM Fabrizio Castro > <fabrizio.castro@bp.renesas.com> wrote: > > > > In an effort to repurpose lvds-encoder.c to also serve the > > function of LVDS decoders, we ended up defining a new "generic" > > compatible string, therefore adapt the dt-bindings to fit the > > new purpose. Also, convert the dt-bindings from .txt to .yaml > > while at it. > > "Also, ... while at it." is a sign for split into 2 patches. Will split into 2 patches > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > --- > > v1->v2: > > * Converted to dt-schema as per Neil's comment > > --- > > .../bindings/display/bridge/lvds-codec.yaml | 117 +++++++++++++++++++++ > > .../bindings/display/bridge/lvds-transmitter.txt | 66 ------------ > > 2 files changed, 117 insertions(+), 66 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > delete mode 100644 Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > new file mode 100644 > > index 0000000..ff79bc2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > @@ -0,0 +1,117 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/lvds-codec.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Trasnparent LVDS encoders and LVDS decoders > > Typo Will fix > > > + > > +maintainers: > > + - Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > + > > +description: | > > + This binding supports transparent LVDS encoders and LVDS decoders that don't > > + require any configuration. > > + > > + LVDS is a physical layer specification defined in ANSI/TIA/EIA-644-A. Multiple > > + incompatible data link layers have been used over time to transmit image data > > + to LVDS panels. This binding targets devices compatible with the following > > + specifications only. > > + > > + [JEIDA] "Digital Interface Standards for Monitor", JEIDA-59-1999, February > > + 1999 (Version 1.0), Japan Electronic Industry Development Association (JEIDA) > > + [LDI] "Open LVDS Display Interface", May 1999 (Version 0.95), National > > + Semiconductor > > + [VESA] "VESA Notebook Panel Standard", October 2007 (Version 1.0), Video > > + Electronics Standards Association (VESA) > > + > > + Those devices have been marketed under the FPD-Link and FlatLink brand names > > + among others. > > + > > +properties: > > + compatible: > > + description: | > > + Any encoder or decoder compatible with this generic binding, but with > > + additional properties not listed here, must define its own binding and > > + list a device specific compatible first followed by the generic compatible > > + items: > > + - enum: > > You can drop 'items' when there's only 1. Will drop > > > + - lvds-encoder # for LVDS encoders > > + - lvds-decoder # for LVDS decoders > > + > > + ports: > > + type: object > > + description: | > > + This device has two video ports. Their connections are modeled using the > > + OF graph bindings specified in Documentation/devicetree/bindings/graph.txt > > + properties: > > + port@0: > > + type: object > > + description: | > > + With LVDS encoders port 0 is for parallel input > > + With LVDS decoders port 0 is for LVDS input > > + > > + port@1: > > + type: object > > + description: | > > + With LVDS encoders port 1 is for LVDS output > > + With LVDS decoders port 1 is for parallel output > > port@* are required, right? Yes, port@0 and port@1 are both required, similarly to: Documentation/devicetree/bindings/display/st,stm32-dsi.yaml therefore I have put "ports" under "required", in a similar fashion. What's the right way of specifying this? Thanks, Fab > > > + > > +required: > > + - compatible > > + - ports > > + > > +examples: > > + - | > > + lvds-encoder { > > + compatible = "lvds-encoder"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + lvds_enc_in: endpoint { > > + remote-endpoint = <&display_out_rgb>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + > > + lvds_enc_out: endpoint { > > + remote-endpoint = <&lvds_panel_in>; > > + }; > > + }; > > + }; > > + }; > > + > > + - | > > + lvds-decoder { > > + compatible = "lvds-decoder"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + lvds_dec_in: endpoint { > > + remote-endpoint = <&display_out_lvds>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + > > + lvds_dec_out: endpoint { > > + remote-endpoint = <&rgb_panel_in>; > > + }; > > + }; > > + }; > > + }; > > + > > +...
WARNING: multiple messages have this Message-ID (diff)
From: Fabrizio Castro <fabrizio.castro@bp.renesas.com> To: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Chris Paterson <Chris.Paterson2@renesas.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Neil Armstrong <narmstrong@baylibre.com>, David Airlie <airlied@linux.ie>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Magnus Damm <magnus.damm@gmail.com>, dri-devel <dri-devel@lists.freedesktop.org>, Biju Das <biju.das@bp.renesas.com>, "open list:MEDIA DRIVERS FOR RENESAS - FCP" <linux-renesas-soc@vger.kernel.org>, Simon Horman <horms@verge.net.au>, Jacopo Mondi <jacopo+renesas@jmondi.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Peter Rosin <peda@axentia.se> Subject: RE: [PATCH v2 2/4] dt-bindings: display: bridge: Repurpose lvds-encoder Date: Tue, 5 Nov 2019 09:33:28 +0000 [thread overview] Message-ID: <TY1PR01MB1770F97A73768451B2ED8A22C07E0@TY1PR01MB1770.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAL_JsqJ+xus0GDWb0Px6HKDBzOt1yjwCCkQrfMspubwG+LZOdQ@mail.gmail.com> Hello Rob, Thank you for your feedback! > From: Rob Herring <robh+dt@kernel.org> > Sent: 04 November 2019 21:23 > Subject: Re: [PATCH v2 2/4] dt-bindings: display: bridge: Repurpose lvds-encoder > > On Mon, Nov 4, 2019 at 10:58 AM Fabrizio Castro > <fabrizio.castro@bp.renesas.com> wrote: > > > > In an effort to repurpose lvds-encoder.c to also serve the > > function of LVDS decoders, we ended up defining a new "generic" > > compatible string, therefore adapt the dt-bindings to fit the > > new purpose. Also, convert the dt-bindings from .txt to .yaml > > while at it. > > "Also, ... while at it." is a sign for split into 2 patches. Will split into 2 patches > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > --- > > v1->v2: > > * Converted to dt-schema as per Neil's comment > > --- > > .../bindings/display/bridge/lvds-codec.yaml | 117 +++++++++++++++++++++ > > .../bindings/display/bridge/lvds-transmitter.txt | 66 ------------ > > 2 files changed, 117 insertions(+), 66 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > delete mode 100644 Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > new file mode 100644 > > index 0000000..ff79bc2 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > @@ -0,0 +1,117 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/lvds-codec.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Trasnparent LVDS encoders and LVDS decoders > > Typo Will fix > > > + > > +maintainers: > > + - Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > + > > +description: | > > + This binding supports transparent LVDS encoders and LVDS decoders that don't > > + require any configuration. > > + > > + LVDS is a physical layer specification defined in ANSI/TIA/EIA-644-A. Multiple > > + incompatible data link layers have been used over time to transmit image data > > + to LVDS panels. This binding targets devices compatible with the following > > + specifications only. > > + > > + [JEIDA] "Digital Interface Standards for Monitor", JEIDA-59-1999, February > > + 1999 (Version 1.0), Japan Electronic Industry Development Association (JEIDA) > > + [LDI] "Open LVDS Display Interface", May 1999 (Version 0.95), National > > + Semiconductor > > + [VESA] "VESA Notebook Panel Standard", October 2007 (Version 1.0), Video > > + Electronics Standards Association (VESA) > > + > > + Those devices have been marketed under the FPD-Link and FlatLink brand names > > + among others. > > + > > +properties: > > + compatible: > > + description: | > > + Any encoder or decoder compatible with this generic binding, but with > > + additional properties not listed here, must define its own binding and > > + list a device specific compatible first followed by the generic compatible > > + items: > > + - enum: > > You can drop 'items' when there's only 1. Will drop > > > + - lvds-encoder # for LVDS encoders > > + - lvds-decoder # for LVDS decoders > > + > > + ports: > > + type: object > > + description: | > > + This device has two video ports. Their connections are modeled using the > > + OF graph bindings specified in Documentation/devicetree/bindings/graph.txt > > + properties: > > + port@0: > > + type: object > > + description: | > > + With LVDS encoders port 0 is for parallel input > > + With LVDS decoders port 0 is for LVDS input > > + > > + port@1: > > + type: object > > + description: | > > + With LVDS encoders port 1 is for LVDS output > > + With LVDS decoders port 1 is for parallel output > > port@* are required, right? Yes, port@0 and port@1 are both required, similarly to: Documentation/devicetree/bindings/display/st,stm32-dsi.yaml therefore I have put "ports" under "required", in a similar fashion. What's the right way of specifying this? Thanks, Fab > > > + > > +required: > > + - compatible > > + - ports > > + > > +examples: > > + - | > > + lvds-encoder { > > + compatible = "lvds-encoder"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + lvds_enc_in: endpoint { > > + remote-endpoint = <&display_out_rgb>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + > > + lvds_enc_out: endpoint { > > + remote-endpoint = <&lvds_panel_in>; > > + }; > > + }; > > + }; > > + }; > > + > > + - | > > + lvds-decoder { > > + compatible = "lvds-decoder"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + lvds_dec_in: endpoint { > > + remote-endpoint = <&display_out_lvds>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + > > + lvds_dec_out: endpoint { > > + remote-endpoint = <&rgb_panel_in>; > > + }; > > + }; > > + }; > > + }; > > + > > +... _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-05 9:33 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-04 16:57 [PATCH v2 0/4] Add LCD panel support to iwg20d Fabrizio Castro 2019-11-04 16:57 ` Fabrizio Castro 2019-11-04 16:58 ` [PATCH v2 1/4] drm/bridge: Repurpose lvds-encoder.c Fabrizio Castro 2019-11-04 16:58 ` Fabrizio Castro 2019-11-07 18:19 ` Jacopo Mondi 2019-11-07 18:19 ` Jacopo Mondi 2019-11-07 20:02 ` Fabrizio Castro 2019-11-07 20:02 ` Fabrizio Castro 2019-11-07 22:21 ` Jacopo Mondi 2019-11-07 22:21 ` Jacopo Mondi 2019-11-04 16:58 ` [PATCH v2 2/4] dt-bindings: display: bridge: Repurpose lvds-encoder Fabrizio Castro 2019-11-04 16:58 ` Fabrizio Castro 2019-11-04 21:22 ` Rob Herring 2019-11-04 21:22 ` Rob Herring 2019-11-05 9:33 ` Fabrizio Castro [this message] 2019-11-05 9:33 ` Fabrizio Castro 2019-11-05 17:07 ` Rob Herring 2019-11-05 17:07 ` Rob Herring 2019-11-07 19:42 ` Fabrizio Castro 2019-11-07 19:42 ` Fabrizio Castro 2019-11-04 16:58 ` [PATCH v2 3/4] ARM: dts: iwg20d-q7-common: Add LCD support Fabrizio Castro 2019-11-04 16:58 ` Fabrizio Castro 2019-11-04 16:58 ` [PATCH v2 4/4] ARM: shmobile_defconfig: Enable support for panels from EDT Fabrizio Castro 2019-11-04 16:58 ` Fabrizio Castro
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=TY1PR01MB1770F97A73768451B2ED8A22C07E0@TY1PR01MB1770.jpnprd01.prod.outlook.com \ --to=fabrizio.castro@bp.renesas.com \ --cc=Chris.Paterson2@renesas.com \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=biju.das@bp.renesas.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert+renesas@glider.be \ --cc=horms@verge.net.au \ --cc=jacopo+renesas@jmondi.org \ --cc=kieran.bingham+renesas@ideasonboard.com \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=mark.rutland@arm.com \ --cc=narmstrong@baylibre.com \ --cc=peda@axentia.se \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.