From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>, Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Joerg Roedel <joro@8bytes.org>, Sergei Shtylyov <sergei.shtylyov@gmail.com>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Magnus Damm <magnus.damm@gmail.com>, dmaengine <dmaengine@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Linux IOMMU <iommu@lists.linux-foundation.org>, netdev <netdev@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: RE: [PATCH 2/9] iommu/ipmmu-vmsa: Hook up R8A774E1 DT matching code Date: Thu, 16 Jul 2020 04:42:21 +0000 [thread overview] Message-ID: <TY2PR01MB3692CFA8B51F91FB9735026FD87F0@TY2PR01MB3692.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAMuHMdUry12MnLvVgmd7NJ+Gv4mA86qKKfsQobP1o-ohzKm=RQ@mail.gmail.com> Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 9:40 PM > > Hi Shimoda-san, > > On Tue, Jul 14, 2020 at 1:42 PM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > > From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 5:42 PM > > > On Tue, Jul 14, 2020 at 10:30 AM Lad, Prabhakar > > > <prabhakar.csengg@gmail.com> wrote: > > > > On Tue, Jul 14, 2020 at 9:09 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > > On Mon, Jul 13, 2020 at 11:35 PM Lad Prabhakar > > > > Also the recent patch to add > > > > "r8a77961" just adds to soc_rcar_gen3_whitelist. > > > > > > Oops, commit 17fe16181639801b ("iommu/renesas: Add support for r8a77961") > > > did it wrong, too. > > > > Thank you for the point it out. We should add r8a77961 to the soc_rcar_gen3[]. > > However, I don't know why I could not realize this issue... > > So, I investigated this a little and then, IIUC, glob_match() which > > soc_device_match() uses seems to return true, if *pat = "r8a7796" and *str = "r8a77961". > > Are you sure about this? I'm very sorry. I completely misunderstood the glob_match() behavior. And, now I understood why the current code can use IPMMU on r8a77961... # Since the first soc_device_match() will return false, ipmmu_slave_whitelist() # will return true and then the ipmmu_of_xlate() will be succeeded. > I enabled CONFIG_GLOB_SELFTEST, and globtest succeeded. > It does test glob_match("a", "aa"), which is a similar test. > > To be 100% sure, I added: > > --- a/lib/globtest.c > +++ b/lib/globtest.c > @@ -59,6 +59,7 @@ static char const glob_tests[] __initconst = > "1" "a\0" "a\0" > "0" "a\0" "b\0" > "0" "a\0" "aa\0" > + "0" "r8a7796\0" "r8a77961\0" > "0" "a\0" "\0" > "1" "\0" "\0" > "0" "\0" "a\0" > > and it still succeeded. I'm very sorry to waste your time about this... Best regards, Yoshihiro Shimoda
WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>, netdev <netdev@vger.kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Sergei Shtylyov <sergei.shtylyov@gmail.com>, Magnus Damm <magnus.damm@gmail.com>, "Lad, Prabhakar" <prabhakar.csengg@gmail.com>, Linux IOMMU <iommu@lists.linux-foundation.org>, Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, dmaengine <dmaengine@vger.kernel.org>, Jakub Kicinski <kuba@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: RE: [PATCH 2/9] iommu/ipmmu-vmsa: Hook up R8A774E1 DT matching code Date: Thu, 16 Jul 2020 04:42:21 +0000 [thread overview] Message-ID: <TY2PR01MB3692CFA8B51F91FB9735026FD87F0@TY2PR01MB3692.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAMuHMdUry12MnLvVgmd7NJ+Gv4mA86qKKfsQobP1o-ohzKm=RQ@mail.gmail.com> Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 9:40 PM > > Hi Shimoda-san, > > On Tue, Jul 14, 2020 at 1:42 PM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > > From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 5:42 PM > > > On Tue, Jul 14, 2020 at 10:30 AM Lad, Prabhakar > > > <prabhakar.csengg@gmail.com> wrote: > > > > On Tue, Jul 14, 2020 at 9:09 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > > On Mon, Jul 13, 2020 at 11:35 PM Lad Prabhakar > > > > Also the recent patch to add > > > > "r8a77961" just adds to soc_rcar_gen3_whitelist. > > > > > > Oops, commit 17fe16181639801b ("iommu/renesas: Add support for r8a77961") > > > did it wrong, too. > > > > Thank you for the point it out. We should add r8a77961 to the soc_rcar_gen3[]. > > However, I don't know why I could not realize this issue... > > So, I investigated this a little and then, IIUC, glob_match() which > > soc_device_match() uses seems to return true, if *pat = "r8a7796" and *str = "r8a77961". > > Are you sure about this? I'm very sorry. I completely misunderstood the glob_match() behavior. And, now I understood why the current code can use IPMMU on r8a77961... # Since the first soc_device_match() will return false, ipmmu_slave_whitelist() # will return true and then the ipmmu_of_xlate() will be succeeded. > I enabled CONFIG_GLOB_SELFTEST, and globtest succeeded. > It does test glob_match("a", "aa"), which is a similar test. > > To be 100% sure, I added: > > --- a/lib/globtest.c > +++ b/lib/globtest.c > @@ -59,6 +59,7 @@ static char const glob_tests[] __initconst = > "1" "a\0" "a\0" > "0" "a\0" "b\0" > "0" "a\0" "aa\0" > + "0" "r8a7796\0" "r8a77961\0" > "0" "a\0" "\0" > "1" "\0" "\0" > "0" "\0" "a\0" > > and it still succeeded. I'm very sorry to waste your time about this... Best regards, Yoshihiro Shimoda _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-07-16 4:42 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-13 21:35 [PATCH 0/9] R8A774E1 SoC enable support for IPMMU, DMAC, GPIO and AVB Lad Prabhakar 2020-07-13 21:35 ` Lad Prabhakar 2020-07-13 21:35 ` [PATCH 1/9] dt-bindings: iommu: renesas,ipmmu-vmsa: Add r8a774e1 support Lad Prabhakar 2020-07-13 21:35 ` [PATCH 1/9] dt-bindings: iommu: renesas, ipmmu-vmsa: " Lad Prabhakar 2020-07-14 7:35 ` [PATCH 1/9] dt-bindings: iommu: renesas,ipmmu-vmsa: " Geert Uytterhoeven 2020-07-14 7:35 ` [PATCH 1/9] dt-bindings: iommu: renesas, ipmmu-vmsa: " Geert Uytterhoeven 2020-07-21 2:02 ` [PATCH 1/9] dt-bindings: iommu: renesas,ipmmu-vmsa: " Rob Herring 2020-07-21 2:02 ` [PATCH 1/9] dt-bindings: iommu: renesas, ipmmu-vmsa: " Rob Herring 2020-07-13 21:35 ` [PATCH 2/9] iommu/ipmmu-vmsa: Hook up R8A774E1 DT matching code Lad Prabhakar 2020-07-13 21:35 ` Lad Prabhakar 2020-07-14 8:09 ` Geert Uytterhoeven 2020-07-14 8:09 ` Geert Uytterhoeven 2020-07-14 8:30 ` Lad, Prabhakar 2020-07-14 8:30 ` Lad, Prabhakar 2020-07-14 8:41 ` Geert Uytterhoeven 2020-07-14 8:41 ` Geert Uytterhoeven 2020-07-14 11:42 ` Yoshihiro Shimoda 2020-07-14 11:42 ` Yoshihiro Shimoda 2020-07-14 12:39 ` Geert Uytterhoeven 2020-07-14 12:39 ` Geert Uytterhoeven 2020-07-16 4:42 ` Yoshihiro Shimoda [this message] 2020-07-16 4:42 ` Yoshihiro Shimoda 2020-07-13 21:35 ` [PATCH 3/9] arm64: dts: renesas: r8a774e1: Add IPMMU device nodes Lad Prabhakar 2020-07-13 21:35 ` Lad Prabhakar 2020-07-15 10:18 ` Geert Uytterhoeven 2020-07-15 10:18 ` Geert Uytterhoeven 2020-07-21 2:01 ` Rob Herring 2020-07-21 2:01 ` Rob Herring 2020-07-13 21:35 ` [PATCH 4/9] dt-bindings: dma: renesas,rcar-dmac: Document R8A774E1 bindings Lad Prabhakar 2020-07-13 21:35 ` [PATCH 4/9] dt-bindings: dma: renesas, rcar-dmac: " Lad Prabhakar 2020-07-14 7:39 ` [PATCH 4/9] dt-bindings: dma: renesas,rcar-dmac: " Geert Uytterhoeven 2020-07-14 7:39 ` Geert Uytterhoeven 2020-07-15 10:40 ` Vinod Koul 2020-07-15 10:40 ` Vinod Koul 2020-07-13 21:35 ` [PATCH 5/9] arm64: dts: renesas: r8a774e1: Add SYS-DMAC device nodes Lad Prabhakar 2020-07-13 21:35 ` Lad Prabhakar 2020-07-15 10:20 ` Geert Uytterhoeven 2020-07-15 10:20 ` Geert Uytterhoeven 2020-07-13 21:35 ` [PATCH 6/9] dt-bindings: gpio: renesas,rcar-gpio: Add r8a774e1 support Lad Prabhakar 2020-07-13 21:35 ` [PATCH 6/9] dt-bindings: gpio: renesas, rcar-gpio: " Lad Prabhakar 2020-07-14 8:00 ` [PATCH 6/9] dt-bindings: gpio: renesas,rcar-gpio: " Geert Uytterhoeven 2020-07-14 8:00 ` [PATCH 6/9] dt-bindings: gpio: renesas, rcar-gpio: " Geert Uytterhoeven 2020-07-21 2:02 ` [PATCH 6/9] dt-bindings: gpio: renesas,rcar-gpio: " Rob Herring 2020-07-21 2:02 ` Rob Herring 2020-08-27 16:39 ` Lad, Prabhakar 2020-08-27 16:39 ` [PATCH 6/9] dt-bindings: gpio: renesas, rcar-gpio: " Lad, Prabhakar 2020-08-27 19:30 ` [PATCH 6/9] dt-bindings: gpio: renesas,rcar-gpio: " Bartosz Golaszewski 2020-08-27 19:30 ` [PATCH 6/9] dt-bindings: gpio: renesas, rcar-gpio: " Bartosz Golaszewski 2020-07-13 21:35 ` [PATCH 7/9] arm64: dts: renesas: r8a774e1: Add GPIO device nodes Lad Prabhakar 2020-07-13 21:35 ` Lad Prabhakar 2020-07-15 10:21 ` Geert Uytterhoeven 2020-07-15 10:21 ` Geert Uytterhoeven 2020-07-13 21:35 ` [PATCH 8/9] dt-bindings: net: renesas,ravb: Add support for r8a774e1 SoC Lad Prabhakar 2020-07-13 21:35 ` [PATCH 8/9] dt-bindings: net: renesas, ravb: " Lad Prabhakar 2020-07-14 7:34 ` [PATCH 8/9] dt-bindings: net: renesas,ravb: " Sergei Shtylyov 2020-07-14 7:34 ` Sergei Shtylyov 2020-07-14 8:01 ` Geert Uytterhoeven 2020-07-14 8:01 ` Geert Uytterhoeven 2020-07-21 2:03 ` Rob Herring 2020-07-21 2:03 ` Rob Herring 2020-08-27 10:28 ` Lad, Prabhakar 2020-08-27 10:28 ` Lad, Prabhakar 2020-09-19 11:10 ` Lad, Prabhakar 2020-09-19 11:10 ` Lad, Prabhakar 2020-07-13 21:35 ` [PATCH 9/9] arm64: dts: renesas: r8a774e1: Add Ethernet AVB node Lad Prabhakar 2020-07-13 21:35 ` Lad Prabhakar 2020-07-15 10:21 ` Geert Uytterhoeven 2020-07-15 10:21 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=TY2PR01MB3692CFA8B51F91FB9735026FD87F0@TY2PR01MB3692.jpnprd01.prod.outlook.com \ --to=yoshihiro.shimoda.uh@renesas.com \ --cc=bgolaszewski@baylibre.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=kuba@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=prabhakar.csengg@gmail.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=robh+dt@kernel.org \ --cc=sergei.shtylyov@gmail.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.