From: Chris Brandt <Chris.Brandt@renesas.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Simon Horman <horms@verge.net.au>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, USB list <linux-usb@vger.kernel.org>, OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org> Subject: RE: [PATCH v3 15/15] ARM: dts: rza2mevb: Add USB host support Date: Wed, 15 May 2019 14:03:07 +0000 [thread overview] Message-ID: <TYXPR01MB15689E3664801057DFCA09EA8A090@TYXPR01MB1568.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAMuHMdXx=7v5v3tHwS-01eNnzz6NSfs=M02jU1tNJMdcRbGScg@mail.gmail.com> Hi Geert, On Wed, May 15, 2019, Geert Uytterhoeven wrote: > > +/* USB-0 as Host */ > > +/* NOTE: Requires JP3 to be fitted */ > > This not applies to the dr_mode property below, right? > So perhaps it should be moved there... > > > +&usb2_phy0 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&usb0_pins>; > > + dr_mode = "host"; > > ... like: > > dr_mode = "host"; /* Requires JP3 to be fitted */ OK, if you think it makes more sense there. > Does resistor R78 need to be mounted, too? By default, R78 and R79 are not populated on these boards, and both Host and Function work fine without board modification, so I would say populating R78 is not a requirement as far as I can tell. Chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Brandt <Chris.Brandt@renesas.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Simon Horman <horms@verge.net.au>, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, Chunfeng Yun <chunfeng.yun@mediatek.com>, USB list <linux-usb@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org> Subject: RE: [PATCH v3 15/15] ARM: dts: rza2mevb: Add USB host support Date: Wed, 15 May 2019 14:03:07 +0000 [thread overview] Message-ID: <TYXPR01MB15689E3664801057DFCA09EA8A090@TYXPR01MB1568.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAMuHMdXx=7v5v3tHwS-01eNnzz6NSfs=M02jU1tNJMdcRbGScg@mail.gmail.com> Hi Geert, On Wed, May 15, 2019, Geert Uytterhoeven wrote: > > +/* USB-0 as Host */ > > +/* NOTE: Requires JP3 to be fitted */ > > This not applies to the dr_mode property below, right? > So perhaps it should be moved there... > > > +&usb2_phy0 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&usb0_pins>; > > + dr_mode = "host"; > > ... like: > > dr_mode = "host"; /* Requires JP3 to be fitted */ OK, if you think it makes more sense there. > Does resistor R78 need to be mounted, too? By default, R78 and R79 are not populated on these boards, and both Host and Function work fine without board modification, so I would say populating R78 is not a requirement as far as I can tell. Chris
next prev parent reply other threads:[~2019-05-15 14:03 UTC|newest] Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-14 14:55 [PATCH v3 00/15] usb: Add host and device support for RZ/A2 Chris Brandt 2019-05-14 14:55 ` Chris Brandt 2019-05-14 14:55 ` [PATCH v3 01/15] ARM: dts: r7s9210: Add USB clock Chris Brandt 2019-05-14 14:55 ` Chris Brandt 2019-05-15 7:38 ` Geert Uytterhoeven 2019-05-15 7:38 ` Geert Uytterhoeven 2019-05-15 7:52 ` Simon Horman 2019-05-15 7:52 ` Simon Horman 2019-05-14 14:55 ` [PATCH v3 02/15] ARM: dts: rza2mevb: Add 48MHz " Chris Brandt 2019-05-14 14:55 ` Chris Brandt 2019-05-15 7:43 ` Geert Uytterhoeven 2019-05-15 7:43 ` Geert Uytterhoeven 2019-05-15 7:53 ` Simon Horman 2019-05-15 7:53 ` Simon Horman 2019-05-14 14:55 ` [PATCH v3 03/15] phy: renesas: rcar-gen3-usb2: detect usb_x1 clock Chris Brandt 2019-05-14 14:55 ` Chris Brandt 2019-05-15 7:32 ` Yoshihiro Shimoda 2019-05-15 7:32 ` Yoshihiro Shimoda 2019-05-15 8:02 ` Simon Horman 2019-05-15 8:30 ` Kuninori Morimoto 2019-05-15 8:30 ` Kuninori Morimoto 2019-05-14 14:55 ` [PATCH v3 04/15] dt-bindings: rcar-gen3-phy-usb2: Document use of usb_x1 Chris Brandt 2019-05-14 14:55 ` Chris Brandt 2019-05-14 19:29 ` Rob Herring 2019-05-14 19:29 ` Rob Herring 2019-05-15 7:33 ` Yoshihiro Shimoda 2019-05-15 7:33 ` Yoshihiro Shimoda 2019-05-15 7:35 ` Geert Uytterhoeven 2019-05-15 7:35 ` Geert Uytterhoeven 2019-05-15 8:39 ` Sergei Shtylyov 2019-05-15 8:39 ` Sergei Shtylyov 2019-05-15 9:03 ` Geert Uytterhoeven 2019-05-15 9:03 ` Geert Uytterhoeven 2019-05-15 7:57 ` Simon Horman 2019-05-14 14:55 ` [PATCH v3 05/15] phy: renesas: rcar-gen3-usb2: Check dr_mode when not using OTG Chris Brandt 2019-05-14 14:55 ` Chris Brandt 2019-05-15 7:34 ` Yoshihiro Shimoda 2019-05-15 7:34 ` Yoshihiro Shimoda 2019-05-15 8:01 ` Simon Horman 2019-05-14 14:55 ` [PATCH v3 06/15] dt-bindings: rcar-gen3-phy-usb2: Document dr_mode Chris Brandt 2019-05-14 14:55 ` Chris Brandt 2019-05-14 19:29 ` Rob Herring 2019-05-14 19:29 ` Rob Herring 2019-05-15 7:36 ` Yoshihiro Shimoda 2019-05-15 7:36 ` Yoshihiro Shimoda 2019-05-15 7:56 ` Simon Horman 2019-05-14 14:55 ` [PATCH v3 07/15] dt-bindings: rcar-gen3-phy-usb2: Add r7s9210 support Chris Brandt 2019-05-14 14:55 ` Chris Brandt 2019-05-14 19:30 ` Rob Herring 2019-05-14 19:30 ` Rob Herring 2019-05-15 7:37 ` Yoshihiro Shimoda 2019-05-15 7:37 ` Yoshihiro Shimoda 2019-05-15 7:56 ` Simon Horman 2019-05-14 14:55 ` [PATCH v3 08/15] usb: renesas_usbhs: move flags to param Chris Brandt 2019-05-14 14:55 ` Chris Brandt 2019-05-15 7:45 ` Yoshihiro Shimoda 2019-05-15 7:45 ` Yoshihiro Shimoda 2019-05-15 7:55 ` Simon Horman 2019-05-14 14:55 ` [PATCH v3 09/15] usb: renesas_usbhs: add support for CNEN bit Chris Brandt 2019-05-14 14:55 ` Chris Brandt 2019-05-15 7:46 ` Yoshihiro Shimoda 2019-05-15 7:46 ` Yoshihiro Shimoda 2019-05-15 7:55 ` Simon Horman 2019-05-14 14:56 ` [PATCH v3 10/15] usb: renesas_usbhs: support byte addressable CFIFO Chris Brandt 2019-05-14 14:56 ` Chris Brandt 2019-05-15 7:48 ` Yoshihiro Shimoda 2019-05-15 7:48 ` Yoshihiro Shimoda 2019-05-15 7:57 ` Yoshihiro Shimoda 2019-05-15 7:57 ` Yoshihiro Shimoda 2019-05-15 8:05 ` Simon Horman 2019-05-14 14:56 ` [PATCH v3 11/15] usb: renesas_usbhs: Add support for RZ/A2 Chris Brandt 2019-05-14 14:56 ` Chris Brandt 2019-05-15 7:52 ` Yoshihiro Shimoda 2019-05-15 7:52 ` Yoshihiro Shimoda 2019-05-15 13:09 ` Chris Brandt 2019-05-15 13:09 ` Chris Brandt 2019-05-15 8:06 ` Simon Horman 2019-05-15 8:26 ` Kuninori Morimoto 2019-05-15 8:26 ` Kuninori Morimoto 2019-05-15 14:18 ` Chris Brandt 2019-05-15 14:18 ` Chris Brandt 2019-05-14 14:56 ` [PATCH v3 12/15] dt-bindings: usb: renesas_usbhs: Add support for r7s9210 Chris Brandt 2019-05-14 14:56 ` Chris Brandt 2019-05-14 19:30 ` Rob Herring 2019-05-14 19:30 ` Rob Herring 2019-05-15 7:53 ` Yoshihiro Shimoda 2019-05-15 7:53 ` Yoshihiro Shimoda 2019-05-15 8:00 ` Geert Uytterhoeven 2019-05-15 8:00 ` Geert Uytterhoeven 2019-05-15 13:11 ` Chris Brandt 2019-05-15 13:11 ` Chris Brandt 2019-05-15 8:07 ` Simon Horman 2019-05-14 14:56 ` [PATCH v3 13/15] ARM: dts: r7s9210: Add USB Host support Chris Brandt 2019-05-14 14:56 ` Chris Brandt 2019-05-15 7:59 ` Geert Uytterhoeven 2019-05-15 7:59 ` Geert Uytterhoeven 2019-05-15 13:38 ` Chris Brandt 2019-05-15 13:38 ` Chris Brandt 2019-05-15 9:05 ` Geert Uytterhoeven 2019-05-15 9:05 ` Geert Uytterhoeven 2019-05-14 14:56 ` [PATCH v3 14/15] ARM: dts: r7s9210: Add USB Device support Chris Brandt 2019-05-14 14:56 ` Chris Brandt 2019-05-15 8:02 ` Geert Uytterhoeven 2019-05-15 8:02 ` Geert Uytterhoeven 2019-05-14 14:56 ` [PATCH v3 15/15] ARM: dts: rza2mevb: Add USB host support Chris Brandt 2019-05-14 14:56 ` Chris Brandt 2019-05-15 8:21 ` Geert Uytterhoeven 2019-05-15 8:21 ` Geert Uytterhoeven 2019-05-15 14:03 ` Chris Brandt [this message] 2019-05-15 14:03 ` Chris Brandt 2019-05-15 14:33 ` Geert Uytterhoeven 2019-05-15 14:33 ` Geert Uytterhoeven 2019-05-15 14:54 ` Chris Brandt 2019-05-15 14:54 ` Chris Brandt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=TYXPR01MB15689E3664801057DFCA09EA8A090@TYXPR01MB1568.jpnprd01.prod.outlook.com \ --to=chris.brandt@renesas.com \ --cc=chunfeng.yun@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=gregkh@linuxfoundation.org \ --cc=horms@verge.net.au \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=sergei.shtylyov@cogentembedded.com \ --cc=yoshihiro.shimoda.uh@renesas.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.