Re: [PATCH v2 01/17] regmap-irq: Use sub_irq_reg() to calculate unmask register address

From: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
To: Guru Das Srinagesh <quic_gurus@quicinc.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, wens@csie.org,
	jic23@kernel.org, lee.jones@linaro.org, sre@kernel.org,
	broonie@kernel.org, gregkh@linuxfoundation.org,
	lgirdwood@gmail.com, lars@metafoo.de, rafael@kernel.org,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 01/17] regmap-irq: Use sub_irq_reg() to calculate unmask register address
Date: Sat, 11 Jun 2022 15:32:22 +0100	[thread overview]
Message-ID: <V6MQEsBelMvjoBF1C6KDbaHcQIWzvqhC@localhost> (raw)
In-Reply-To: <20220609163920.GA7420@quicinc.com>

Guru Das Srinagesh <quic_gurus@quicinc.com> writes:

> On Tue, Jun 07, 2022 at 04:53:08PM +0100, Aidan MacDonald wrote:
>> Call sub_irq_reg() instead of calculating the offset of the register
>> to avoid relying on the fact that sub_irq_reg() is a linear function.
>
> Seems like unmask_reg is the only register whose address is not calculated
> using sub_irq_reg(). Switching to using sub_irq_reg() will bring it in line
> with the other calculations.
>
> Could you please incorporate this info in your commit message as well? This
> should be the rationale for this change; that it allows for the get_irq_reg()
> patch should be secondary.

I'll note that in v3, thanks.

>
> The change seems okay to me, but I'd ideally like someone to pick this up and
> test it out just to make sure it doesn't break existing behaviour for them.
>
> Thank you.
>
> Guru Das.