From: Jun Li <jun.li@nxp.com> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "balbi@kernel.org" <balbi@kernel.org>, "mathias.nyman@intel.com" <mathias.nyman@intel.com>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>, Anson Huang <anson.huang@nxp.com>, Aisheng Dong <aisheng.dong@nxp.com>, Peng Fan <peng.fan@nxp.com>, Andy Duan <fugang.duan@nxp.com>, Joakim Zhang <qiangqing.zhang@nxp.com>, Horia Geanta <horia.geanta@nxp.com>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH v3 5/6] arm64: dtsi: imx8mp: add usb nodes Date: Wed, 23 Sep 2020 08:49:02 +0000 [thread overview] Message-ID: <VE1PR04MB6528E04C7D110000509B6D3C89380@VE1PR04MB6528.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200923075040.GD25328@pengutronix.de> > -----Original Message----- > From: Sascha Hauer <s.hauer@pengutronix.de> > Sent: Wednesday, September 23, 2020 3:51 PM > To: Jun Li <jun.li@nxp.com> > Cc: robh+dt@kernel.org; shawnguo@kernel.org; balbi@kernel.org; > mathias.nyman@intel.com; gregkh@linuxfoundation.org; > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx > <linux-imx@nxp.com>; Anson Huang <anson.huang@nxp.com>; Aisheng Dong > <aisheng.dong@nxp.com>; Peng Fan <peng.fan@nxp.com>; Andy Duan > <fugang.duan@nxp.com>; Joakim Zhang <qiangqing.zhang@nxp.com>; Horia > Geanta <horia.geanta@nxp.com>; linux-usb@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v3 5/6] arm64: dtsi: imx8mp: add usb nodes > > On Tue, Sep 22, 2020 at 06:46:51PM +0800, Li Jun wrote: > > imx8mp integrates 2 identical dwc3 based USB3 controllers and Synopsys > > phys, each instance has additional wakeup logic to support low power > > mode, so the glue layer need a node with dwc3 core sub node. > > > > Signed-off-by: Li Jun <jun.li@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 88 > > +++++++++++++++++++++++++++++++ > > 1 file changed, 88 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > index 9de2aa1..1b7ed4c 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > + usb3_1: usb@32f10108 { > > + compatible = "fsl,imx8mp-dwc3"; > > + reg = <0x32f10108 0x8>; > > + clocks = <&clk IMX8MP_CLK_HSIO_ROOT>, > > + <&clk IMX8MP_CLK_USB_ROOT>; > > + clock-names = "hsio", "suspend"; > > + assigned-clocks = <&clk IMX8MP_CLK_HSIO_AXI_SRC>; > > In Linux-5.9-rc6 this clock doesn't exist anymore. Should be > IMX8MP_CLK_HSIO_AXI Will change. > > > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_500M>; > > + assigned-clock-rates = <500000000>; > > + interrupts = <GIC_SPI 149 IRQ_TYPE_LEVEL_HIGH>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + status = "disabled"; > > + > > + usb_dwc3_1: dwc3@38200000 { > > + compatible = "snps,dwc3"; > > + reg = <0x38200000 0x10000>; > > + clocks = <&clk IMX8MP_CLK_HSIO_AXI>, > > + <&clk IMX8MP_CLK_USB_CORE_REF>, > > + <&clk IMX8MP_CLK_USB_ROOT>; > > + clock-names = "bus_early", "ref", "suspend"; > > + assigned-clocks = <&clk IMX8MP_CLK_HSIO_AXI>; > > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_500M>; > > + assigned-clock-rates = <500000000>; > > + interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>; > > + phys = <&usb3_phy1>, <&usb3_phy1>; > > + phy-names = "usb2-phy", "usb3-phy"; > > + snps,dis-u2-freeclk-exists-quirk; > > + xhci-64bit-support-disable; > > + status = "disabled"; > > Does it make sense for a board to enable the parent node and leave this one > disabled? If not you can drop this status = "disabled" here. OK, will drop it. Thanks Li Jun > > Sascha > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe > ngutronix.de%2F&data=02%7C01%7Cjun.li%40nxp.com%7Cadbbbfe2edec4cca1 > 38908d85f956382%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6373644425 > 20571896&sdata=07ku8kTQCv8lv8qdRiOcU3CX4lly3503LO4bUDIbjow%3D&r > eserved=0 | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Jun Li <jun.li@nxp.com> To: Sascha Hauer <s.hauer@pengutronix.de> Cc: Aisheng Dong <aisheng.dong@nxp.com>, "balbi@kernel.org" <balbi@kernel.org>, Peng Fan <peng.fan@nxp.com>, "festevam@gmail.com" <festevam@gmail.com>, Andy Duan <fugang.duan@nxp.com>, Anson Huang <anson.huang@nxp.com>, "mathias.nyman@intel.com" <mathias.nyman@intel.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, Joakim Zhang <qiangqing.zhang@nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, Horia Geanta <horia.geanta@nxp.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: RE: [PATCH v3 5/6] arm64: dtsi: imx8mp: add usb nodes Date: Wed, 23 Sep 2020 08:49:02 +0000 [thread overview] Message-ID: <VE1PR04MB6528E04C7D110000509B6D3C89380@VE1PR04MB6528.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200923075040.GD25328@pengutronix.de> > -----Original Message----- > From: Sascha Hauer <s.hauer@pengutronix.de> > Sent: Wednesday, September 23, 2020 3:51 PM > To: Jun Li <jun.li@nxp.com> > Cc: robh+dt@kernel.org; shawnguo@kernel.org; balbi@kernel.org; > mathias.nyman@intel.com; gregkh@linuxfoundation.org; > kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx > <linux-imx@nxp.com>; Anson Huang <anson.huang@nxp.com>; Aisheng Dong > <aisheng.dong@nxp.com>; Peng Fan <peng.fan@nxp.com>; Andy Duan > <fugang.duan@nxp.com>; Joakim Zhang <qiangqing.zhang@nxp.com>; Horia > Geanta <horia.geanta@nxp.com>; linux-usb@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v3 5/6] arm64: dtsi: imx8mp: add usb nodes > > On Tue, Sep 22, 2020 at 06:46:51PM +0800, Li Jun wrote: > > imx8mp integrates 2 identical dwc3 based USB3 controllers and Synopsys > > phys, each instance has additional wakeup logic to support low power > > mode, so the glue layer need a node with dwc3 core sub node. > > > > Signed-off-by: Li Jun <jun.li@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 88 > > +++++++++++++++++++++++++++++++ > > 1 file changed, 88 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > index 9de2aa1..1b7ed4c 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > + usb3_1: usb@32f10108 { > > + compatible = "fsl,imx8mp-dwc3"; > > + reg = <0x32f10108 0x8>; > > + clocks = <&clk IMX8MP_CLK_HSIO_ROOT>, > > + <&clk IMX8MP_CLK_USB_ROOT>; > > + clock-names = "hsio", "suspend"; > > + assigned-clocks = <&clk IMX8MP_CLK_HSIO_AXI_SRC>; > > In Linux-5.9-rc6 this clock doesn't exist anymore. Should be > IMX8MP_CLK_HSIO_AXI Will change. > > > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_500M>; > > + assigned-clock-rates = <500000000>; > > + interrupts = <GIC_SPI 149 IRQ_TYPE_LEVEL_HIGH>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + status = "disabled"; > > + > > + usb_dwc3_1: dwc3@38200000 { > > + compatible = "snps,dwc3"; > > + reg = <0x38200000 0x10000>; > > + clocks = <&clk IMX8MP_CLK_HSIO_AXI>, > > + <&clk IMX8MP_CLK_USB_CORE_REF>, > > + <&clk IMX8MP_CLK_USB_ROOT>; > > + clock-names = "bus_early", "ref", "suspend"; > > + assigned-clocks = <&clk IMX8MP_CLK_HSIO_AXI>; > > + assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_500M>; > > + assigned-clock-rates = <500000000>; > > + interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>; > > + phys = <&usb3_phy1>, <&usb3_phy1>; > > + phy-names = "usb2-phy", "usb3-phy"; > > + snps,dis-u2-freeclk-exists-quirk; > > + xhci-64bit-support-disable; > > + status = "disabled"; > > Does it make sense for a board to enable the parent node and leave this one > disabled? If not you can drop this status = "disabled" here. OK, will drop it. Thanks Li Jun > > Sascha > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe > ngutronix.de%2F&data=02%7C01%7Cjun.li%40nxp.com%7Cadbbbfe2edec4cca1 > 38908d85f956382%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6373644425 > 20571896&sdata=07ku8kTQCv8lv8qdRiOcU3CX4lly3503LO4bUDIbjow%3D&r > eserved=0 | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-23 8:49 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-22 10:46 [PATCH v3 0/6] add NXP imx8mp usb support Li Jun 2020-09-22 10:46 ` Li Jun 2020-09-22 10:46 ` [PATCH v3 1/6] dt-bindings: usb: xhci: add property to disable xhci 64bit support Li Jun 2020-09-22 10:46 ` Li Jun 2020-09-29 18:11 ` Rob Herring 2020-09-29 18:11 ` Rob Herring 2020-10-02 16:39 ` Jun Li 2020-10-02 16:39 ` Jun Li 2020-09-22 10:46 ` [PATCH v3 2/6] usb: host: xhci-plat: add support of XHCI_NO_64BIT_SUPPORT via property Li Jun 2020-09-22 10:46 ` Li Jun 2020-09-22 10:46 ` [PATCH v3 3/6] dt-bindings: usb: dwc3-imx8mp: add imx8mp dwc3 glue bindings Li Jun 2020-09-22 10:46 ` Li Jun 2020-09-22 14:32 ` Krzysztof Kozlowski 2020-09-22 14:32 ` Krzysztof Kozlowski 2020-09-22 16:45 ` Jun Li 2020-09-22 16:45 ` Jun Li 2020-09-22 18:22 ` Krzysztof Kozlowski 2020-09-22 18:22 ` Krzysztof Kozlowski 2020-09-22 10:46 ` [PATCH v3 4/6] usb: dwc3: add imx8mp dwc3 glue layer driver Li Jun 2020-09-22 10:46 ` Li Jun 2020-09-22 10:46 ` [PATCH v3 5/6] arm64: dtsi: imx8mp: add usb nodes Li Jun 2020-09-22 10:46 ` Li Jun 2020-09-22 14:39 ` Krzysztof Kozlowski 2020-09-22 14:39 ` Krzysztof Kozlowski 2020-09-23 7:50 ` Sascha Hauer 2020-09-23 7:50 ` Sascha Hauer 2020-09-23 8:49 ` Jun Li [this message] 2020-09-23 8:49 ` Jun Li 2020-09-22 10:46 ` [PATCH v3 6/6] arm64: dts: imx8mp-evk: enable usb1 as host mode Li Jun 2020-09-22 10:46 ` Li Jun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=VE1PR04MB6528E04C7D110000509B6D3C89380@VE1PR04MB6528.eurprd04.prod.outlook.com \ --to=jun.li@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=anson.huang@nxp.com \ --cc=balbi@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=fugang.duan@nxp.com \ --cc=gregkh@linuxfoundation.org \ --cc=horia.geanta@nxp.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-usb@vger.kernel.org \ --cc=mathias.nyman@intel.com \ --cc=peng.fan@nxp.com \ --cc=qiangqing.zhang@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.