From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: "jocke@infinera.com" <joakim.tjernlund@infinera.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Madalin-cristian Bucur <madalin.bucur@nxp.com>,
Leo Li <leoyang.li@nxp.com>, Roy Pledge <roy.pledge@nxp.com>,
Camelia Alexandra Groza <camelia.groza@nxp.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>
Subject: RE: [PATCH v2 9/9] dpaa_eth: fix SG frame cleanup
Date: Thu, 2 May 2019 09:05:41 +0000 [thread overview]
Message-ID: <VI1PR04MB5134C0D6707E78D674B96898EC340@VI1PR04MB5134.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <2c6f5d170edab346e0a87b1dfeb12e2f65801685.camel@infinera.com>
Hi Joakim,
> -----Original Message-----
> From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> Sent: Saturday, April 27, 2019 8:11 PM
>
> On Sat, 2019-04-27 at 10:10 +0300, laurentiu.tudor@nxp.com wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> >
> > Fix issue with the entry indexing in the sg frame cleanup code being
> > off-by-1. This problem showed up when doing some basic iperf tests and
> > manifested in traffic coming to a halt.
> >
> > Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> > Acked-by: Madalin Bucur <madalin.bucur@nxp.com>
>
> Wasn't this a stable candidate too?
Yes, it is. I forgot to add the cc:stable tag, sorry about that.
---
Best Regards, Laurentiu
> > ---
> > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > index daede7272768..40420edc9ce6 100644
> > --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > @@ -1663,7 +1663,7 @@ static struct sk_buff *dpaa_cleanup_tx_fd(const
> struct dpaa_priv *priv,
> > qm_sg_entry_get_len(&sgt[0]), dma_dir);
> >
> > /* remaining pages were mapped with skb_frag_dma_map()
> */
> > - for (i = 1; i < nr_frags; i++) {
> > + for (i = 1; i <= nr_frags; i++) {
> > WARN_ON(qm_sg_entry_is_ext(&sgt[i]));
> >
> > dma_unmap_page(dev, qm_sg_addr(&sgt[i]),
> > --
> > 2.17.1
> >
WARNING: multiple messages have this Message-ID (diff)
From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: "jocke@infinera.com" <joakim.tjernlund@infinera.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Madalin-cristian Bucur <madalin.bucur@nxp.com>,
Leo Li <leoyang.li@nxp.com>, Roy Pledge <roy.pledge@nxp.com>,
Camelia Alexandra Groza <camelia.groza@nxp.com>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [PATCH v2 9/9] dpaa_eth: fix SG frame cleanup
Date: Thu, 2 May 2019 09:05:41 +0000 [thread overview]
Message-ID: <VI1PR04MB5134C0D6707E78D674B96898EC340@VI1PR04MB5134.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <2c6f5d170edab346e0a87b1dfeb12e2f65801685.camel@infinera.com>
Hi Joakim,
> -----Original Message-----
> From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> Sent: Saturday, April 27, 2019 8:11 PM
>
> On Sat, 2019-04-27 at 10:10 +0300, laurentiu.tudor@nxp.com wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> >
> > Fix issue with the entry indexing in the sg frame cleanup code being
> > off-by-1. This problem showed up when doing some basic iperf tests and
> > manifested in traffic coming to a halt.
> >
> > Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> > Acked-by: Madalin Bucur <madalin.bucur@nxp.com>
>
> Wasn't this a stable candidate too?
Yes, it is. I forgot to add the cc:stable tag, sorry about that.
---
Best Regards, Laurentiu
> > ---
> > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > index daede7272768..40420edc9ce6 100644
> > --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > @@ -1663,7 +1663,7 @@ static struct sk_buff *dpaa_cleanup_tx_fd(const
> struct dpaa_priv *priv,
> > qm_sg_entry_get_len(&sgt[0]), dma_dir);
> >
> > /* remaining pages were mapped with skb_frag_dma_map()
> */
> > - for (i = 1; i < nr_frags; i++) {
> > + for (i = 1; i <= nr_frags; i++) {
> > WARN_ON(qm_sg_entry_is_ext(&sgt[i]));
> >
> > dma_unmap_page(dev, qm_sg_addr(&sgt[i]),
> > --
> > 2.17.1
> >
WARNING: multiple messages have this Message-ID (diff)
From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: "jocke@infinera.com" <joakim.tjernlund@infinera.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Madalin-cristian Bucur <madalin.bucur@nxp.com>,
Leo Li <leoyang.li@nxp.com>, Roy Pledge <roy.pledge@nxp.com>,
Camelia Alexandra Groza <camelia.groza@nxp.com>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [PATCH v2 9/9] dpaa_eth: fix SG frame cleanup
Date: Thu, 2 May 2019 09:05:41 +0000 [thread overview]
Message-ID: <VI1PR04MB5134C0D6707E78D674B96898EC340@VI1PR04MB5134.eurprd04.prod.outlook.com> (raw)
Message-ID: <20190502090541.tHMEJoQcWuuhtnquzoNxvUsNDjOfLY1sc6w0f9uwLR8@z> (raw)
In-Reply-To: <2c6f5d170edab346e0a87b1dfeb12e2f65801685.camel@infinera.com>
Hi Joakim,
> -----Original Message-----
> From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> Sent: Saturday, April 27, 2019 8:11 PM
>
> On Sat, 2019-04-27 at 10:10 +0300, laurentiu.tudor@nxp.com wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> >
> > Fix issue with the entry indexing in the sg frame cleanup code being
> > off-by-1. This problem showed up when doing some basic iperf tests and
> > manifested in traffic coming to a halt.
> >
> > Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> > Acked-by: Madalin Bucur <madalin.bucur@nxp.com>
>
> Wasn't this a stable candidate too?
Yes, it is. I forgot to add the cc:stable tag, sorry about that.
---
Best Regards, Laurentiu
> > ---
> > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > index daede7272768..40420edc9ce6 100644
> > --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > @@ -1663,7 +1663,7 @@ static struct sk_buff *dpaa_cleanup_tx_fd(const
> struct dpaa_priv *priv,
> > qm_sg_entry_get_len(&sgt[0]), dma_dir);
> >
> > /* remaining pages were mapped with skb_frag_dma_map()
> */
> > - for (i = 1; i < nr_frags; i++) {
> > + for (i = 1; i <= nr_frags; i++) {
> > WARN_ON(qm_sg_entry_is_ext(&sgt[i]));
> >
> > dma_unmap_page(dev, qm_sg_addr(&sgt[i]),
> > --
> > 2.17.1
> >
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: "jocke@infinera.com" <joakim.tjernlund@infinera.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Madalin-cristian Bucur <madalin.bucur@nxp.com>,
Leo Li <leoyang.li@nxp.com>, Roy Pledge <roy.pledge@nxp.com>,
Camelia Alexandra Groza <camelia.groza@nxp.com>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [PATCH v2 9/9] dpaa_eth: fix SG frame cleanup
Date: Thu, 2 May 2019 09:05:41 +0000 [thread overview]
Message-ID: <VI1PR04MB5134C0D6707E78D674B96898EC340@VI1PR04MB5134.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <2c6f5d170edab346e0a87b1dfeb12e2f65801685.camel@infinera.com>
Hi Joakim,
> -----Original Message-----
> From: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> Sent: Saturday, April 27, 2019 8:11 PM
>
> On Sat, 2019-04-27 at 10:10 +0300, laurentiu.tudor@nxp.com wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> >
> > Fix issue with the entry indexing in the sg frame cleanup code being
> > off-by-1. This problem showed up when doing some basic iperf tests and
> > manifested in traffic coming to a halt.
> >
> > Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> > Acked-by: Madalin Bucur <madalin.bucur@nxp.com>
>
> Wasn't this a stable candidate too?
Yes, it is. I forgot to add the cc:stable tag, sorry about that.
---
Best Regards, Laurentiu
> > ---
> > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > index daede7272768..40420edc9ce6 100644
> > --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> > @@ -1663,7 +1663,7 @@ static struct sk_buff *dpaa_cleanup_tx_fd(const
> struct dpaa_priv *priv,
> > qm_sg_entry_get_len(&sgt[0]), dma_dir);
> >
> > /* remaining pages were mapped with skb_frag_dma_map()
> */
> > - for (i = 1; i < nr_frags; i++) {
> > + for (i = 1; i <= nr_frags; i++) {
> > WARN_ON(qm_sg_entry_is_ext(&sgt[i]));
> >
> > dma_unmap_page(dev, qm_sg_addr(&sgt[i]),
> > --
> > 2.17.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-02 9:05 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-27 7:10 [PATCH v2 0/9] Prerequisites for NXP LS104xA SMMU enablement laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` [PATCH v2 1/9] soc/fsl/qman: fixup liodns only on ppc targets laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-05-01 20:08 ` Li Yang
2019-05-01 20:08 ` Li Yang
2019-05-01 20:08 ` Li Yang
2019-05-01 20:08 ` Li Yang
2019-05-01 20:08 ` Li Yang
2019-04-27 7:10 ` [PATCH v2 2/9] soc/fsl/qbman_portals: add APIs to retrieve the probing status laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-05-01 19:47 ` Li Yang
2019-05-01 19:47 ` Li Yang
2019-05-01 19:47 ` Li Yang
2019-05-01 19:47 ` Li Yang
2019-05-01 19:47 ` Li Yang
2019-04-27 7:10 ` [PATCH v2 3/9] fsl/fman: backup and restore ICID registers laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 16:18 ` David Miller
2019-04-27 16:18 ` David Miller
2019-04-27 16:18 ` David Miller
2019-04-27 16:18 ` David Miller
2019-04-27 7:10 ` [PATCH v2 4/9] fsl/fman: add API to get the device behind a fman port laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` [PATCH v2 5/9] dpaa_eth: defer probing after qbman laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` [PATCH v2 6/9] dpaa_eth: base dma mappings on the fman rx port laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` [PATCH v2 7/9] dpaa_eth: fix iova handling for contiguous frames laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 16:46 ` Christoph Hellwig
2019-04-27 16:46 ` Christoph Hellwig
2019-04-27 16:46 ` Christoph Hellwig
2019-04-27 16:46 ` Christoph Hellwig
2019-05-02 9:10 ` Laurentiu Tudor
2019-05-02 9:10 ` Laurentiu Tudor
2019-05-02 9:10 ` Laurentiu Tudor
2019-05-02 9:10 ` Laurentiu Tudor
2019-05-02 9:10 ` Laurentiu Tudor
2019-04-27 7:10 ` [PATCH v2 8/9] dpaa_eth: fix iova handling for sg frames laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` [PATCH v2 9/9] dpaa_eth: fix SG frame cleanup laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 7:10 ` laurentiu.tudor
2019-04-27 17:10 ` Joakim Tjernlund
2019-04-27 17:10 ` Joakim Tjernlund
2019-04-27 17:10 ` Joakim Tjernlund
2019-04-27 17:10 ` Joakim Tjernlund
2019-04-27 17:10 ` Joakim Tjernlund
2019-05-02 9:05 ` Laurentiu Tudor [this message]
2019-05-02 9:05 ` Laurentiu Tudor
2019-05-02 9:05 ` Laurentiu Tudor
2019-05-02 9:05 ` Laurentiu Tudor
2019-05-02 9:05 ` Laurentiu Tudor
2019-05-02 10:36 ` Joakim Tjernlund
2019-05-02 10:36 ` Joakim Tjernlund
2019-05-02 10:36 ` Joakim Tjernlund
2019-05-02 10:36 ` Joakim Tjernlund
2019-05-02 10:36 ` Joakim Tjernlund
2019-05-02 12:58 ` Laurentiu Tudor
2019-05-02 12:58 ` Laurentiu Tudor
2019-05-02 12:58 ` Laurentiu Tudor
2019-05-02 12:58 ` Laurentiu Tudor
2019-05-02 12:58 ` Laurentiu Tudor
2019-05-02 13:03 ` Joakim Tjernlund
2019-05-02 13:03 ` Joakim Tjernlund
2019-05-02 13:03 ` Joakim Tjernlund
2019-05-02 13:03 ` Joakim Tjernlund
2019-05-02 13:03 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB5134C0D6707E78D674B96898EC340@VI1PR04MB5134.eurprd04.prod.outlook.com \
--to=laurentiu.tudor@nxp.com \
--cc=camelia.groza@nxp.com \
--cc=davem@davemloft.net \
--cc=iommu@lists.linux-foundation.org \
--cc=joakim.tjernlund@infinera.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=roy.pledge@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.