All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Z.q. Hou" <zhiqiang.hou@nxp.com>
To: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	Leo Li <leoyang.li@nxp.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	Mingkai Hu <mingkai.hu@nxp.com>,
	"M.h. Lian" <minghuan.lian@nxp.com>,
	Xiaowei Bao <xiaowei.bao@nxp.com>
Subject: RE: [PATCHv3 23/27] PCI: mobiveil: add PCIe Gen4 RC driver for NXP Layerscape SoCs
Date: Mon, 18 Feb 2019 07:05:35 +0000	[thread overview]
Message-ID: <VI1PR04MB5792E6493E8372A73B60FDD784630@VI1PR04MB5792.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAFZiPx0aGTy6yQ=fCojjP1awLEHevPSHRCUDEFL7KJtA4t=CGw@mail.gmail.com>

Hi Subbu,

Thanks a lot for your comments!

> -----Original Message-----
> From: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
> Sent: 2019年2月8日 20:50
> To: Z.q. Hou <zhiqiang.hou@nxp.com>
> Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> bhelgaas@google.com; robh+dt@kernel.org; mark.rutland@arm.com;
> shawnguo@kernel.org; Leo Li <leoyang.li@nxp.com>;
> lorenzo.pieralisi@arm.com; catalin.marinas@arm.com;
> will.deacon@arm.com; Mingkai Hu <mingkai.hu@nxp.com>; M.h. Lian
> <minghuan.lian@nxp.com>; Xiaowei Bao <xiaowei.bao@nxp.com>
> Subject: Re: [PATCHv3 23/27] PCI: mobiveil: add PCIe Gen4 RC driver for NXP
> Layerscape SoCs
> 
> ZQ,
> 
> 
> On Tue, Jan 29, 2019 at 1:40 PM Z.q. Hou <zhiqiang.hou@nxp.com> wrote:
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > This PCIe controller is based on the Mobiveil GPEX IP, which is
> > compatible with the PCI Express™ Base Specification, Revision 4.0.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>
> > ---
> > V3:
> >  - No change
> >
> >  drivers/pci/controller/mobiveil/Kconfig       |  10 +
> >  drivers/pci/controller/mobiveil/Makefile      |   1 +
> >  .../controller/mobiveil/pci-layerscape-gen4.c | 254 ++++++++++++++++++
> >  .../pci/controller/mobiveil/pcie-mobiveil.h   |  16 +-
> >  4 files changed, 279 insertions(+), 2 deletions(-)  create mode
> > 100644 drivers/pci/controller/mobiveil/pci-layerscape-gen4.c
> >
> > diff --git a/drivers/pci/controller/mobiveil/Kconfig
> > b/drivers/pci/controller/mobiveil/Kconfig
> > index 64343c07bfed..3ddb7d6163a9 100644
> > --- a/drivers/pci/controller/mobiveil/Kconfig
> > +++ b/drivers/pci/controller/mobiveil/Kconfig
> > @@ -21,4 +21,14 @@ config PCIE_MOBIVEIL_PLAT
> >           Soft IP. It has up to 8 outbound and inbound windows
> >           for address translation and it is a PCIe Gen4 IP.
> >
> > +config PCI_LAYERSCAPE_GEN4
> > +       bool "Freescale Layerscpe PCIe Gen4 controller"
> > +       depends on PCI
> > +       depends on OF && (ARM64 || ARCH_LAYERSCAPE)
> > +       depends on PCI_MSI_IRQ_DOMAIN
> > +       select PCIE_MOBIVEIL_HOST
> > +       help
> > +         Say Y here if you want PCIe Gen4 controller support on
> > +         Layerscape SoCs. The PCIe controller can work in RC or
> > +         EP mode according to RCW[HOST_AGT_PEX] setting.
> >  endmenu
> > diff --git a/drivers/pci/controller/mobiveil/Makefile
> > b/drivers/pci/controller/mobiveil/Makefile
> > index 9fb6d1c6504d..ff66774ccac4 100644
> > --- a/drivers/pci/controller/mobiveil/Makefile
> > +++ b/drivers/pci/controller/mobiveil/Makefile
> > @@ -2,3 +2,4 @@
> >  obj-$(CONFIG_PCIE_MOBIVEIL) += pcie-mobiveil.o
> >  obj-$(CONFIG_PCIE_MOBIVEIL_HOST) += pcie-mobiveil-host.o
> >  obj-$(CONFIG_PCIE_MOBIVEIL_PLAT) += pcie-mobiveil-plat.o
> > +obj-$(CONFIG_PCI_LAYERSCAPE_GEN4) += pci-layerscape-gen4.o
> > diff --git a/drivers/pci/controller/mobiveil/pci-layerscape-gen4.c
> > b/drivers/pci/controller/mobiveil/pci-layerscape-gen4.c
> > new file mode 100644
> > index 000000000000..174cbcac4059
> > --- /dev/null
> > +++ b/drivers/pci/controller/mobiveil/pci-layerscape-gen4.c
> > @@ -0,0 +1,254 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * PCIe host controller driver for NXP Layerscape SoCs
> > + *
> > + * Copyright 2018 NXP
> > + *
> > + * Author: Zhiqiang Hou <Zhiqiang.Hou@nxp.com>  */
> > +
> > +#include <linux/kernel.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/init.h>
> > +#include <linux/of_pci.h>
> > +#include <linux/of_platform.h>
> > +#include <linux/of_irq.h>
> > +#include <linux/of_address.h>
> > +#include <linux/pci.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/resource.h>
> > +#include <linux/mfd/syscon.h>
> > +#include <linux/regmap.h>
> > +
> > +#include "pcie-mobiveil.h"
> > +
> > +/* LUT and PF control registers */
> > +#define PCIE_LUT_OFF                   (0x80000)
> > +#define PCIE_PF_OFF                    (0xc0000)
> > +#define PCIE_PF_INT_STAT               (0x18)
> > +#define PF_INT_STAT_PABRST             (31)
> > +
> > +#define PCIE_PF_DBG                    (0x7fc)
> > +#define PF_DBG_LTSSM_MASK              (0x3f)
> > +#define PF_DBG_WE                      (31)
> > +#define PF_DBG_PABR                    (27)
> > +
> > +#define LS_PCIE_G4_LTSSM_L0            0x2d /* L0 state */
> > +
> > +#define to_ls_pcie_g4(x)
> platform_get_drvdata((x)->pdev)
> > +
> > +struct ls_pcie_g4 {
> > +       struct mobiveil_pcie *pci;
> > +       struct delayed_work dwork;
> > +       int irq;
> > +};
> > +
> > +static inline u32 ls_pcie_g4_lut_readl(struct ls_pcie_g4 *pcie, u32
> > +off) {
> > +       return ioread32(pcie->pci->csr_axi_slave_base + PCIE_LUT_OFF +
> > +off); }
> > +
> > +static inline void ls_pcie_g4_lut_writel(struct ls_pcie_g4 *pcie,
> > +                                        u32 off, u32 val) {
> > +       iowrite32(val, pcie->pci->csr_axi_slave_base + PCIE_LUT_OFF +
> > +off); }
> > +
> > +static inline u32 ls_pcie_g4_pf_readl(struct ls_pcie_g4 *pcie, u32
> > +off) {
> > +       return ioread32(pcie->pci->csr_axi_slave_base + PCIE_PF_OFF +
> > +off); }
> > +
> > +static inline void ls_pcie_g4_pf_writel(struct ls_pcie_g4 *pcie,
> > +                                       u32 off, u32 val) {
> > +       iowrite32(val, pcie->pci->csr_axi_slave_base + PCIE_PF_OFF +
> > +off); }
> > +
> > +static bool ls_pcie_g4_is_bridge(struct ls_pcie_g4 *pcie) {
> > +       struct mobiveil_pcie *mv_pci = pcie->pci;
> > +       u32 header_type;
> > +
> > +       header_type = csr_readb(mv_pci, PCI_HEADER_TYPE);
> > +       header_type &= 0x7f;
> > +
> > +       return header_type == PCI_HEADER_TYPE_BRIDGE; }
> > +
> > +static int ls_pcie_g4_link_up(struct mobiveil_pcie *pci) {
> > +       struct ls_pcie_g4 *pcie = to_ls_pcie_g4(pci);
> > +       u32 state;
> > +
> > +       state = ls_pcie_g4_pf_readl(pcie, PCIE_PF_DBG);
> > +       state = state & PF_DBG_LTSSM_MASK;
> > +
> > +       if (state == LS_PCIE_G4_LTSSM_L0)
> > +               return 1;
> > +
> > +       return 0;
> > +}
> > +
> > +static void ls_pcie_g4_reinit_hw(struct ls_pcie_g4 *pcie) {
> > +       struct mobiveil_pcie *mv_pci = pcie->pci;
> > +       u32 val, act_stat;
> > +       int to = 100;
> > +
> > +       /* Poll for pab_csb_reset to set and PAB activity to clear */
> > +       do {
> > +               usleep_range(10, 15);
> > +               val = ls_pcie_g4_pf_readl(pcie, PCIE_PF_INT_STAT);
> > +               act_stat = csr_readl(mv_pci, PAB_ACTIVITY_STAT);
> > +       } while (((val & 1 << PF_INT_STAT_PABRST) == 0 || act_stat) &&
> to--);
> > +       if (to < 0) {
> > +               dev_err(&mv_pci->pdev->dev, "poll PABRST&PABACT
> timeout\n");
> > +               return;
> > +       }
> > +
> > +       /* clear PEX_RESET bit in PEX_PF0_DBG register */
> > +       val = ls_pcie_g4_pf_readl(pcie, PCIE_PF_DBG);
> > +       val |= 1 << PF_DBG_WE;
> > +       ls_pcie_g4_pf_writel(pcie, PCIE_PF_DBG, val);
> > +
> > +       val = ls_pcie_g4_pf_readl(pcie, PCIE_PF_DBG);
> > +       val |= 1 << PF_DBG_PABR;
> > +       ls_pcie_g4_pf_writel(pcie, PCIE_PF_DBG, val);
> > +
> > +       val = ls_pcie_g4_pf_readl(pcie, PCIE_PF_DBG);
> > +       val &= ~(1 << PF_DBG_WE);
> > +       ls_pcie_g4_pf_writel(pcie, PCIE_PF_DBG, val);
> > +
> > +       mobiveil_host_init(mv_pci, true);
> > +
> > +       to = 100;
> > +       while (!ls_pcie_g4_link_up(mv_pci) && to--)
> > +               usleep_range(200, 250);
> > +       if (to < 0)
> > +               dev_err(&mv_pci->pdev->dev, "PCIe link trainning
> > +timeout\n"); }
> > +
> > +static irqreturn_t ls_pcie_g4_handler(int irq, void *dev_id) {
> > +       struct ls_pcie_g4 *pcie = (struct ls_pcie_g4 *)dev_id;
> > +       struct mobiveil_pcie *mv_pci = pcie->pci;
> > +       u32 val;
> > +
> > +       val = csr_readl(mv_pci, PAB_INTP_AMBA_MISC_STAT);
> > +       if (!val)
> > +               return IRQ_NONE;
> > +
> > +       if (val & PAB_INTP_RESET)
> > +               schedule_delayed_work(&pcie->dwork,
> > + msecs_to_jiffies(1));
> > +
> > +       csr_writel(mv_pci, val, PAB_INTP_AMBA_MISC_STAT);
> > +
> > +       return IRQ_HANDLED;
> > +}
> > +
> > +static int ls_pcie_g4_interrupt_init(struct mobiveil_pcie *mv_pci) {
> > +       struct ls_pcie_g4 *pcie = to_ls_pcie_g4(mv_pci);
> > +       u32 val;
> > +       int ret;
> > +
> > +       pcie->irq = platform_get_irq_byname(mv_pci->pdev, "intr");
> > +       if (pcie->irq < 0) {
> > +               dev_err(&mv_pci->pdev->dev, "Can't get 'intr' irq.\n");
> > +               return pcie->irq;
> > +       }
> > +       ret = devm_request_irq(&mv_pci->pdev->dev, pcie->irq,
> > +                              ls_pcie_g4_handler, IRQF_SHARED,
> > +                              mv_pci->pdev->name, pcie);
> > +       if (ret) {
> > +               dev_err(&mv_pci->pdev->dev, "Can't register PCIe
> IRQ.\n");
> > +               return  ret;
> > +       }
> > +
> > +       /* Enable interrupts */
> > +       val = PAB_INTP_INTX_MASK | PAB_INTP_MSI | PAB_INTP_RESET
> |
> > +             PAB_INTP_PCIE_UE | PAB_INTP_IE_PMREDI |
> PAB_INTP_IE_EC;
> > +       csr_writel(mv_pci, val, PAB_INTP_AMBA_MISC_ENB);
> > +
> > +       return 0;
> > +}
> > +
> > +static void ls_pcie_g4_reset(struct work_struct *work) {
> > +       struct delayed_work *dwork = container_of(work, struct
> delayed_work,
> > +                                                 work);
> > +       struct ls_pcie_g4 *pcie = container_of(dwork, struct ls_pcie_g4,
> dwork);
> > +       struct mobiveil_pcie *mv_pci = pcie->pci;
> > +       u16 ctrl;
> > +
> > +       ctrl = csr_readw(mv_pci, PCI_BRIDGE_CONTROL);
> > +       ctrl &= ~PCI_BRIDGE_CTL_BUS_RESET;
> > +       csr_writew(mv_pci, ctrl, PCI_BRIDGE_CONTROL);
> > +       ls_pcie_g4_reinit_hw(pcie);
> > +}
> > +
> > +static struct mobiveil_rp_ops ls_pcie_g4_rp_ops = {
> > +       .interrupt_init = ls_pcie_g4_interrupt_init, };
> > +
> > +static const struct mobiveil_pab_ops ls_pcie_g4_pab_ops = {
> > +       .link_up = ls_pcie_g4_link_up, };
> > +
> > +static int __init ls_pcie_g4_probe(struct platform_device *pdev) {
> > +       struct device *dev = &pdev->dev;
> > +       struct mobiveil_pcie *mv_pci;
> > +       struct ls_pcie_g4 *pcie;
> > +       struct device_node *np = dev->of_node;
> > +       int ret;
> > +
> > +       if (!of_parse_phandle(np, "msi-parent", 0)) {
> > +               dev_err(dev, "failed to find msi-parent\n");
> > +               return -EINVAL;
> > +       }
> > +
> > +       pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL);
> > +       if (!pcie)
> > +               return -ENOMEM;
> > +
> > +       mv_pci = devm_kzalloc(dev, sizeof(*mv_pci), GFP_KERNEL);
> > +       if (!mv_pci)
> > +               return -ENOMEM;
> > +
> > +       mv_pci->pdev = pdev;
> > +       mv_pci->ops = &ls_pcie_g4_pab_ops;
> > +       mv_pci->rp.ops = &ls_pcie_g4_rp_ops;
> > +       pcie->pci = mv_pci;
> > +
> > +       platform_set_drvdata(pdev, pcie);
> > +
> > +       INIT_DELAYED_WORK(&pcie->dwork, ls_pcie_g4_reset);
> > +
> > +       ret = mobiveil_pcie_host_probe(mv_pci);
> > +       if (ret) {
> > +               dev_err(dev, "fail to probe!\n");
> > +               return  ret;
> > +       }
> > +
> > +       if (!ls_pcie_g4_is_bridge(pcie))
> > +               return -ENODEV;
> > +
> > +       return 0;
> > +}
> > +
> > +static const struct of_device_id ls_pcie_g4_of_match[] = {
> > +       { .compatible = "fsl,lx2160a-pcie", },
> > +       { },
> > +};
> > +
> > +static struct platform_driver ls_pcie_g4_driver = {
> > +       .driver = {
> > +               .name = "layerscape-pcie-gen4",
> > +               .of_match_table = ls_pcie_g4_of_match,
> > +               .suppress_bind_attrs = true,
> > +       },
> > +};
> > +
> > +builtin_platform_driver_probe(ls_pcie_g4_driver, ls_pcie_g4_probe);
> > diff --git a/drivers/pci/controller/mobiveil/pcie-mobiveil.h
> > b/drivers/pci/controller/mobiveil/pcie-mobiveil.h
> > index 0f5303962e88..0ccd6cee5f8f 100644
> > --- a/drivers/pci/controller/mobiveil/pcie-mobiveil.h
> > +++ b/drivers/pci/controller/mobiveil/pcie-mobiveil.h
> > @@ -41,6 +41,8 @@
> >  #define  PAGE_LO_MASK                  0x3ff
> >  #define  PAGE_SEL_OFFSET_SHIFT         10
> >
> > +#define PAB_ACTIVITY_STAT              0x81c
> > +
> >  #define PAB_AXI_PIO_CTRL               0x0840
> >  #define  APIO_EN_MASK                  0xf
> >
> > @@ -49,8 +51,18 @@
> >
> >  #define PAB_INTP_AMBA_MISC_ENB         0x0b0c
> >  #define PAB_INTP_AMBA_MISC_STAT                0x0b1c
> > -#define  PAB_INTP_INTX_MASK            0x01e0
> > -#define  PAB_INTP_MSI_MASK             0x8
> > +#define  PAB_INTP_RESET                        (0x1 << 1)
> > +#define  PAB_INTP_MSI                  (0x1 << 3)
> > +#define  PAB_INTP_INTA                 (0x1 << 5)
> > +#define  PAB_INTP_INTB                 (0x1 << 6)
> > +#define  PAB_INTP_INTC                 (0x1 << 7)
> > +#define  PAB_INTP_INTD                 (0x1 << 8)
> you could use BIT(x) macros instead of these shift operations

Ok, will change in next version.

> > +#define  PAB_INTP_PCIE_UE              (0x1 << 9)
> > +#define  PAB_INTP_IE_PMREDI            (0x1 << 29)
> > +#define  PAB_INTP_IE_EC                        (0x1 << 30)
> please fix and the the indentations

It is just a display issue in the email.

> > +#define  PAB_INTP_MSI_MASK             PAB_INTP_MSI
> > +#define  PAB_INTP_INTX_MASK            (PAB_INTP_INTA |
> PAB_INTP_INTB |\
> > +                                       PAB_INTP_INTC |
> PAB_INTP_INTD)
> >
> >  #define PAB_AXI_AMAP_CTRL(win)         PAB_REG_ADDR(0x0ba0,
> win)
> >  #define  WIN_ENABLE_SHIFT              0
> > --
> > 2.17.1
> >

Thanks,
Zhiqiang

WARNING: multiple messages have this Message-ID (diff)
From: "Z.q. Hou" <zhiqiang.hou@nxp.com>
To: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
	Xiaowei Bao <xiaowei.bao@nxp.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Leo Li <leoyang.li@nxp.com>, "M.h. Lian" <minghuan.lian@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	Mingkai Hu <mingkai.hu@nxp.com>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCHv3 23/27] PCI: mobiveil: add PCIe Gen4 RC driver for NXP Layerscape SoCs
Date: Mon, 18 Feb 2019 07:05:35 +0000	[thread overview]
Message-ID: <VI1PR04MB5792E6493E8372A73B60FDD784630@VI1PR04MB5792.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAFZiPx0aGTy6yQ=fCojjP1awLEHevPSHRCUDEFL7KJtA4t=CGw@mail.gmail.com>

Hi Subbu,

Thanks a lot for your comments!

> -----Original Message-----
> From: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>
> Sent: 2019年2月8日 20:50
> To: Z.q. Hou <zhiqiang.hou@nxp.com>
> Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> bhelgaas@google.com; robh+dt@kernel.org; mark.rutland@arm.com;
> shawnguo@kernel.org; Leo Li <leoyang.li@nxp.com>;
> lorenzo.pieralisi@arm.com; catalin.marinas@arm.com;
> will.deacon@arm.com; Mingkai Hu <mingkai.hu@nxp.com>; M.h. Lian
> <minghuan.lian@nxp.com>; Xiaowei Bao <xiaowei.bao@nxp.com>
> Subject: Re: [PATCHv3 23/27] PCI: mobiveil: add PCIe Gen4 RC driver for NXP
> Layerscape SoCs
> 
> ZQ,
> 
> 
> On Tue, Jan 29, 2019 at 1:40 PM Z.q. Hou <zhiqiang.hou@nxp.com> wrote:
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > This PCIe controller is based on the Mobiveil GPEX IP, which is
> > compatible with the PCI Express™ Base Specification, Revision 4.0.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>
> > ---
> > V3:
> >  - No change
> >
> >  drivers/pci/controller/mobiveil/Kconfig       |  10 +
> >  drivers/pci/controller/mobiveil/Makefile      |   1 +
> >  .../controller/mobiveil/pci-layerscape-gen4.c | 254 ++++++++++++++++++
> >  .../pci/controller/mobiveil/pcie-mobiveil.h   |  16 +-
> >  4 files changed, 279 insertions(+), 2 deletions(-)  create mode
> > 100644 drivers/pci/controller/mobiveil/pci-layerscape-gen4.c
> >
> > diff --git a/drivers/pci/controller/mobiveil/Kconfig
> > b/drivers/pci/controller/mobiveil/Kconfig
> > index 64343c07bfed..3ddb7d6163a9 100644
> > --- a/drivers/pci/controller/mobiveil/Kconfig
> > +++ b/drivers/pci/controller/mobiveil/Kconfig
> > @@ -21,4 +21,14 @@ config PCIE_MOBIVEIL_PLAT
> >           Soft IP. It has up to 8 outbound and inbound windows
> >           for address translation and it is a PCIe Gen4 IP.
> >
> > +config PCI_LAYERSCAPE_GEN4
> > +       bool "Freescale Layerscpe PCIe Gen4 controller"
> > +       depends on PCI
> > +       depends on OF && (ARM64 || ARCH_LAYERSCAPE)
> > +       depends on PCI_MSI_IRQ_DOMAIN
> > +       select PCIE_MOBIVEIL_HOST
> > +       help
> > +         Say Y here if you want PCIe Gen4 controller support on
> > +         Layerscape SoCs. The PCIe controller can work in RC or
> > +         EP mode according to RCW[HOST_AGT_PEX] setting.
> >  endmenu
> > diff --git a/drivers/pci/controller/mobiveil/Makefile
> > b/drivers/pci/controller/mobiveil/Makefile
> > index 9fb6d1c6504d..ff66774ccac4 100644
> > --- a/drivers/pci/controller/mobiveil/Makefile
> > +++ b/drivers/pci/controller/mobiveil/Makefile
> > @@ -2,3 +2,4 @@
> >  obj-$(CONFIG_PCIE_MOBIVEIL) += pcie-mobiveil.o
> >  obj-$(CONFIG_PCIE_MOBIVEIL_HOST) += pcie-mobiveil-host.o
> >  obj-$(CONFIG_PCIE_MOBIVEIL_PLAT) += pcie-mobiveil-plat.o
> > +obj-$(CONFIG_PCI_LAYERSCAPE_GEN4) += pci-layerscape-gen4.o
> > diff --git a/drivers/pci/controller/mobiveil/pci-layerscape-gen4.c
> > b/drivers/pci/controller/mobiveil/pci-layerscape-gen4.c
> > new file mode 100644
> > index 000000000000..174cbcac4059
> > --- /dev/null
> > +++ b/drivers/pci/controller/mobiveil/pci-layerscape-gen4.c
> > @@ -0,0 +1,254 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * PCIe host controller driver for NXP Layerscape SoCs
> > + *
> > + * Copyright 2018 NXP
> > + *
> > + * Author: Zhiqiang Hou <Zhiqiang.Hou@nxp.com>  */
> > +
> > +#include <linux/kernel.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/init.h>
> > +#include <linux/of_pci.h>
> > +#include <linux/of_platform.h>
> > +#include <linux/of_irq.h>
> > +#include <linux/of_address.h>
> > +#include <linux/pci.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/resource.h>
> > +#include <linux/mfd/syscon.h>
> > +#include <linux/regmap.h>
> > +
> > +#include "pcie-mobiveil.h"
> > +
> > +/* LUT and PF control registers */
> > +#define PCIE_LUT_OFF                   (0x80000)
> > +#define PCIE_PF_OFF                    (0xc0000)
> > +#define PCIE_PF_INT_STAT               (0x18)
> > +#define PF_INT_STAT_PABRST             (31)
> > +
> > +#define PCIE_PF_DBG                    (0x7fc)
> > +#define PF_DBG_LTSSM_MASK              (0x3f)
> > +#define PF_DBG_WE                      (31)
> > +#define PF_DBG_PABR                    (27)
> > +
> > +#define LS_PCIE_G4_LTSSM_L0            0x2d /* L0 state */
> > +
> > +#define to_ls_pcie_g4(x)
> platform_get_drvdata((x)->pdev)
> > +
> > +struct ls_pcie_g4 {
> > +       struct mobiveil_pcie *pci;
> > +       struct delayed_work dwork;
> > +       int irq;
> > +};
> > +
> > +static inline u32 ls_pcie_g4_lut_readl(struct ls_pcie_g4 *pcie, u32
> > +off) {
> > +       return ioread32(pcie->pci->csr_axi_slave_base + PCIE_LUT_OFF +
> > +off); }
> > +
> > +static inline void ls_pcie_g4_lut_writel(struct ls_pcie_g4 *pcie,
> > +                                        u32 off, u32 val) {
> > +       iowrite32(val, pcie->pci->csr_axi_slave_base + PCIE_LUT_OFF +
> > +off); }
> > +
> > +static inline u32 ls_pcie_g4_pf_readl(struct ls_pcie_g4 *pcie, u32
> > +off) {
> > +       return ioread32(pcie->pci->csr_axi_slave_base + PCIE_PF_OFF +
> > +off); }
> > +
> > +static inline void ls_pcie_g4_pf_writel(struct ls_pcie_g4 *pcie,
> > +                                       u32 off, u32 val) {
> > +       iowrite32(val, pcie->pci->csr_axi_slave_base + PCIE_PF_OFF +
> > +off); }
> > +
> > +static bool ls_pcie_g4_is_bridge(struct ls_pcie_g4 *pcie) {
> > +       struct mobiveil_pcie *mv_pci = pcie->pci;
> > +       u32 header_type;
> > +
> > +       header_type = csr_readb(mv_pci, PCI_HEADER_TYPE);
> > +       header_type &= 0x7f;
> > +
> > +       return header_type == PCI_HEADER_TYPE_BRIDGE; }
> > +
> > +static int ls_pcie_g4_link_up(struct mobiveil_pcie *pci) {
> > +       struct ls_pcie_g4 *pcie = to_ls_pcie_g4(pci);
> > +       u32 state;
> > +
> > +       state = ls_pcie_g4_pf_readl(pcie, PCIE_PF_DBG);
> > +       state = state & PF_DBG_LTSSM_MASK;
> > +
> > +       if (state == LS_PCIE_G4_LTSSM_L0)
> > +               return 1;
> > +
> > +       return 0;
> > +}
> > +
> > +static void ls_pcie_g4_reinit_hw(struct ls_pcie_g4 *pcie) {
> > +       struct mobiveil_pcie *mv_pci = pcie->pci;
> > +       u32 val, act_stat;
> > +       int to = 100;
> > +
> > +       /* Poll for pab_csb_reset to set and PAB activity to clear */
> > +       do {
> > +               usleep_range(10, 15);
> > +               val = ls_pcie_g4_pf_readl(pcie, PCIE_PF_INT_STAT);
> > +               act_stat = csr_readl(mv_pci, PAB_ACTIVITY_STAT);
> > +       } while (((val & 1 << PF_INT_STAT_PABRST) == 0 || act_stat) &&
> to--);
> > +       if (to < 0) {
> > +               dev_err(&mv_pci->pdev->dev, "poll PABRST&PABACT
> timeout\n");
> > +               return;
> > +       }
> > +
> > +       /* clear PEX_RESET bit in PEX_PF0_DBG register */
> > +       val = ls_pcie_g4_pf_readl(pcie, PCIE_PF_DBG);
> > +       val |= 1 << PF_DBG_WE;
> > +       ls_pcie_g4_pf_writel(pcie, PCIE_PF_DBG, val);
> > +
> > +       val = ls_pcie_g4_pf_readl(pcie, PCIE_PF_DBG);
> > +       val |= 1 << PF_DBG_PABR;
> > +       ls_pcie_g4_pf_writel(pcie, PCIE_PF_DBG, val);
> > +
> > +       val = ls_pcie_g4_pf_readl(pcie, PCIE_PF_DBG);
> > +       val &= ~(1 << PF_DBG_WE);
> > +       ls_pcie_g4_pf_writel(pcie, PCIE_PF_DBG, val);
> > +
> > +       mobiveil_host_init(mv_pci, true);
> > +
> > +       to = 100;
> > +       while (!ls_pcie_g4_link_up(mv_pci) && to--)
> > +               usleep_range(200, 250);
> > +       if (to < 0)
> > +               dev_err(&mv_pci->pdev->dev, "PCIe link trainning
> > +timeout\n"); }
> > +
> > +static irqreturn_t ls_pcie_g4_handler(int irq, void *dev_id) {
> > +       struct ls_pcie_g4 *pcie = (struct ls_pcie_g4 *)dev_id;
> > +       struct mobiveil_pcie *mv_pci = pcie->pci;
> > +       u32 val;
> > +
> > +       val = csr_readl(mv_pci, PAB_INTP_AMBA_MISC_STAT);
> > +       if (!val)
> > +               return IRQ_NONE;
> > +
> > +       if (val & PAB_INTP_RESET)
> > +               schedule_delayed_work(&pcie->dwork,
> > + msecs_to_jiffies(1));
> > +
> > +       csr_writel(mv_pci, val, PAB_INTP_AMBA_MISC_STAT);
> > +
> > +       return IRQ_HANDLED;
> > +}
> > +
> > +static int ls_pcie_g4_interrupt_init(struct mobiveil_pcie *mv_pci) {
> > +       struct ls_pcie_g4 *pcie = to_ls_pcie_g4(mv_pci);
> > +       u32 val;
> > +       int ret;
> > +
> > +       pcie->irq = platform_get_irq_byname(mv_pci->pdev, "intr");
> > +       if (pcie->irq < 0) {
> > +               dev_err(&mv_pci->pdev->dev, "Can't get 'intr' irq.\n");
> > +               return pcie->irq;
> > +       }
> > +       ret = devm_request_irq(&mv_pci->pdev->dev, pcie->irq,
> > +                              ls_pcie_g4_handler, IRQF_SHARED,
> > +                              mv_pci->pdev->name, pcie);
> > +       if (ret) {
> > +               dev_err(&mv_pci->pdev->dev, "Can't register PCIe
> IRQ.\n");
> > +               return  ret;
> > +       }
> > +
> > +       /* Enable interrupts */
> > +       val = PAB_INTP_INTX_MASK | PAB_INTP_MSI | PAB_INTP_RESET
> |
> > +             PAB_INTP_PCIE_UE | PAB_INTP_IE_PMREDI |
> PAB_INTP_IE_EC;
> > +       csr_writel(mv_pci, val, PAB_INTP_AMBA_MISC_ENB);
> > +
> > +       return 0;
> > +}
> > +
> > +static void ls_pcie_g4_reset(struct work_struct *work) {
> > +       struct delayed_work *dwork = container_of(work, struct
> delayed_work,
> > +                                                 work);
> > +       struct ls_pcie_g4 *pcie = container_of(dwork, struct ls_pcie_g4,
> dwork);
> > +       struct mobiveil_pcie *mv_pci = pcie->pci;
> > +       u16 ctrl;
> > +
> > +       ctrl = csr_readw(mv_pci, PCI_BRIDGE_CONTROL);
> > +       ctrl &= ~PCI_BRIDGE_CTL_BUS_RESET;
> > +       csr_writew(mv_pci, ctrl, PCI_BRIDGE_CONTROL);
> > +       ls_pcie_g4_reinit_hw(pcie);
> > +}
> > +
> > +static struct mobiveil_rp_ops ls_pcie_g4_rp_ops = {
> > +       .interrupt_init = ls_pcie_g4_interrupt_init, };
> > +
> > +static const struct mobiveil_pab_ops ls_pcie_g4_pab_ops = {
> > +       .link_up = ls_pcie_g4_link_up, };
> > +
> > +static int __init ls_pcie_g4_probe(struct platform_device *pdev) {
> > +       struct device *dev = &pdev->dev;
> > +       struct mobiveil_pcie *mv_pci;
> > +       struct ls_pcie_g4 *pcie;
> > +       struct device_node *np = dev->of_node;
> > +       int ret;
> > +
> > +       if (!of_parse_phandle(np, "msi-parent", 0)) {
> > +               dev_err(dev, "failed to find msi-parent\n");
> > +               return -EINVAL;
> > +       }
> > +
> > +       pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL);
> > +       if (!pcie)
> > +               return -ENOMEM;
> > +
> > +       mv_pci = devm_kzalloc(dev, sizeof(*mv_pci), GFP_KERNEL);
> > +       if (!mv_pci)
> > +               return -ENOMEM;
> > +
> > +       mv_pci->pdev = pdev;
> > +       mv_pci->ops = &ls_pcie_g4_pab_ops;
> > +       mv_pci->rp.ops = &ls_pcie_g4_rp_ops;
> > +       pcie->pci = mv_pci;
> > +
> > +       platform_set_drvdata(pdev, pcie);
> > +
> > +       INIT_DELAYED_WORK(&pcie->dwork, ls_pcie_g4_reset);
> > +
> > +       ret = mobiveil_pcie_host_probe(mv_pci);
> > +       if (ret) {
> > +               dev_err(dev, "fail to probe!\n");
> > +               return  ret;
> > +       }
> > +
> > +       if (!ls_pcie_g4_is_bridge(pcie))
> > +               return -ENODEV;
> > +
> > +       return 0;
> > +}
> > +
> > +static const struct of_device_id ls_pcie_g4_of_match[] = {
> > +       { .compatible = "fsl,lx2160a-pcie", },
> > +       { },
> > +};
> > +
> > +static struct platform_driver ls_pcie_g4_driver = {
> > +       .driver = {
> > +               .name = "layerscape-pcie-gen4",
> > +               .of_match_table = ls_pcie_g4_of_match,
> > +               .suppress_bind_attrs = true,
> > +       },
> > +};
> > +
> > +builtin_platform_driver_probe(ls_pcie_g4_driver, ls_pcie_g4_probe);
> > diff --git a/drivers/pci/controller/mobiveil/pcie-mobiveil.h
> > b/drivers/pci/controller/mobiveil/pcie-mobiveil.h
> > index 0f5303962e88..0ccd6cee5f8f 100644
> > --- a/drivers/pci/controller/mobiveil/pcie-mobiveil.h
> > +++ b/drivers/pci/controller/mobiveil/pcie-mobiveil.h
> > @@ -41,6 +41,8 @@
> >  #define  PAGE_LO_MASK                  0x3ff
> >  #define  PAGE_SEL_OFFSET_SHIFT         10
> >
> > +#define PAB_ACTIVITY_STAT              0x81c
> > +
> >  #define PAB_AXI_PIO_CTRL               0x0840
> >  #define  APIO_EN_MASK                  0xf
> >
> > @@ -49,8 +51,18 @@
> >
> >  #define PAB_INTP_AMBA_MISC_ENB         0x0b0c
> >  #define PAB_INTP_AMBA_MISC_STAT                0x0b1c
> > -#define  PAB_INTP_INTX_MASK            0x01e0
> > -#define  PAB_INTP_MSI_MASK             0x8
> > +#define  PAB_INTP_RESET                        (0x1 << 1)
> > +#define  PAB_INTP_MSI                  (0x1 << 3)
> > +#define  PAB_INTP_INTA                 (0x1 << 5)
> > +#define  PAB_INTP_INTB                 (0x1 << 6)
> > +#define  PAB_INTP_INTC                 (0x1 << 7)
> > +#define  PAB_INTP_INTD                 (0x1 << 8)
> you could use BIT(x) macros instead of these shift operations

Ok, will change in next version.

> > +#define  PAB_INTP_PCIE_UE              (0x1 << 9)
> > +#define  PAB_INTP_IE_PMREDI            (0x1 << 29)
> > +#define  PAB_INTP_IE_EC                        (0x1 << 30)
> please fix and the the indentations

It is just a display issue in the email.

> > +#define  PAB_INTP_MSI_MASK             PAB_INTP_MSI
> > +#define  PAB_INTP_INTX_MASK            (PAB_INTP_INTA |
> PAB_INTP_INTB |\
> > +                                       PAB_INTP_INTC |
> PAB_INTP_INTD)
> >
> >  #define PAB_AXI_AMAP_CTRL(win)         PAB_REG_ADDR(0x0ba0,
> win)
> >  #define  WIN_ENABLE_SHIFT              0
> > --
> > 2.17.1
> >

Thanks,
Zhiqiang
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-02-18  7:05 UTC|newest]

Thread overview: 203+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29  8:08 [PATCHv3 00/27] PCI: refactor Mobiveil driver and add PCIe Gen4 driver for NXP Layerscape SoCs Z.q. Hou
2019-01-29  8:08 ` Z.q. Hou
2019-01-29  8:08 ` Z.q. Hou
2019-01-29  8:08 ` [PATCHv3 01/27] PCI: mobiveil: uniform the register accessors Z.q. Hou
2019-01-29  8:08   ` Z.q. Hou
2019-01-29  8:08   ` Z.q. Hou
2019-02-05  5:39   ` Subrahmanya Lingappa
2019-02-05  5:39     ` Subrahmanya Lingappa
2019-02-05  5:39     ` Subrahmanya Lingappa
2019-02-05 17:43     ` Lorenzo Pieralisi
2019-02-05 17:43       ` Lorenzo Pieralisi
2019-02-05 17:43       ` Lorenzo Pieralisi
2019-02-06 10:59       ` Subrahmanya Lingappa
2019-02-06 10:59         ` Subrahmanya Lingappa
2019-02-06 10:59         ` Subrahmanya Lingappa
2019-01-29  8:08 ` [PATCHv3 02/27] PCI: mobiveil: format the code without function change Z.q. Hou
2019-01-29  8:08   ` Z.q. Hou
2019-01-29  8:08   ` Z.q. Hou
2019-02-05  5:48   ` Subrahmanya Lingappa
2019-02-05  5:48     ` Subrahmanya Lingappa
2019-02-05  5:48     ` Subrahmanya Lingappa
2019-02-18  7:03     ` Z.q. Hou
2019-02-18  7:03       ` Z.q. Hou
2019-01-29  8:08 ` [PATCHv3 03/27] PCI: mobiveil: correct the returned error number Z.q. Hou
2019-01-29  8:08   ` Z.q. Hou
2019-01-29  8:08   ` Z.q. Hou
2019-02-05  5:53   ` Subrahmanya Lingappa
2019-02-05  5:53     ` Subrahmanya Lingappa
2019-02-05  5:53     ` Subrahmanya Lingappa
2019-01-29  8:08 ` [PATCHv3 04/27] PCI: mobiveil: remove flag MSI_FLAG_MULTI_PCI_MSI Z.q. Hou
2019-01-29  8:08   ` Z.q. Hou
2019-01-29  8:08   ` Z.q. Hou
2019-02-05  6:05   ` Subrahmanya Lingappa
2019-02-05  6:05     ` Subrahmanya Lingappa
2019-02-05  6:05     ` Subrahmanya Lingappa
2019-02-18  7:03     ` Z.q. Hou
2019-02-18  7:03       ` Z.q. Hou
2019-02-18  7:03       ` Z.q. Hou
2019-01-29  8:09 ` [PATCHv3 05/27] PCI: mobiveil: correct PCI base address in MEM/IO outbound windows Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-02-05  6:06   ` Subrahmanya Lingappa
2019-02-05  6:06     ` Subrahmanya Lingappa
2019-02-05  6:06     ` Subrahmanya Lingappa
2019-01-29  8:09 ` [PATCHv3 06/27] PCI: mobiveil: replace the resource list iteration function Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-02-05  6:07   ` Subrahmanya Lingappa
2019-02-05  6:07     ` Subrahmanya Lingappa
2019-02-05  6:07     ` Subrahmanya Lingappa
2019-01-29  8:09 ` [PATCHv3 07/27] PCI: mobiveil: use WIN_NUM_0 explicitly for CFG outbound window Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-02-05  6:08   ` Subrahmanya Lingappa
2019-02-05  6:08     ` Subrahmanya Lingappa
2019-02-05  6:08     ` Subrahmanya Lingappa
2019-01-29  8:09 ` [PATCHv3 08/27] PCI: mobiveil: use the 1st inbound window for MEM inbound transactions Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-02-05  6:08   ` Subrahmanya Lingappa
2019-02-05  6:08     ` Subrahmanya Lingappa
2019-02-05  6:08     ` Subrahmanya Lingappa
2019-01-29  8:09 ` [PATCHv3 09/27] PCI: mobiveil: correct inbound/outbound window setup routines Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-02-05  6:10   ` Subrahmanya Lingappa
2019-02-05  6:10     ` Subrahmanya Lingappa
2019-02-05  6:10     ` Subrahmanya Lingappa
2019-02-18  7:07     ` Z.q. Hou
2019-02-18  7:07       ` Z.q. Hou
2019-01-29  8:09 ` [PATCHv3 10/27] PCI: mobiveil: fix the INTx process error Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-02-05  6:11   ` Subrahmanya Lingappa
2019-02-05  6:11     ` Subrahmanya Lingappa
2019-02-05  6:11     ` Subrahmanya Lingappa
2019-01-29  8:09 ` [PATCHv3 11/27] PCI: mobiveil: only fix up the Class Code field Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-02-05  6:11   ` Subrahmanya Lingappa
2019-02-05  6:11     ` Subrahmanya Lingappa
2019-02-05  6:11     ` Subrahmanya Lingappa
2019-01-29  8:09 ` [PATCHv3 12/27] PCI: mobiveil: move out the link up waiting from mobiveil_host_init Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-02-05  6:12   ` Subrahmanya Lingappa
2019-02-05  6:12     ` Subrahmanya Lingappa
2019-02-05  6:12     ` Subrahmanya Lingappa
2019-01-29  8:09 ` [PATCHv3 13/27] PCI: mobiveil: move irq chained handler setup out of DT parse Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-02-08 12:30   ` Subrahmanya Lingappa
2019-02-08 12:30     ` Subrahmanya Lingappa
2019-02-08 12:30     ` Subrahmanya Lingappa
2019-01-29  8:09 ` [PATCHv3 14/27] PCI: mobiveil: initialize Primary/Secondary/Subordinate bus number Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-01-29  8:09   ` Z.q. Hou
2019-02-08 12:31   ` Subrahmanya Lingappa
2019-02-08 12:31     ` Subrahmanya Lingappa
2019-02-08 12:31     ` Subrahmanya Lingappa
2019-01-29  8:10 ` [PATCHv3 15/27] dt-bindings: pci: mobiveil: change gpio_slave and apb_csr to optional Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-02-08 12:32   ` Subrahmanya Lingappa
2019-02-08 12:32     ` Subrahmanya Lingappa
2019-02-08 12:32     ` Subrahmanya Lingappa
2019-01-29  8:10 ` [PATCHv3 16/27] PCI: mobiveil: refactor Mobiveil PCIe Host Bridge IP driver Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-02-08 12:37   ` Subrahmanya Lingappa
2019-02-08 12:37     ` Subrahmanya Lingappa
2019-02-08 12:37     ` Subrahmanya Lingappa
2019-01-29  8:10 ` [PATCHv3 17/27] PCI: mobiveil: fix the checking of valid device Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-02-08 12:41   ` Subrahmanya Lingappa
2019-02-08 12:41     ` Subrahmanya Lingappa
2019-02-08 12:41     ` Subrahmanya Lingappa
2019-02-08 14:13     ` Bjorn Helgaas
2019-02-08 14:13       ` Bjorn Helgaas
2019-02-08 14:13       ` Bjorn Helgaas
2019-02-18  7:15       ` Z.q. Hou
2019-02-18  7:15         ` Z.q. Hou
2019-02-18  7:15         ` Z.q. Hou
2019-02-18  7:04     ` Z.q. Hou
2019-02-18  7:04       ` Z.q. Hou
2019-02-18  7:04       ` Z.q. Hou
2019-01-29  8:10 ` [PATCHv3 18/27] PCI: mobiveil: continue to initialize the host upon no PCIe link Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-02-08 12:41   ` Subrahmanya Lingappa
2019-02-08 12:41     ` Subrahmanya Lingappa
2019-02-08 12:41     ` Subrahmanya Lingappa
2019-01-29  8:10 ` [PATCHv3 19/27] PCI: mobiveil: disabled IB and OB windows set by bootloader Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-02-08 12:42   ` Subrahmanya Lingappa
2019-02-08 12:42     ` Subrahmanya Lingappa
2019-02-08 12:42     ` Subrahmanya Lingappa
2019-01-29  8:10 ` [PATCHv3 20/27] PCI: mobiveil: add Byte and Half-Word width register accessors Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-02-08 12:44   ` Subrahmanya Lingappa
2019-02-08 12:44     ` Subrahmanya Lingappa
2019-02-08 12:44     ` Subrahmanya Lingappa
2019-01-29  8:10 ` [PATCHv3 21/27] PCI: mobiveil: make mobiveil_host_init can be used to re-init host Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-02-08 12:46   ` Subrahmanya Lingappa
2019-02-08 12:46     ` Subrahmanya Lingappa
2019-02-08 12:46     ` Subrahmanya Lingappa
2019-01-29  8:10 ` [PATCHv3 22/27] dt-bindings: pci: Add NXP Layerscape SoCs PCIe Gen4 controller Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-01-30 18:49   ` Rob Herring
2019-01-30 18:49     ` Rob Herring
2019-01-30 18:49     ` Rob Herring
2019-01-29  8:10 ` [PATCHv3 23/27] PCI: mobiveil: add PCIe Gen4 RC driver for NXP Layerscape SoCs Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-01-29  8:10   ` Z.q. Hou
2019-02-08 12:49   ` Subrahmanya Lingappa
2019-02-08 12:49     ` Subrahmanya Lingappa
2019-02-08 12:49     ` Subrahmanya Lingappa
2019-02-18  7:05     ` Z.q. Hou [this message]
2019-02-18  7:05       ` Z.q. Hou
2019-02-18  7:05       ` Z.q. Hou
2019-01-29  8:11 ` [PATCHv3 24/27] PCI: mobiveil: ls_pcie_g4: add Workaround for A-011577 Z.q. Hou
2019-01-29  8:11   ` Z.q. Hou
2019-01-29  8:11   ` Z.q. Hou
2019-02-08 12:52   ` Subrahmanya Lingappa
2019-02-08 12:52     ` Subrahmanya Lingappa
2019-02-08 12:52     ` Subrahmanya Lingappa
2019-02-18  7:10     ` Z.q. Hou
2019-02-18  7:10       ` Z.q. Hou
2019-02-18  7:10       ` Z.q. Hou
2019-01-29  8:11 ` [PATCHv3 25/27] PCI: mobiveil: ls_pcie_g4: add Workaround for A-011451 Z.q. Hou
2019-01-29  8:11   ` Z.q. Hou
2019-01-29  8:11   ` Z.q. Hou
2019-02-08 12:53   ` Subrahmanya Lingappa
2019-02-08 12:53     ` Subrahmanya Lingappa
2019-02-08 12:53     ` Subrahmanya Lingappa
2019-02-18  7:14     ` Z.q. Hou
2019-02-18  7:14       ` Z.q. Hou
2019-02-18  7:14       ` Z.q. Hou
2019-01-29  8:11 ` [PATCHv3 26/27] arm64: dts: freescale: lx2160a: add pcie DT nodes Z.q. Hou
2019-01-29  8:11   ` Z.q. Hou
2019-01-29  8:11   ` Z.q. Hou
2019-01-29  8:11 ` [PATCHv3 27/27] arm64: defconfig: Enable CONFIG_PCI_LAYERSCAPE_GEN4 Z.q. Hou
2019-01-29  8:11   ` Z.q. Hou
2019-01-29  8:11   ` Z.q. Hou
2019-01-29 11:39 ` [PATCHv3 00/27] PCI: refactor Mobiveil driver and add PCIe Gen4 driver for NXP Layerscape SoCs Lorenzo Pieralisi
2019-01-29 11:39   ` Lorenzo Pieralisi
2019-01-29 11:39   ` Lorenzo Pieralisi
2019-02-04 14:14   ` Subrahmanya Lingappa
2019-02-04 16:13     ` Lorenzo Pieralisi
2019-02-04 16:13       ` Lorenzo Pieralisi
2019-02-04 16:13       ` Lorenzo Pieralisi
2019-02-04 16:51       ` Subrahmanya Lingappa
2019-02-04 16:51         ` Subrahmanya Lingappa
2019-02-04 16:51         ` Subrahmanya Lingappa
2019-01-30 15:34 ` Bjorn Helgaas
2019-01-30 15:34   ` Bjorn Helgaas
2019-01-30 15:34   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB5792E6493E8372A73B60FDD784630@VI1PR04MB5792.eurprd04.prod.outlook.com \
    --to=zhiqiang.hou@nxp.com \
    --cc=bhelgaas@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=l.subrahmanya@mobiveil.co.in \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=minghuan.lian@nxp.com \
    --cc=mingkai.hu@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=will.deacon@arm.com \
    --cc=xiaowei.bao@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.