From: Leonard Crestez <leonard.crestez@nxp.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: "sboyd@kernel.org" <sboyd@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
Abel Vesa <abel.vesa@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Anson Huang <anson.huang@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>
Subject: Re: [PATCH V4 0/4] clk: imx: imx8m: introduce imx8m_clk_hw_composite_core
Date: Tue, 28 Jan 2020 14:47:59 +0000 [thread overview]
Message-ID: <VI1PR04MB7023201D8DF545198F1B6CB6EE0A0@VI1PR04MB7023.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 1580189015-5744-1-git-send-email-peng.fan@nxp.com
On 28.01.2020 07:28, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
> V4:
> Per Leonard's comments, added new definitions and _SRC/CG/DIV are
> alias to the new definition.
> Did boot test on i.MX8MQ/M/N-EVK
>
> V3:
> Add CLK_SET_RATE_NO_REPARENT and CLK_OPS_PARENT_ENABLE for core
> Avoid break DT for i.MX8MQ
>
> V2:
> Rename imx8m_clk_hw_core_composite to imx8m_clk_hw_composite_core
> Add Abel's tag
>
> To i.MX8M family, there are different types of clock slices,
> bus/core/ip and etc. Currently, the imx8m_clk_hw_composite
> api could only handle bus and ip clock slice, it could
> not handle core slice. The difference is core slice not have
> pre divider and the width of post divider is 3 bits.
>
> To simplify code and reuse imx8m_clk_hw_composite, introduce a
> flag IMX_COMPOSITE_CORE to differentiate the slices.
>
> With this new helper, we could simplify i.MX8M SoC clk drivers.
>
>
> Peng Fan (4):
> clk: imx: composite-8m: add imx8m_clk_hw_composite_core
> clk: imx: imx8mq: use imx8m_clk_hw_composite_core
> clk: imx: imx8mm: use imx8m_clk_hw_composite_core
> clk: imx: imx8mn: use imx8m_clk_hw_composite_core
>
> drivers/clk/imx/clk-composite-8m.c | 18 ++++++++++++----
> drivers/clk/imx/clk-imx8mm.c | 35 +++++++++++++++++++-------------
> drivers/clk/imx/clk-imx8mn.c | 19 +++++++++--------
> drivers/clk/imx/clk-imx8mq.c | 34 +++++++++++++++++--------------
> drivers/clk/imx/clk.h | 13 ++++++++++--
> include/dt-bindings/clock/imx8mm-clock.h | 7 ++++++-
> include/dt-bindings/clock/imx8mn-clock.h | 5 ++++-
> include/dt-bindings/clock/imx8mq-clock.h | 7 ++++++-
> 8 files changed, 92 insertions(+), 46 deletions(-)
>
WARNING: multiple messages have this Message-ID (diff)
From: Leonard Crestez <leonard.crestez@nxp.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
Abel Vesa <abel.vesa@nxp.com>, Anson Huang <anson.huang@nxp.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Jacky Bai <ping.bai@nxp.com>
Subject: Re: [PATCH V4 0/4] clk: imx: imx8m: introduce imx8m_clk_hw_composite_core
Date: Tue, 28 Jan 2020 14:47:59 +0000 [thread overview]
Message-ID: <VI1PR04MB7023201D8DF545198F1B6CB6EE0A0@VI1PR04MB7023.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 1580189015-5744-1-git-send-email-peng.fan@nxp.com
On 28.01.2020 07:28, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
> V4:
> Per Leonard's comments, added new definitions and _SRC/CG/DIV are
> alias to the new definition.
> Did boot test on i.MX8MQ/M/N-EVK
>
> V3:
> Add CLK_SET_RATE_NO_REPARENT and CLK_OPS_PARENT_ENABLE for core
> Avoid break DT for i.MX8MQ
>
> V2:
> Rename imx8m_clk_hw_core_composite to imx8m_clk_hw_composite_core
> Add Abel's tag
>
> To i.MX8M family, there are different types of clock slices,
> bus/core/ip and etc. Currently, the imx8m_clk_hw_composite
> api could only handle bus and ip clock slice, it could
> not handle core slice. The difference is core slice not have
> pre divider and the width of post divider is 3 bits.
>
> To simplify code and reuse imx8m_clk_hw_composite, introduce a
> flag IMX_COMPOSITE_CORE to differentiate the slices.
>
> With this new helper, we could simplify i.MX8M SoC clk drivers.
>
>
> Peng Fan (4):
> clk: imx: composite-8m: add imx8m_clk_hw_composite_core
> clk: imx: imx8mq: use imx8m_clk_hw_composite_core
> clk: imx: imx8mm: use imx8m_clk_hw_composite_core
> clk: imx: imx8mn: use imx8m_clk_hw_composite_core
>
> drivers/clk/imx/clk-composite-8m.c | 18 ++++++++++++----
> drivers/clk/imx/clk-imx8mm.c | 35 +++++++++++++++++++-------------
> drivers/clk/imx/clk-imx8mn.c | 19 +++++++++--------
> drivers/clk/imx/clk-imx8mq.c | 34 +++++++++++++++++--------------
> drivers/clk/imx/clk.h | 13 ++++++++++--
> include/dt-bindings/clock/imx8mm-clock.h | 7 ++++++-
> include/dt-bindings/clock/imx8mn-clock.h | 5 ++++-
> include/dt-bindings/clock/imx8mq-clock.h | 7 ++++++-
> 8 files changed, 92 insertions(+), 46 deletions(-)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-28 14:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 5:28 [PATCH V4 0/4] clk: imx: imx8m: introduce imx8m_clk_hw_composite_core Peng Fan
2020-01-28 5:28 ` Peng Fan
2020-01-28 5:28 ` [PATCH V4 1/4] clk: imx: composite-8m: add imx8m_clk_hw_composite_core Peng Fan
2020-01-28 5:28 ` Peng Fan
2020-01-28 5:28 ` [PATCH V4 2/4] clk: imx: imx8mq: use imx8m_clk_hw_composite_core Peng Fan
2020-01-28 5:28 ` Peng Fan
2020-01-28 5:28 ` [PATCH V4 3/4] clk: imx: imx8mm: " Peng Fan
2020-01-28 5:28 ` Peng Fan
2020-01-28 5:28 ` [PATCH V4 4/4] clk: imx: imx8mn: " Peng Fan
2020-01-28 5:28 ` Peng Fan
2020-01-28 14:47 ` Leonard Crestez [this message]
2020-01-28 14:47 ` [PATCH V4 0/4] clk: imx: imx8m: introduce imx8m_clk_hw_composite_core Leonard Crestez
2020-02-14 2:50 ` Shawn Guo
2020-02-14 2:50 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB7023201D8DF545198F1B6CB6EE0A0@VI1PR04MB7023.eurprd04.prod.outlook.com \
--to=leonard.crestez@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.