RE: [PATCH v1 4/5] xprtrdma: Reduce required number of send SGEs

From: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux NFS Mailing List
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: [PATCH v1 4/5] xprtrdma: Reduce required number of send SGEs
Date: Fri, 13 Jan 2017 19:14:00 +0000	[thread overview]
Message-ID: <VI1PR0502MB3008A3DFC7CDD1573721596FD1780@VI1PR0502MB3008.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <706404D7-A179-4E54-A2C7-534FCC1B5745-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 795 bytes --]

> >> +	ia->ri_max_sgeno = max_sge - 3;
> >>
> >
> > I didn't noticed this new ri_max_sgeno variable being used in this patch set.
> Did I miss?
> 
> Yes, you snipped out the other hunk where it is used.

Right. I see it now.
> 
> > You also might want to rename it to ri_max_sge_num.
> > Regardless for some device with 3 SGEs, ri_max_sgeno will become zero. Is
> that fine?
> 
> Yes, that's OK, and tested. Zero means that NFS WRITE and SYMLINK
> payloads will always be sent in a Read chunk.
> 
Ok. Thanks.

> 
> > It would be good to have define for this minimum required 3 SGEs header
> file such as RPCRDMA_MIN_REQ_RECV_SGE.
> 
> OK.
N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±û"žØ^n‡r¡ö¦zË\x1aëh™¨èÚ&¢îý»\x05ËÛÔØï¦v¬Îf\x1dp)¹¹br	šê+€Ê+zf£¢·hšˆ§~††Ûiÿûàz¹\x1e®w¥¢¸?™¨èÚ&¢)ß¢^[f