From: Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>
To: Thomas Zimmermann <tzimmermann-l3A5Bk7waGM@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Rong Chen <rong.a.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
airlied-cv59FeDIM0c@public.gmane.org,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
daniel-/w4YWyX8dFk@public.gmane.org,
rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
Sam Ravnborg <sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org>
Subject: Re: [kbuild-all] Re: [PATCH v3 8/8] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev
Date: Fri, 8 Jan 2021 10:02:27 +0100 [thread overview]
Message-ID: <X/gfo5k0efFhxP/I@phenom.ffwll.local> (raw)
In-Reply-To: <5ea2a270-2664-fad4-0048-ef498137e985-l3A5Bk7waGM@public.gmane.org>
On Fri, Jan 08, 2021 at 09:04:44AM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 08.01.21 um 02:25 schrieb Rong Chen:
> > Hi Thomas,
> >
> > Thanks for the feedback, do you mean the patch was applied to a wrong base?
>
> I'm on drm-tip, which already has the patches that fix these issues. I think
> I should start using git's --base option when sending out patchsets.
From today all the patches should also be in linux-next. Our maintainer
script didn't push the branches to the right tags because drm-misc-fixes
wasn't rolled forward yet (there's some trickery to make sure we don't
push patches to linux-next for the subsequent merge window before -rc1 is
tagged).
-Daniel
>
> Best regards
> Thomas
>
> >
> > Best Regards,
> > Rong Chen
> >
> > On 1/7/21 6:45 PM, Thomas Zimmermann wrote:
> > > AFAICT these are false positives. The instances have been fixed already.
> > >
> > > Am 07.01.21 um 10:45 schrieb kernel test robot:
> > > > Hi Thomas,
> > > >
> > > > I love your patch! Yet something to improve:
> > > >
> > > > [auto build test ERROR on drm-tip/drm-tip]
> > > > [cannot apply to drm-intel/for-linux-next linus/master v5.11-rc2
> > > > next-20210104]
> > > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > > And when submitting patch, we suggest to use '--base' as documented in
> > > > https://git-scm.com/docs/git-format-patch]
> > > >
> > > > url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Move-struct-drm_device-pdev-to-legacy/20210107-161007
> > > >
> > > > base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
> > > > config: x86_64-randconfig-s021-20210107 (attached as .config)
> > > > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > > > reproduce:
> > > > # apt-get install sparse
> > > > # sparse version: v0.6.3-208-g46a52ca4-dirty
> > > > # https://github.com/0day-ci/linux/commit/380912f7b62c23322562c40e19efd7ad84d57e9c
> > > >
> > > > git remote add linux-review https://github.com/0day-ci/linux
> > > > git fetch --no-tags linux-review Thomas-Zimmermann/drm-Move-struct-drm_device-pdev-to-legacy/20210107-161007
> > > >
> > > > git checkout 380912f7b62c23322562c40e19efd7ad84d57e9c
> > > > # save the attached .config to linux build tree
> > > > make W=1 C=1 CF='-fdiagnostic-prefix
> > > > -D__CHECK_ENDIAN__' ARCH=x86_64
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > > drivers/gpu/drm/gma500/oaktrail_device.c: In function
> > > > 'oaktrail_chip_setup':
> > > > > > drivers/gpu/drm/gma500/oaktrail_device.c:509:26: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 509 | if (pci_enable_msi(dev->pdev))
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/gma500/oaktrail_lvds.c: In function
> > > > 'oaktrail_lvds_set_power':
> > > > > > drivers/gpu/drm/gma500/oaktrail_lvds.c:63:25: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 63 | pm_request_idle(&dev->pdev->dev);
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function 'get_clock':
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:69:11: warning:
> > > > variable 'tmp' set but not used [-Wunused-but-set-variable]
> > > > 69 | u32 val, tmp;
> > > > | ^~~
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function 'get_data':
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:83:11: warning:
> > > > variable 'tmp' set but not used [-Wunused-but-set-variable]
> > > > 83 | u32 val, tmp;
> > > > | ^~~
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function
> > > > 'oaktrail_lvds_i2c_init':
> > > > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:148:35:
> > > > > > error: 'struct drm_device' has no member named 'pdev';
> > > > > > did you mean 'dev'?
> > > > 148 | chan->adapter.dev.parent = &dev->pdev->dev;
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function 'vmw_driver_load':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:661:22: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 661 | pci_set_master(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > In file included from drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:31:
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:690:47: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 690 | dev_priv->io_start = pci_resource_start(dev->pdev, 0);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:691:49: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 691 | dev_priv->vram_start = pci_resource_start(dev->pdev, 1);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:692:49: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 692 | dev_priv->mmio_start = pci_resource_start(dev->pdev, 2);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:842:33: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 842 | ret = pci_request_regions(dev->pdev, "vmwgfx probe");
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:851:33: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 851 | ret = pci_request_region(dev->pdev, 2, "vmwgfx
> > > > stealth probe");
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:859:35: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 859 | ret = vmw_irq_install(dev, dev->pdev->irq);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1005:27: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1005 | pci_release_region(dev->pdev, 2);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1007:28: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1007 | pci_release_regions(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function
> > > > 'vmw_driver_unload':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1056:27: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1056 | pci_release_region(dev->pdev, 2);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1058:28: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1058 | pci_release_regions(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function 'vmw_probe':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1522:7: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1522 | dev->pdev = pdev;
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:641:42: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 641 | struct device *device = &vmw_priv->dev->pdev->dev;
> > > > | ^~~~
> > > > | dev
> > > > In file included from drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:35:
> > > > At top level:
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning:
> > > > 'vmw_cursor_plane_formats' defined but not used
> > > > [-Wunused-const-variable=]
> > > > 256 | static const uint32_t vmw_cursor_plane_formats[] = {
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning:
> > > > 'vmw_primary_plane_formats' defined but not used
> > > > [-Wunused-const-variable=]
> > > > 248 | static const uint32_t vmw_primary_plane_formats[] = {
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_set_pool_size':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1233:48: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 1233 | man->map =
> > > > dma_alloc_coherent(&dev_priv->dev->pdev->dev, size,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_man_create':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1316:28: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1316 | &dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1325:22: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1325 | &dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_remove_pool':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1390:42: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1390 | dma_free_coherent(&man->dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > >
> > > >
> > > > vim +509 drivers/gpu/drm/gma500/oaktrail_device.c
> > > >
> > > > 1b082ccf5901108 Alan Cox 2011-11-03 503
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 504 static int
> > > > oaktrail_chip_setup(struct drm_device *dev)
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 505 {
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 506 struct
> > > > drm_psb_private *dev_priv = dev->dev_private;
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 507 int ret;
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 508
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 @509 if
> > > > (pci_enable_msi(dev->pdev))
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 510
> > > > dev_warn(dev->dev, "Enabling MSI failed!\n");
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 511
> > > > 8512e0748729a49 Alan Cox 2012-05-11 512
> > > > dev_priv->regmap = oaktrail_regmap;
> > > > 8512e0748729a49 Alan Cox 2012-05-11 513
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 514 ret =
> > > > mid_chip_setup(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 515 if (ret < 0)
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 516 return ret;
> > > > 4086b1e2b19729e Kirill A. Shutemov 2012-05-03 517 if
> > > > (!dev_priv->has_gct) {
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 518 /*
> > > > Now pull the BIOS data */
> > > > d839ede47a56ff5 Alan Cox 2012-05-03 519
> > > > psb_intel_opregion_init(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 520
> > > > psb_intel_init_bios(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 521 }
> > > > 6528c897966c7d5 Patrik Jakobsson 2013-11-07 522
> > > > gma_intel_setup_gmbus(dev);
> > > > 5f503148efdda26 Alan Cox 2012-05-03 523
> > > > oaktrail_hdmi_setup(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 524 return 0;
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 525 }
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 526
> > > >
> > > > ---
> > > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > > https://lists.01.org/hyperkitty/list/kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
> > > >
> > >
> > >
> > > _______________________________________________
> > > kbuild-all mailing list -- kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
> > > To unsubscribe send an email to kbuild-all-leave-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: amd-gfx@lists.freedesktop.org, kbuild-all@lists.01.org,
kernel test robot <lkp@intel.com>,
Rong Chen <rong.a.chen@intel.com>,
airlied@linux.ie, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
rodrigo.vivi@intel.com, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [kbuild-all] Re: [PATCH v3 8/8] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev
Date: Fri, 8 Jan 2021 10:02:27 +0100 [thread overview]
Message-ID: <X/gfo5k0efFhxP/I@phenom.ffwll.local> (raw)
In-Reply-To: <5ea2a270-2664-fad4-0048-ef498137e985@suse.de>
On Fri, Jan 08, 2021 at 09:04:44AM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 08.01.21 um 02:25 schrieb Rong Chen:
> > Hi Thomas,
> >
> > Thanks for the feedback, do you mean the patch was applied to a wrong base?
>
> I'm on drm-tip, which already has the patches that fix these issues. I think
> I should start using git's --base option when sending out patchsets.
From today all the patches should also be in linux-next. Our maintainer
script didn't push the branches to the right tags because drm-misc-fixes
wasn't rolled forward yet (there's some trickery to make sure we don't
push patches to linux-next for the subsequent merge window before -rc1 is
tagged).
-Daniel
>
> Best regards
> Thomas
>
> >
> > Best Regards,
> > Rong Chen
> >
> > On 1/7/21 6:45 PM, Thomas Zimmermann wrote:
> > > AFAICT these are false positives. The instances have been fixed already.
> > >
> > > Am 07.01.21 um 10:45 schrieb kernel test robot:
> > > > Hi Thomas,
> > > >
> > > > I love your patch! Yet something to improve:
> > > >
> > > > [auto build test ERROR on drm-tip/drm-tip]
> > > > [cannot apply to drm-intel/for-linux-next linus/master v5.11-rc2
> > > > next-20210104]
> > > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > > And when submitting patch, we suggest to use '--base' as documented in
> > > > https://git-scm.com/docs/git-format-patch]
> > > >
> > > > url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Move-struct-drm_device-pdev-to-legacy/20210107-161007
> > > >
> > > > base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
> > > > config: x86_64-randconfig-s021-20210107 (attached as .config)
> > > > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > > > reproduce:
> > > > # apt-get install sparse
> > > > # sparse version: v0.6.3-208-g46a52ca4-dirty
> > > > # https://github.com/0day-ci/linux/commit/380912f7b62c23322562c40e19efd7ad84d57e9c
> > > >
> > > > git remote add linux-review https://github.com/0day-ci/linux
> > > > git fetch --no-tags linux-review Thomas-Zimmermann/drm-Move-struct-drm_device-pdev-to-legacy/20210107-161007
> > > >
> > > > git checkout 380912f7b62c23322562c40e19efd7ad84d57e9c
> > > > # save the attached .config to linux build tree
> > > > make W=1 C=1 CF='-fdiagnostic-prefix
> > > > -D__CHECK_ENDIAN__' ARCH=x86_64
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > > drivers/gpu/drm/gma500/oaktrail_device.c: In function
> > > > 'oaktrail_chip_setup':
> > > > > > drivers/gpu/drm/gma500/oaktrail_device.c:509:26: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 509 | if (pci_enable_msi(dev->pdev))
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/gma500/oaktrail_lvds.c: In function
> > > > 'oaktrail_lvds_set_power':
> > > > > > drivers/gpu/drm/gma500/oaktrail_lvds.c:63:25: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 63 | pm_request_idle(&dev->pdev->dev);
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function 'get_clock':
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:69:11: warning:
> > > > variable 'tmp' set but not used [-Wunused-but-set-variable]
> > > > 69 | u32 val, tmp;
> > > > | ^~~
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function 'get_data':
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:83:11: warning:
> > > > variable 'tmp' set but not used [-Wunused-but-set-variable]
> > > > 83 | u32 val, tmp;
> > > > | ^~~
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function
> > > > 'oaktrail_lvds_i2c_init':
> > > > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:148:35:
> > > > > > error: 'struct drm_device' has no member named 'pdev';
> > > > > > did you mean 'dev'?
> > > > 148 | chan->adapter.dev.parent = &dev->pdev->dev;
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function 'vmw_driver_load':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:661:22: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 661 | pci_set_master(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > In file included from drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:31:
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:690:47: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 690 | dev_priv->io_start = pci_resource_start(dev->pdev, 0);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:691:49: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 691 | dev_priv->vram_start = pci_resource_start(dev->pdev, 1);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:692:49: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 692 | dev_priv->mmio_start = pci_resource_start(dev->pdev, 2);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:842:33: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 842 | ret = pci_request_regions(dev->pdev, "vmwgfx probe");
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:851:33: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 851 | ret = pci_request_region(dev->pdev, 2, "vmwgfx
> > > > stealth probe");
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:859:35: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 859 | ret = vmw_irq_install(dev, dev->pdev->irq);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1005:27: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1005 | pci_release_region(dev->pdev, 2);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1007:28: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1007 | pci_release_regions(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function
> > > > 'vmw_driver_unload':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1056:27: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1056 | pci_release_region(dev->pdev, 2);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1058:28: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1058 | pci_release_regions(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function 'vmw_probe':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1522:7: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1522 | dev->pdev = pdev;
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:641:42: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 641 | struct device *device = &vmw_priv->dev->pdev->dev;
> > > > | ^~~~
> > > > | dev
> > > > In file included from drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:35:
> > > > At top level:
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning:
> > > > 'vmw_cursor_plane_formats' defined but not used
> > > > [-Wunused-const-variable=]
> > > > 256 | static const uint32_t vmw_cursor_plane_formats[] = {
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning:
> > > > 'vmw_primary_plane_formats' defined but not used
> > > > [-Wunused-const-variable=]
> > > > 248 | static const uint32_t vmw_primary_plane_formats[] = {
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_set_pool_size':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1233:48: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 1233 | man->map =
> > > > dma_alloc_coherent(&dev_priv->dev->pdev->dev, size,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_man_create':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1316:28: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1316 | &dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1325:22: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1325 | &dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_remove_pool':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1390:42: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1390 | dma_free_coherent(&man->dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > >
> > > >
> > > > vim +509 drivers/gpu/drm/gma500/oaktrail_device.c
> > > >
> > > > 1b082ccf5901108 Alan Cox 2011-11-03 503
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 504 static int
> > > > oaktrail_chip_setup(struct drm_device *dev)
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 505 {
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 506 struct
> > > > drm_psb_private *dev_priv = dev->dev_private;
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 507 int ret;
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 508
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 @509 if
> > > > (pci_enable_msi(dev->pdev))
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 510
> > > > dev_warn(dev->dev, "Enabling MSI failed!\n");
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 511
> > > > 8512e0748729a49 Alan Cox 2012-05-11 512
> > > > dev_priv->regmap = oaktrail_regmap;
> > > > 8512e0748729a49 Alan Cox 2012-05-11 513
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 514 ret =
> > > > mid_chip_setup(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 515 if (ret < 0)
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 516 return ret;
> > > > 4086b1e2b19729e Kirill A. Shutemov 2012-05-03 517 if
> > > > (!dev_priv->has_gct) {
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 518 /*
> > > > Now pull the BIOS data */
> > > > d839ede47a56ff5 Alan Cox 2012-05-03 519
> > > > psb_intel_opregion_init(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 520
> > > > psb_intel_init_bios(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 521 }
> > > > 6528c897966c7d5 Patrik Jakobsson 2013-11-07 522
> > > > gma_intel_setup_gmbus(dev);
> > > > 5f503148efdda26 Alan Cox 2012-05-03 523
> > > > oaktrail_hdmi_setup(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 524 return 0;
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 525 }
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 526
> > > >
> > > > ---
> > > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> > > >
> > >
> > >
> > > _______________________________________________
> > > kbuild-all mailing list -- kbuild-all@lists.01.org
> > > To unsubscribe send an email to kbuild-all-leave@lists.01.org
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: amd-gfx@lists.freedesktop.org, kbuild-all@lists.01.org,
Rong Chen <rong.a.chen@intel.com>,
airlied@linux.ie, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [Intel-gfx] [kbuild-all] Re: [PATCH v3 8/8] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev
Date: Fri, 8 Jan 2021 10:02:27 +0100 [thread overview]
Message-ID: <X/gfo5k0efFhxP/I@phenom.ffwll.local> (raw)
In-Reply-To: <5ea2a270-2664-fad4-0048-ef498137e985@suse.de>
On Fri, Jan 08, 2021 at 09:04:44AM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 08.01.21 um 02:25 schrieb Rong Chen:
> > Hi Thomas,
> >
> > Thanks for the feedback, do you mean the patch was applied to a wrong base?
>
> I'm on drm-tip, which already has the patches that fix these issues. I think
> I should start using git's --base option when sending out patchsets.
From today all the patches should also be in linux-next. Our maintainer
script didn't push the branches to the right tags because drm-misc-fixes
wasn't rolled forward yet (there's some trickery to make sure we don't
push patches to linux-next for the subsequent merge window before -rc1 is
tagged).
-Daniel
>
> Best regards
> Thomas
>
> >
> > Best Regards,
> > Rong Chen
> >
> > On 1/7/21 6:45 PM, Thomas Zimmermann wrote:
> > > AFAICT these are false positives. The instances have been fixed already.
> > >
> > > Am 07.01.21 um 10:45 schrieb kernel test robot:
> > > > Hi Thomas,
> > > >
> > > > I love your patch! Yet something to improve:
> > > >
> > > > [auto build test ERROR on drm-tip/drm-tip]
> > > > [cannot apply to drm-intel/for-linux-next linus/master v5.11-rc2
> > > > next-20210104]
> > > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > > And when submitting patch, we suggest to use '--base' as documented in
> > > > https://git-scm.com/docs/git-format-patch]
> > > >
> > > > url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Move-struct-drm_device-pdev-to-legacy/20210107-161007
> > > >
> > > > base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
> > > > config: x86_64-randconfig-s021-20210107 (attached as .config)
> > > > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > > > reproduce:
> > > > # apt-get install sparse
> > > > # sparse version: v0.6.3-208-g46a52ca4-dirty
> > > > # https://github.com/0day-ci/linux/commit/380912f7b62c23322562c40e19efd7ad84d57e9c
> > > >
> > > > git remote add linux-review https://github.com/0day-ci/linux
> > > > git fetch --no-tags linux-review Thomas-Zimmermann/drm-Move-struct-drm_device-pdev-to-legacy/20210107-161007
> > > >
> > > > git checkout 380912f7b62c23322562c40e19efd7ad84d57e9c
> > > > # save the attached .config to linux build tree
> > > > make W=1 C=1 CF='-fdiagnostic-prefix
> > > > -D__CHECK_ENDIAN__' ARCH=x86_64
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > > drivers/gpu/drm/gma500/oaktrail_device.c: In function
> > > > 'oaktrail_chip_setup':
> > > > > > drivers/gpu/drm/gma500/oaktrail_device.c:509:26: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 509 | if (pci_enable_msi(dev->pdev))
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/gma500/oaktrail_lvds.c: In function
> > > > 'oaktrail_lvds_set_power':
> > > > > > drivers/gpu/drm/gma500/oaktrail_lvds.c:63:25: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 63 | pm_request_idle(&dev->pdev->dev);
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function 'get_clock':
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:69:11: warning:
> > > > variable 'tmp' set but not used [-Wunused-but-set-variable]
> > > > 69 | u32 val, tmp;
> > > > | ^~~
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function 'get_data':
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:83:11: warning:
> > > > variable 'tmp' set but not used [-Wunused-but-set-variable]
> > > > 83 | u32 val, tmp;
> > > > | ^~~
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function
> > > > 'oaktrail_lvds_i2c_init':
> > > > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:148:35:
> > > > > > error: 'struct drm_device' has no member named 'pdev';
> > > > > > did you mean 'dev'?
> > > > 148 | chan->adapter.dev.parent = &dev->pdev->dev;
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function 'vmw_driver_load':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:661:22: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 661 | pci_set_master(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > In file included from drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:31:
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:690:47: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 690 | dev_priv->io_start = pci_resource_start(dev->pdev, 0);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:691:49: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 691 | dev_priv->vram_start = pci_resource_start(dev->pdev, 1);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:692:49: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 692 | dev_priv->mmio_start = pci_resource_start(dev->pdev, 2);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:842:33: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 842 | ret = pci_request_regions(dev->pdev, "vmwgfx probe");
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:851:33: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 851 | ret = pci_request_region(dev->pdev, 2, "vmwgfx
> > > > stealth probe");
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:859:35: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 859 | ret = vmw_irq_install(dev, dev->pdev->irq);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1005:27: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1005 | pci_release_region(dev->pdev, 2);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1007:28: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1007 | pci_release_regions(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function
> > > > 'vmw_driver_unload':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1056:27: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1056 | pci_release_region(dev->pdev, 2);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1058:28: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1058 | pci_release_regions(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function 'vmw_probe':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1522:7: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1522 | dev->pdev = pdev;
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:641:42: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 641 | struct device *device = &vmw_priv->dev->pdev->dev;
> > > > | ^~~~
> > > > | dev
> > > > In file included from drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:35:
> > > > At top level:
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning:
> > > > 'vmw_cursor_plane_formats' defined but not used
> > > > [-Wunused-const-variable=]
> > > > 256 | static const uint32_t vmw_cursor_plane_formats[] = {
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning:
> > > > 'vmw_primary_plane_formats' defined but not used
> > > > [-Wunused-const-variable=]
> > > > 248 | static const uint32_t vmw_primary_plane_formats[] = {
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_set_pool_size':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1233:48: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 1233 | man->map =
> > > > dma_alloc_coherent(&dev_priv->dev->pdev->dev, size,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_man_create':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1316:28: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1316 | &dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1325:22: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1325 | &dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_remove_pool':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1390:42: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1390 | dma_free_coherent(&man->dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > >
> > > >
> > > > vim +509 drivers/gpu/drm/gma500/oaktrail_device.c
> > > >
> > > > 1b082ccf5901108 Alan Cox 2011-11-03 503
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 504 static int
> > > > oaktrail_chip_setup(struct drm_device *dev)
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 505 {
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 506 struct
> > > > drm_psb_private *dev_priv = dev->dev_private;
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 507 int ret;
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 508
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 @509 if
> > > > (pci_enable_msi(dev->pdev))
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 510
> > > > dev_warn(dev->dev, "Enabling MSI failed!\n");
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 511
> > > > 8512e0748729a49 Alan Cox 2012-05-11 512
> > > > dev_priv->regmap = oaktrail_regmap;
> > > > 8512e0748729a49 Alan Cox 2012-05-11 513
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 514 ret =
> > > > mid_chip_setup(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 515 if (ret < 0)
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 516 return ret;
> > > > 4086b1e2b19729e Kirill A. Shutemov 2012-05-03 517 if
> > > > (!dev_priv->has_gct) {
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 518 /*
> > > > Now pull the BIOS data */
> > > > d839ede47a56ff5 Alan Cox 2012-05-03 519
> > > > psb_intel_opregion_init(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 520
> > > > psb_intel_init_bios(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 521 }
> > > > 6528c897966c7d5 Patrik Jakobsson 2013-11-07 522
> > > > gma_intel_setup_gmbus(dev);
> > > > 5f503148efdda26 Alan Cox 2012-05-03 523
> > > > oaktrail_hdmi_setup(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 524 return 0;
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 525 }
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 526
> > > >
> > > > ---
> > > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> > > >
> > >
> > >
> > > _______________________________________________
> > > kbuild-all mailing list -- kbuild-all@lists.01.org
> > > To unsubscribe send an email to kbuild-all-leave@lists.01.org
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: amd-gfx@lists.freedesktop.org, kbuild-all@lists.01.org,
kernel test robot <lkp@intel.com>,
Rong Chen <rong.a.chen@intel.com>,
airlied@linux.ie, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, joonas.lahtinen@linux.intel.com,
jani.nikula@linux.intel.com, dri-devel@lists.freedesktop.org,
daniel@ffwll.ch, rodrigo.vivi@intel.com,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [kbuild-all] Re: [PATCH v3 8/8] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev
Date: Fri, 8 Jan 2021 10:02:27 +0100 [thread overview]
Message-ID: <X/gfo5k0efFhxP/I@phenom.ffwll.local> (raw)
In-Reply-To: <5ea2a270-2664-fad4-0048-ef498137e985@suse.de>
On Fri, Jan 08, 2021 at 09:04:44AM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 08.01.21 um 02:25 schrieb Rong Chen:
> > Hi Thomas,
> >
> > Thanks for the feedback, do you mean the patch was applied to a wrong base?
>
> I'm on drm-tip, which already has the patches that fix these issues. I think
> I should start using git's --base option when sending out patchsets.
From today all the patches should also be in linux-next. Our maintainer
script didn't push the branches to the right tags because drm-misc-fixes
wasn't rolled forward yet (there's some trickery to make sure we don't
push patches to linux-next for the subsequent merge window before -rc1 is
tagged).
-Daniel
>
> Best regards
> Thomas
>
> >
> > Best Regards,
> > Rong Chen
> >
> > On 1/7/21 6:45 PM, Thomas Zimmermann wrote:
> > > AFAICT these are false positives. The instances have been fixed already.
> > >
> > > Am 07.01.21 um 10:45 schrieb kernel test robot:
> > > > Hi Thomas,
> > > >
> > > > I love your patch! Yet something to improve:
> > > >
> > > > [auto build test ERROR on drm-tip/drm-tip]
> > > > [cannot apply to drm-intel/for-linux-next linus/master v5.11-rc2
> > > > next-20210104]
> > > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > > And when submitting patch, we suggest to use '--base' as documented in
> > > > https://git-scm.com/docs/git-format-patch]
> > > >
> > > > url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Move-struct-drm_device-pdev-to-legacy/20210107-161007
> > > >
> > > > base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
> > > > config: x86_64-randconfig-s021-20210107 (attached as .config)
> > > > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > > > reproduce:
> > > > # apt-get install sparse
> > > > # sparse version: v0.6.3-208-g46a52ca4-dirty
> > > > # https://github.com/0day-ci/linux/commit/380912f7b62c23322562c40e19efd7ad84d57e9c
> > > >
> > > > git remote add linux-review https://github.com/0day-ci/linux
> > > > git fetch --no-tags linux-review Thomas-Zimmermann/drm-Move-struct-drm_device-pdev-to-legacy/20210107-161007
> > > >
> > > > git checkout 380912f7b62c23322562c40e19efd7ad84d57e9c
> > > > # save the attached .config to linux build tree
> > > > make W=1 C=1 CF='-fdiagnostic-prefix
> > > > -D__CHECK_ENDIAN__' ARCH=x86_64
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > > drivers/gpu/drm/gma500/oaktrail_device.c: In function
> > > > 'oaktrail_chip_setup':
> > > > > > drivers/gpu/drm/gma500/oaktrail_device.c:509:26: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 509 | if (pci_enable_msi(dev->pdev))
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/gma500/oaktrail_lvds.c: In function
> > > > 'oaktrail_lvds_set_power':
> > > > > > drivers/gpu/drm/gma500/oaktrail_lvds.c:63:25: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 63 | pm_request_idle(&dev->pdev->dev);
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function 'get_clock':
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:69:11: warning:
> > > > variable 'tmp' set but not used [-Wunused-but-set-variable]
> > > > 69 | u32 val, tmp;
> > > > | ^~~
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function 'get_data':
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:83:11: warning:
> > > > variable 'tmp' set but not used [-Wunused-but-set-variable]
> > > > 83 | u32 val, tmp;
> > > > | ^~~
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function
> > > > 'oaktrail_lvds_i2c_init':
> > > > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:148:35:
> > > > > > error: 'struct drm_device' has no member named 'pdev';
> > > > > > did you mean 'dev'?
> > > > 148 | chan->adapter.dev.parent = &dev->pdev->dev;
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function 'vmw_driver_load':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:661:22: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 661 | pci_set_master(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > In file included from drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:31:
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:690:47: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 690 | dev_priv->io_start = pci_resource_start(dev->pdev, 0);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:691:49: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 691 | dev_priv->vram_start = pci_resource_start(dev->pdev, 1);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:692:49: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 692 | dev_priv->mmio_start = pci_resource_start(dev->pdev, 2);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:842:33: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 842 | ret = pci_request_regions(dev->pdev, "vmwgfx probe");
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:851:33: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 851 | ret = pci_request_region(dev->pdev, 2, "vmwgfx
> > > > stealth probe");
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:859:35: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 859 | ret = vmw_irq_install(dev, dev->pdev->irq);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1005:27: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1005 | pci_release_region(dev->pdev, 2);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1007:28: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1007 | pci_release_regions(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function
> > > > 'vmw_driver_unload':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1056:27: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1056 | pci_release_region(dev->pdev, 2);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1058:28: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1058 | pci_release_regions(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function 'vmw_probe':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1522:7: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1522 | dev->pdev = pdev;
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:641:42: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 641 | struct device *device = &vmw_priv->dev->pdev->dev;
> > > > | ^~~~
> > > > | dev
> > > > In file included from drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:35:
> > > > At top level:
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning:
> > > > 'vmw_cursor_plane_formats' defined but not used
> > > > [-Wunused-const-variable=]
> > > > 256 | static const uint32_t vmw_cursor_plane_formats[] = {
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning:
> > > > 'vmw_primary_plane_formats' defined but not used
> > > > [-Wunused-const-variable=]
> > > > 248 | static const uint32_t vmw_primary_plane_formats[] = {
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_set_pool_size':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1233:48: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 1233 | man->map =
> > > > dma_alloc_coherent(&dev_priv->dev->pdev->dev, size,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_man_create':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1316:28: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1316 | &dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1325:22: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1325 | &dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_remove_pool':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1390:42: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1390 | dma_free_coherent(&man->dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > >
> > > >
> > > > vim +509 drivers/gpu/drm/gma500/oaktrail_device.c
> > > >
> > > > 1b082ccf5901108 Alan Cox 2011-11-03 503
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 504 static int
> > > > oaktrail_chip_setup(struct drm_device *dev)
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 505 {
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 506 struct
> > > > drm_psb_private *dev_priv = dev->dev_private;
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 507 int ret;
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 508
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 @509 if
> > > > (pci_enable_msi(dev->pdev))
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 510
> > > > dev_warn(dev->dev, "Enabling MSI failed!\n");
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 511
> > > > 8512e0748729a49 Alan Cox 2012-05-11 512
> > > > dev_priv->regmap = oaktrail_regmap;
> > > > 8512e0748729a49 Alan Cox 2012-05-11 513
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 514 ret =
> > > > mid_chip_setup(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 515 if (ret < 0)
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 516 return ret;
> > > > 4086b1e2b19729e Kirill A. Shutemov 2012-05-03 517 if
> > > > (!dev_priv->has_gct) {
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 518 /*
> > > > Now pull the BIOS data */
> > > > d839ede47a56ff5 Alan Cox 2012-05-03 519
> > > > psb_intel_opregion_init(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 520
> > > > psb_intel_init_bios(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 521 }
> > > > 6528c897966c7d5 Patrik Jakobsson 2013-11-07 522
> > > > gma_intel_setup_gmbus(dev);
> > > > 5f503148efdda26 Alan Cox 2012-05-03 523
> > > > oaktrail_hdmi_setup(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 524 return 0;
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 525 }
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 526
> > > >
> > > > ---
> > > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> > > >
> > >
> > >
> > > _______________________________________________
> > > kbuild-all mailing list -- kbuild-all@lists.01.org
> > > To unsubscribe send an email to kbuild-all-leave@lists.01.org
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 8/8] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev
Date: Fri, 08 Jan 2021 10:02:27 +0100 [thread overview]
Message-ID: <X/gfo5k0efFhxP/I@phenom.ffwll.local> (raw)
In-Reply-To: <5ea2a270-2664-fad4-0048-ef498137e985@suse.de>
[-- Attachment #1: Type: text/plain, Size: 17337 bytes --]
On Fri, Jan 08, 2021 at 09:04:44AM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 08.01.21 um 02:25 schrieb Rong Chen:
> > Hi Thomas,
> >
> > Thanks for the feedback, do you mean the patch was applied to a wrong base?
>
> I'm on drm-tip, which already has the patches that fix these issues. I think
> I should start using git's --base option when sending out patchsets.
>From today all the patches should also be in linux-next. Our maintainer
script didn't push the branches to the right tags because drm-misc-fixes
wasn't rolled forward yet (there's some trickery to make sure we don't
push patches to linux-next for the subsequent merge window before -rc1 is
tagged).
-Daniel
>
> Best regards
> Thomas
>
> >
> > Best Regards,
> > Rong Chen
> >
> > On 1/7/21 6:45 PM, Thomas Zimmermann wrote:
> > > AFAICT these are false positives. The instances have been fixed already.
> > >
> > > Am 07.01.21 um 10:45 schrieb kernel test robot:
> > > > Hi Thomas,
> > > >
> > > > I love your patch! Yet something to improve:
> > > >
> > > > [auto build test ERROR on drm-tip/drm-tip]
> > > > [cannot apply to drm-intel/for-linux-next linus/master v5.11-rc2
> > > > next-20210104]
> > > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > > And when submitting patch, we suggest to use '--base' as documented in
> > > > https://git-scm.com/docs/git-format-patch]
> > > >
> > > > url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/drm-Move-struct-drm_device-pdev-to-legacy/20210107-161007
> > > >
> > > > base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
> > > > config: x86_64-randconfig-s021-20210107 (attached as .config)
> > > > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > > > reproduce:
> > > > # apt-get install sparse
> > > > # sparse version: v0.6.3-208-g46a52ca4-dirty
> > > > # https://github.com/0day-ci/linux/commit/380912f7b62c23322562c40e19efd7ad84d57e9c
> > > >
> > > > git remote add linux-review https://github.com/0day-ci/linux
> > > > git fetch --no-tags linux-review Thomas-Zimmermann/drm-Move-struct-drm_device-pdev-to-legacy/20210107-161007
> > > >
> > > > git checkout 380912f7b62c23322562c40e19efd7ad84d57e9c
> > > > # save the attached .config to linux build tree
> > > > make W=1 C=1 CF='-fdiagnostic-prefix
> > > > -D__CHECK_ENDIAN__' ARCH=x86_64
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > > drivers/gpu/drm/gma500/oaktrail_device.c: In function
> > > > 'oaktrail_chip_setup':
> > > > > > drivers/gpu/drm/gma500/oaktrail_device.c:509:26: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 509 | if (pci_enable_msi(dev->pdev))
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/gma500/oaktrail_lvds.c: In function
> > > > 'oaktrail_lvds_set_power':
> > > > > > drivers/gpu/drm/gma500/oaktrail_lvds.c:63:25: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 63 | pm_request_idle(&dev->pdev->dev);
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function 'get_clock':
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:69:11: warning:
> > > > variable 'tmp' set but not used [-Wunused-but-set-variable]
> > > > 69 | u32 val, tmp;
> > > > | ^~~
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function 'get_data':
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:83:11: warning:
> > > > variable 'tmp' set but not used [-Wunused-but-set-variable]
> > > > 83 | u32 val, tmp;
> > > > | ^~~
> > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c: In function
> > > > 'oaktrail_lvds_i2c_init':
> > > > > > drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c:148:35:
> > > > > > error: 'struct drm_device' has no member named 'pdev';
> > > > > > did you mean 'dev'?
> > > > 148 | chan->adapter.dev.parent = &dev->pdev->dev;
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function 'vmw_driver_load':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:661:22: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 661 | pci_set_master(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > In file included from drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:31:
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:690:47: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 690 | dev_priv->io_start = pci_resource_start(dev->pdev, 0);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:691:49: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 691 | dev_priv->vram_start = pci_resource_start(dev->pdev, 1);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:692:49: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 692 | dev_priv->mmio_start = pci_resource_start(dev->pdev, 2);
> > > > | ^~~~
> > > > include/linux/pci.h:1854:40: note: in definition of macro
> > > > 'pci_resource_start'
> > > > 1854 | #define pci_resource_start(dev, bar)
> > > > ((dev)->resource[(bar)].start)
> > > > | ^~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:842:33: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 842 | ret = pci_request_regions(dev->pdev, "vmwgfx probe");
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:851:33: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 851 | ret = pci_request_region(dev->pdev, 2, "vmwgfx
> > > > stealth probe");
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:859:35: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 859 | ret = vmw_irq_install(dev, dev->pdev->irq);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1005:27: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1005 | pci_release_region(dev->pdev, 2);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1007:28: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1007 | pci_release_regions(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function
> > > > 'vmw_driver_unload':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1056:27: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1056 | pci_release_region(dev->pdev, 2);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1058:28: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1058 | pci_release_regions(dev->pdev);
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c: In function 'vmw_probe':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c:1522:7: error: 'struct
> > > > drm_device' has no member named 'pdev'; did you mean 'dev'?
> > > > 1522 | dev->pdev = pdev;
> > > > | ^~~~
> > > > | dev
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: In function 'vmw_fb_init':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:641:42: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 641 | struct device *device = &vmw_priv->dev->pdev->dev;
> > > > | ^~~~
> > > > | dev
> > > > In file included from drivers/gpu/drm/vmwgfx/vmwgfx_fb.c:35:
> > > > At top level:
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:256:23: warning:
> > > > 'vmw_cursor_plane_formats' defined but not used
> > > > [-Wunused-const-variable=]
> > > > 256 | static const uint32_t vmw_cursor_plane_formats[] = {
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h:248:23: warning:
> > > > 'vmw_primary_plane_formats' defined but not used
> > > > [-Wunused-const-variable=]
> > > > 248 | static const uint32_t vmw_primary_plane_formats[] = {
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > > > --
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_set_pool_size':
> > > > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1233:48: error:
> > > > > > 'struct drm_device' has no member named 'pdev'; did you
> > > > > > mean 'dev'?
> > > > 1233 | man->map =
> > > > dma_alloc_coherent(&dev_priv->dev->pdev->dev, size,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_man_create':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1316:28: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1316 | &dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1325:22: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1325 | &dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function
> > > > 'vmw_cmdbuf_remove_pool':
> > > > drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1390:42: error:
> > > > 'struct drm_device' has no member named 'pdev'; did you mean
> > > > 'dev'?
> > > > 1390 | dma_free_coherent(&man->dev_priv->dev->pdev->dev,
> > > > | ^~~~
> > > > | dev
> > > >
> > > >
> > > > vim +509 drivers/gpu/drm/gma500/oaktrail_device.c
> > > >
> > > > 1b082ccf5901108 Alan Cox 2011-11-03 503
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 504 static int
> > > > oaktrail_chip_setup(struct drm_device *dev)
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 505 {
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 506 struct
> > > > drm_psb_private *dev_priv = dev->dev_private;
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 507 int ret;
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 508
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 @509 if
> > > > (pci_enable_msi(dev->pdev))
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 510
> > > > dev_warn(dev->dev, "Enabling MSI failed!\n");
> > > > 9c0b6fcdc9faee5 Alan Cox 2012-05-11 511
> > > > 8512e0748729a49 Alan Cox 2012-05-11 512
> > > > dev_priv->regmap = oaktrail_regmap;
> > > > 8512e0748729a49 Alan Cox 2012-05-11 513
> > > > 1b22edfd6efd02b Alan Cox 2011-11-29 514 ret =
> > > > mid_chip_setup(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 515 if (ret < 0)
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 516 return ret;
> > > > 4086b1e2b19729e Kirill A. Shutemov 2012-05-03 517 if
> > > > (!dev_priv->has_gct) {
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 518 /*
> > > > Now pull the BIOS data */
> > > > d839ede47a56ff5 Alan Cox 2012-05-03 519
> > > > psb_intel_opregion_init(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 520
> > > > psb_intel_init_bios(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 521 }
> > > > 6528c897966c7d5 Patrik Jakobsson 2013-11-07 522
> > > > gma_intel_setup_gmbus(dev);
> > > > 5f503148efdda26 Alan Cox 2012-05-03 523
> > > > oaktrail_hdmi_setup(dev);
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 524 return 0;
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 525 }
> > > > aa0c45fdca0cff3 Alan Cox 2011-11-29 526
> > > >
> > > > ---
> > > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
> > > >
> > >
> > >
> > > _______________________________________________
> > > kbuild-all mailing list -- kbuild-all(a)lists.01.org
> > > To unsubscribe send an email to kbuild-all-leave(a)lists.01.org
> >
>
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2021-01-08 9:02 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 8:07 [PATCH v3 0/8] drm: Move struct drm_device.pdev to legacy Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [Intel-gfx] " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
[not found] ` <20210107080748.4768-1-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2021-01-07 8:07 ` [PATCH v3 1/8] drm/amdgpu: Fix trailing whitespaces Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [Intel-gfx] " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [PATCH v3 2/8] drm/amdgpu: Remove references to struct drm_device.pdev Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [Intel-gfx] " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-18 13:50 ` Christian König
2021-01-18 13:50 ` Christian König
2021-01-18 13:50 ` [Intel-gfx] " Christian König
2021-01-18 13:50 ` Christian König
[not found] ` <324f0bd9-7430-f42e-1170-4dbfc06ea904-5C7GfCeVMHo@public.gmane.org>
2021-01-18 14:40 ` Thomas Zimmermann
2021-01-18 14:40 ` Thomas Zimmermann
2021-01-18 14:40 ` [Intel-gfx] " Thomas Zimmermann
2021-01-18 14:40 ` Thomas Zimmermann
[not found] ` <5ce5f636-d428-c611-9db1-3172de2d56d2-l3A5Bk7waGM@public.gmane.org>
2021-01-18 14:56 ` Daniel Vetter
2021-01-18 14:56 ` Daniel Vetter
2021-01-18 14:56 ` [Intel-gfx] " Daniel Vetter
2021-01-18 14:56 ` Daniel Vetter
[not found] ` <CAKMK7uEwEvrTf2f3B1WsvaDaQg6o7ubXDNUhcX7eAd8vC05n-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-01-18 15:02 ` Thomas Zimmermann
2021-01-18 15:02 ` Thomas Zimmermann
2021-01-18 15:02 ` [Intel-gfx] " Thomas Zimmermann
2021-01-18 15:02 ` Thomas Zimmermann
2021-01-07 8:07 ` [PATCH v3 3/8] drm/hibmc: " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [Intel-gfx] " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [PATCH v3 4/8] drm/i915: " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [Intel-gfx] " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [PATCH v3 6/8] drm/i915/gvt: " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [Intel-gfx] " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [PATCH v3 5/8] drm/i915/gt: " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [Intel-gfx] " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [PATCH v3 7/8] drm/nouveau: " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [Intel-gfx] " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [PATCH v3 8/8] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
2021-01-07 8:07 ` [Intel-gfx] " Thomas Zimmermann
2021-01-07 8:07 ` Thomas Zimmermann
[not found] ` <20210107080748.4768-9-tzimmermann-l3A5Bk7waGM@public.gmane.org>
2021-01-07 9:45 ` kernel test robot
2021-01-07 9:45 ` kernel test robot
2021-01-07 9:45 ` kernel test robot
2021-01-07 9:45 ` [Intel-gfx] " kernel test robot
2021-01-07 9:45 ` kernel test robot
[not found] ` <202101071706.J19283ri-lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2021-01-07 10:45 ` Thomas Zimmermann
2021-01-07 10:45 ` Thomas Zimmermann
2021-01-07 10:45 ` Thomas Zimmermann
2021-01-07 10:45 ` [Intel-gfx] " Thomas Zimmermann
2021-01-07 10:45 ` Thomas Zimmermann
2021-01-08 1:25 ` [kbuild-all] " Rong Chen
2021-01-08 1:25 ` Rong Chen
2021-01-08 1:25 ` [kbuild-all] " Rong Chen
2021-01-08 1:25 ` [Intel-gfx] " Rong Chen
2021-01-08 1:25 ` Rong Chen
[not found] ` <7486aeef-9fa4-91cb-8e95-383990cf3567-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2021-01-08 8:04 ` Thomas Zimmermann
2021-01-08 8:04 ` Thomas Zimmermann
2021-01-08 8:04 ` [kbuild-all] " Thomas Zimmermann
2021-01-08 8:04 ` [Intel-gfx] " Thomas Zimmermann
2021-01-08 8:04 ` Thomas Zimmermann
[not found] ` <5ea2a270-2664-fad4-0048-ef498137e985-l3A5Bk7waGM@public.gmane.org>
2021-01-08 9:02 ` Daniel Vetter [this message]
2021-01-08 9:02 ` Daniel Vetter
2021-01-08 9:02 ` [kbuild-all] " Daniel Vetter
2021-01-08 9:02 ` [Intel-gfx] " Daniel Vetter
2021-01-08 9:02 ` Daniel Vetter
2021-01-07 9:47 ` kernel test robot
2021-01-07 9:47 ` kernel test robot
2021-01-07 9:47 ` kernel test robot
2021-01-07 9:47 ` [Intel-gfx] " kernel test robot
2021-01-07 9:47 ` kernel test robot
2021-01-07 15:33 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: Move struct drm_device.pdev to legacy (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/gfo5k0efFhxP/I@phenom.ffwll.local \
--to=daniel-/w4ywyx8dfk@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=joonas.lahtinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=rodrigo.vivi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=rong.a.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=sam-uyr5N9Q2VtJg9hUCZPvPmw@public.gmane.org \
--cc=tzimmermann-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.