From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Vinod Koul <vkoul@kernel.org>, Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
dri-devel@lists.freedesktop.org, dmaengine@vger.kernel.org,
alsa-devel@alsa-project.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: Drop redundant maxItems/items
Date: Tue, 22 Dec 2020 09:00:01 +0200 [thread overview]
Message-ID: <X+GZcXJoZ15vgxB2@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20201222040645.1323611-1-robh@kernel.org>
Hi Rob,
Thank you for the patch.
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
> Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 -
> .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 --
> Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 -
> Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 ---
> 6 files changed, 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> index 7b9d468c3e52..403d57977ee7 100644
> --- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> @@ -98,7 +98,6 @@ properties:
> maxItems: 1
>
> dmas:
> - maxItems: 4
> items:
> - description: Video layer, plane 0 (RGB or luma)
> - description: Video layer, plane 1 (U/V or U)
> diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> index b548e4723936..c07eb6f2fc8d 100644
> --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> @@ -73,7 +73,6 @@ properties:
> maxItems: 1
>
> clock-names:
> - maxItems: 1
> items:
> - const: fck
>
> diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> index d43791a2dde7..d07eb00b97c8 100644
> --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> @@ -61,7 +61,6 @@ properties:
> - description: low-priority non-secure
> - description: high-priority non-secure
> - description: Secure
> - maxItems: 3
>
> clocks:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> index e543a6123792..b55775e21de6 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> @@ -44,7 +44,6 @@ properties:
> maxItems: 3
>
> clock-names:
> - maxItems: 3
> items:
> - const: hda
> - const: hda2hdmi
> @@ -54,7 +53,6 @@ properties:
> maxItems: 3
>
> reset-names:
> - maxItems: 3
> items:
> - const: hda
> - const: hda2hdmi
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> index 0f078bd0a3e5..22603256ddf8 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> @@ -51,7 +51,6 @@ properties:
> maxItems: 1
>
> phy-names:
> - maxItems: 1
> items:
> - const: usb
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> index 737c1f47b7de..54c361d4a7af 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> @@ -74,11 +74,8 @@ properties:
>
> phys:
> maxItems: 1
> - items:
> - - description: phandle + phy specifier pair.
>
> phy-names:
> - maxItems: 1
> items:
> - const: usb
>
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Jassi Brar <jaswinder.singh@linaro.org>,
Vinod Koul <vkoul@kernel.org>, Mark Brown <broonie@kernel.org>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: Drop redundant maxItems/items
Date: Tue, 22 Dec 2020 09:00:01 +0200 [thread overview]
Message-ID: <X+GZcXJoZ15vgxB2@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20201222040645.1323611-1-robh@kernel.org>
Hi Rob,
Thank you for the patch.
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
> Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 -
> .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 --
> Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 -
> Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 ---
> 6 files changed, 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> index 7b9d468c3e52..403d57977ee7 100644
> --- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> @@ -98,7 +98,6 @@ properties:
> maxItems: 1
>
> dmas:
> - maxItems: 4
> items:
> - description: Video layer, plane 0 (RGB or luma)
> - description: Video layer, plane 1 (U/V or U)
> diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> index b548e4723936..c07eb6f2fc8d 100644
> --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> @@ -73,7 +73,6 @@ properties:
> maxItems: 1
>
> clock-names:
> - maxItems: 1
> items:
> - const: fck
>
> diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> index d43791a2dde7..d07eb00b97c8 100644
> --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> @@ -61,7 +61,6 @@ properties:
> - description: low-priority non-secure
> - description: high-priority non-secure
> - description: Secure
> - maxItems: 3
>
> clocks:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> index e543a6123792..b55775e21de6 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> @@ -44,7 +44,6 @@ properties:
> maxItems: 3
>
> clock-names:
> - maxItems: 3
> items:
> - const: hda
> - const: hda2hdmi
> @@ -54,7 +53,6 @@ properties:
> maxItems: 3
>
> reset-names:
> - maxItems: 3
> items:
> - const: hda
> - const: hda2hdmi
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> index 0f078bd0a3e5..22603256ddf8 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> @@ -51,7 +51,6 @@ properties:
> maxItems: 1
>
> phy-names:
> - maxItems: 1
> items:
> - const: usb
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> index 737c1f47b7de..54c361d4a7af 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> @@ -74,11 +74,8 @@ properties:
>
> phys:
> maxItems: 1
> - items:
> - - description: phandle + phy specifier pair.
>
> phy-names:
> - maxItems: 1
> items:
> - const: usb
>
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Jassi Brar <jaswinder.singh@linaro.org>,
Vinod Koul <vkoul@kernel.org>, Mark Brown <broonie@kernel.org>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: Drop redundant maxItems/items
Date: Tue, 22 Dec 2020 09:00:01 +0200 [thread overview]
Message-ID: <X+GZcXJoZ15vgxB2@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20201222040645.1323611-1-robh@kernel.org>
Hi Rob,
Thank you for the patch.
On Mon, Dec 21, 2020 at 09:06:45PM -0700, Rob Herring wrote:
> 'maxItems' equal to the 'items' list length is redundant. 'maxItems' is
> preferred for a single entry while greater than 1 should have an 'items'
> list.
>
> A meta-schema check for this is pending once these existing cases are
> fixed.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jassi Brar <jaswinder.singh@linaro.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: dmaengine@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 1 -
> Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 1 -
> Documentation/devicetree/bindings/mailbox/arm,mhu.yaml | 1 -
> .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 2 --
> Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml | 1 -
> Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 3 ---
> 6 files changed, 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> index 7b9d468c3e52..403d57977ee7 100644
> --- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> @@ -98,7 +98,6 @@ properties:
> maxItems: 1
>
> dmas:
> - maxItems: 4
> items:
> - description: Video layer, plane 0 (RGB or luma)
> - description: Video layer, plane 1 (U/V or U)
> diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> index b548e4723936..c07eb6f2fc8d 100644
> --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml
> @@ -73,7 +73,6 @@ properties:
> maxItems: 1
>
> clock-names:
> - maxItems: 1
> items:
> - const: fck
>
> diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> index d43791a2dde7..d07eb00b97c8 100644
> --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> @@ -61,7 +61,6 @@ properties:
> - description: low-priority non-secure
> - description: high-priority non-secure
> - description: Secure
> - maxItems: 3
>
> clocks:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> index e543a6123792..b55775e21de6 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> @@ -44,7 +44,6 @@ properties:
> maxItems: 3
>
> clock-names:
> - maxItems: 3
> items:
> - const: hda
> - const: hda2hdmi
> @@ -54,7 +53,6 @@ properties:
> maxItems: 3
>
> reset-names:
> - maxItems: 3
> items:
> - const: hda
> - const: hda2hdmi
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> index 0f078bd0a3e5..22603256ddf8 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usb-xhci.yaml
> @@ -51,7 +51,6 @@ properties:
> maxItems: 1
>
> phy-names:
> - maxItems: 1
> items:
> - const: usb
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> index 737c1f47b7de..54c361d4a7af 100644
> --- a/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> +++ b/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml
> @@ -74,11 +74,8 @@ properties:
>
> phys:
> maxItems: 1
> - items:
> - - description: phandle + phy specifier pair.
>
> phy-names:
> - maxItems: 1
> items:
> - const: usb
>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-22 7:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 4:06 [PATCH] dt-bindings: Drop redundant maxItems/items Rob Herring
2020-12-22 4:06 ` Rob Herring
2020-12-22 4:06 ` Rob Herring
2020-12-22 6:39 ` Sam Ravnborg
2020-12-22 6:39 ` Sam Ravnborg
2020-12-23 17:54 ` Rob Herring
2020-12-23 17:54 ` Rob Herring
2020-12-23 17:54 ` Rob Herring
2020-12-23 17:57 ` Laurent Pinchart
2020-12-23 17:57 ` Laurent Pinchart
2020-12-23 17:57 ` Laurent Pinchart
2020-12-23 19:38 ` Sam Ravnborg
2020-12-23 19:38 ` Sam Ravnborg
2020-12-23 19:38 ` Sam Ravnborg
2020-12-22 7:00 ` Laurent Pinchart [this message]
2020-12-22 7:00 ` Laurent Pinchart
2020-12-22 7:00 ` Laurent Pinchart
2020-12-22 16:27 ` Vinod Koul
2020-12-22 16:27 ` Vinod Koul
2020-12-22 16:27 ` Vinod Koul
2020-12-22 16:39 ` Jassi Brar
2020-12-22 16:39 ` Jassi Brar
2020-12-22 16:39 ` Jassi Brar
2020-12-22 17:12 ` Mark Brown
2020-12-22 17:12 ` Mark Brown
2020-12-22 17:12 ` Mark Brown
2020-12-28 14:25 ` Greg Kroah-Hartman
2020-12-28 14:25 ` Greg Kroah-Hartman
2020-12-28 14:25 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+GZcXJoZ15vgxB2@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.