From: "Krzysztof Wilczyński" <kw@linux.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Jonathan Chocron <jonnyc@amazon.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
Zhou Wang <wangzhou1@hisilicon.com>,
Will Deacon <will@kernel.org>,
Robert Richter <rrichter@marvell.com>,
Michal Simek <michal.simek@xilinx.com>,
Toan Le <toan@os.amperecomputing.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jonathan Derrick <jonathan.derrick@intel.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
linux-rockchip@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v6 1/5] PCI: Unify ECAM constants in native PCI Express drivers
Date: Mon, 30 Nov 2020 16:30:28 +0100 [thread overview]
Message-ID: <X8UQFER3uccborBf@rocinante> (raw)
In-Reply-To: <20201130110858.GB16758@e121166-lin.cambridge.arm.com>
Hi Lorenzo!
On 20-11-30 11:08:58, Lorenzo Pieralisi wrote:
[...]
> > Refactor pci_ecam_map_bus() function to use newly added constants so
> > that limits to the bus, device function and offset (now limited to 4K as
> > per the specification) are in place to prevent the defective or
> > malicious caller from supplying incorrect configuration offset and thus
> > targeting the wrong device when accessing extended configuration space.
> > This refactor also allows for the ".bus_shit" initialisers to be dropped
> ^^^^
>
> Nice typo, I'd fix it while applying it though if you don't mind ;-),
> no need to resend it.
Oh doh! Apologies. :)
> Jokes aside, nice piece of work, thanks for that.
>
> > when the user is not using a custom value as a default value will be
> > used as per the PCI Express Specification.
> >
> > Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> > Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
>
> I think Bjorn's reviewed-by still stands so I will apply it.
[...]
Thank you!
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Shawn Lin <shawn.lin@rock-chips.com>,
Paul Mackerras <paulus@samba.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Jonathan Chocron <jonnyc@amazon.com>,
Toan Le <toan@os.amperecomputing.com>,
Will Deacon <will@kernel.org>, Rob Herring <robh@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-rockchip@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
Jonathan Derrick <jonathan.derrick@intel.com>,
linux-pci@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org,
Scott Branden <sbranden@broadcom.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
Robert Richter <rrichter@marvell.com>,
linuxppc-dev@lists.ozlabs.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [PATCH v6 1/5] PCI: Unify ECAM constants in native PCI Express drivers
Date: Mon, 30 Nov 2020 16:30:28 +0100 [thread overview]
Message-ID: <X8UQFER3uccborBf@rocinante> (raw)
In-Reply-To: <20201130110858.GB16758@e121166-lin.cambridge.arm.com>
Hi Lorenzo!
On 20-11-30 11:08:58, Lorenzo Pieralisi wrote:
[...]
> > Refactor pci_ecam_map_bus() function to use newly added constants so
> > that limits to the bus, device function and offset (now limited to 4K as
> > per the specification) are in place to prevent the defective or
> > malicious caller from supplying incorrect configuration offset and thus
> > targeting the wrong device when accessing extended configuration space.
> > This refactor also allows for the ".bus_shit" initialisers to be dropped
> ^^^^
>
> Nice typo, I'd fix it while applying it though if you don't mind ;-),
> no need to resend it.
Oh doh! Apologies. :)
> Jokes aside, nice piece of work, thanks for that.
>
> > when the user is not using a custom value as a default value will be
> > used as per the PCI Express Specification.
> >
> > Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> > Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
>
> I think Bjorn's reviewed-by still stands so I will apply it.
[...]
Thank you!
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Paul Mackerras <paulus@samba.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Jonathan Chocron <jonnyc@amazon.com>,
Toan Le <toan@os.amperecomputing.com>,
Will Deacon <will@kernel.org>, Rob Herring <robh@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Michal Simek <michal.simek@xilinx.com>,
linux-rockchip@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
Jonathan Derrick <jonathan.derrick@intel.com>,
linux-pci@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org,
Scott Branden <sbranden@broadcom.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
Robert Richter <rrichter@marvell.com>,
linuxppc-dev@lists.ozlabs.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [PATCH v6 1/5] PCI: Unify ECAM constants in native PCI Express drivers
Date: Mon, 30 Nov 2020 16:30:28 +0100 [thread overview]
Message-ID: <X8UQFER3uccborBf@rocinante> (raw)
In-Reply-To: <20201130110858.GB16758@e121166-lin.cambridge.arm.com>
Hi Lorenzo!
On 20-11-30 11:08:58, Lorenzo Pieralisi wrote:
[...]
> > Refactor pci_ecam_map_bus() function to use newly added constants so
> > that limits to the bus, device function and offset (now limited to 4K as
> > per the specification) are in place to prevent the defective or
> > malicious caller from supplying incorrect configuration offset and thus
> > targeting the wrong device when accessing extended configuration space.
> > This refactor also allows for the ".bus_shit" initialisers to be dropped
> ^^^^
>
> Nice typo, I'd fix it while applying it though if you don't mind ;-),
> no need to resend it.
Oh doh! Apologies. :)
> Jokes aside, nice piece of work, thanks for that.
>
> > when the user is not using a custom value as a default value will be
> > used as per the PCI Express Specification.
> >
> > Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> > Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
>
> I think Bjorn's reviewed-by still stands so I will apply it.
[...]
Thank you!
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Paul Mackerras <paulus@samba.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Jonathan Chocron <jonnyc@amazon.com>,
Toan Le <toan@os.amperecomputing.com>,
Will Deacon <will@kernel.org>, Rob Herring <robh@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Michal Simek <michal.simek@xilinx.com>,
linux-rockchip@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
Jonathan Derrick <jonathan.derrick@intel.com>,
linux-pci@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org,
Scott Branden <sbranden@broadcom.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
Robert Richter <rrichter@marvell.com>,
linuxppc-dev@lists.ozlabs.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: Re: [PATCH v6 1/5] PCI: Unify ECAM constants in native PCI Express drivers
Date: Mon, 30 Nov 2020 16:30:28 +0100 [thread overview]
Message-ID: <X8UQFER3uccborBf@rocinante> (raw)
In-Reply-To: <20201130110858.GB16758@e121166-lin.cambridge.arm.com>
Hi Lorenzo!
On 20-11-30 11:08:58, Lorenzo Pieralisi wrote:
[...]
> > Refactor pci_ecam_map_bus() function to use newly added constants so
> > that limits to the bus, device function and offset (now limited to 4K as
> > per the specification) are in place to prevent the defective or
> > malicious caller from supplying incorrect configuration offset and thus
> > targeting the wrong device when accessing extended configuration space.
> > This refactor also allows for the ".bus_shit" initialisers to be dropped
> ^^^^
>
> Nice typo, I'd fix it while applying it though if you don't mind ;-),
> no need to resend it.
Oh doh! Apologies. :)
> Jokes aside, nice piece of work, thanks for that.
>
> > when the user is not using a custom value as a default value will be
> > used as per the PCI Express Specification.
> >
> > Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> > Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
>
> I think Bjorn's reviewed-by still stands so I will apply it.
[...]
Thank you!
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-30 15:31 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 23:07 [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` [PATCH v6 1/5] " Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-30 11:08 ` Lorenzo Pieralisi
2020-11-30 11:08 ` Lorenzo Pieralisi
2020-11-30 11:08 ` Lorenzo Pieralisi
2020-11-30 11:08 ` Lorenzo Pieralisi
2020-11-30 15:30 ` Krzysztof Wilczyński [this message]
2020-11-30 15:30 ` Krzysztof Wilczyński
2020-11-30 15:30 ` Krzysztof Wilczyński
2020-11-30 15:30 ` Krzysztof Wilczyński
2020-11-30 18:23 ` Derrick, Jonathan
2020-11-30 18:23 ` Derrick, Jonathan
2020-11-30 18:23 ` Derrick, Jonathan
2020-11-30 18:23 ` Derrick, Jonathan
2020-12-06 20:16 ` Krzysztof Wilczyński
2020-12-06 20:16 ` Krzysztof Wilczyński
2020-12-06 20:16 ` Krzysztof Wilczyński
2020-12-06 20:16 ` Krzysztof Wilczyński
2020-12-07 3:25 ` Florian Fainelli
2020-12-07 3:25 ` Florian Fainelli
2020-12-07 3:25 ` Florian Fainelli
2020-12-07 3:25 ` Florian Fainelli
2020-12-07 20:29 ` Jim Quinlan
2020-12-07 20:29 ` Jim Quinlan
2020-12-07 20:29 ` Jim Quinlan
2020-12-07 20:29 ` Jim Quinlan
2020-11-29 23:07 ` [PATCH v6 2/5] PCI: thunder-pem: Add constant for custom ".bus_shit" initialiser Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` [PATCH v6 3/5] PCI: iproc: Convert to use the new ECAM constants Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-30 9:06 ` David Laight
2020-11-30 9:06 ` David Laight
2020-11-30 9:06 ` David Laight
2020-11-30 9:06 ` David Laight
2020-11-30 17:20 ` Bjorn Helgaas
2020-11-30 17:20 ` Bjorn Helgaas
2020-11-30 17:20 ` Bjorn Helgaas
2020-11-30 17:20 ` Bjorn Helgaas
2020-11-30 18:19 ` Derrick, Jonathan
2020-11-30 18:19 ` Derrick, Jonathan
2020-11-30 18:19 ` Derrick, Jonathan
2020-11-30 18:19 ` Derrick, Jonathan
2020-11-29 23:07 ` [PATCH v6 5/5] PCI: xgene: Removed unused ".bus_shift" initialisers from pci-xgene.c Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-11-29 23:07 ` Krzysztof Wilczyński
2020-12-01 15:34 ` [PATCH v6 0/5] PCI: Unify ECAM constants in native PCI Express drivers Lorenzo Pieralisi
2020-12-01 15:34 ` Lorenzo Pieralisi
2020-12-01 15:34 ` Lorenzo Pieralisi
2020-12-01 15:34 ` Lorenzo Pieralisi
2020-12-08 15:41 ` Michael Walle
2020-12-08 15:41 ` Michael Walle
2020-12-08 15:41 ` Michael Walle
2020-12-08 15:41 ` Michael Walle
2020-12-08 21:06 ` Bjorn Helgaas
2020-12-08 21:06 ` Bjorn Helgaas
2020-12-08 21:06 ` Bjorn Helgaas
2020-12-08 21:06 ` Bjorn Helgaas
2020-12-08 21:11 ` Michael Walle
2020-12-08 21:11 ` Michael Walle
2020-12-08 21:11 ` Michael Walle
2020-12-08 21:11 ` Michael Walle
2020-12-09 12:36 ` Bjorn Helgaas
2020-12-09 12:36 ` Bjorn Helgaas
2020-12-09 12:36 ` Bjorn Helgaas
2020-12-09 12:36 ` Bjorn Helgaas
2020-12-09 13:08 ` Michael Walle
2020-12-09 13:08 ` Michael Walle
2020-12-09 13:08 ` Michael Walle
2020-12-09 13:08 ` Michael Walle
2020-12-09 14:57 ` Bjorn Helgaas
2020-12-09 14:57 ` Bjorn Helgaas
2020-12-09 14:57 ` Bjorn Helgaas
2020-12-09 14:57 ` Bjorn Helgaas
2020-12-09 15:40 ` Michael Walle
2020-12-09 15:40 ` Michael Walle
2020-12-09 15:40 ` Michael Walle
2020-12-09 15:40 ` Michael Walle
2020-12-09 20:29 ` Vladimir Oltean
2020-12-09 20:29 ` Vladimir Oltean
2020-12-09 20:29 ` Vladimir Oltean
2020-12-09 20:29 ` Vladimir Oltean
2020-12-09 20:59 ` Bjorn Helgaas
2020-12-09 20:59 ` Bjorn Helgaas
2020-12-09 20:59 ` Bjorn Helgaas
2020-12-09 20:59 ` Bjorn Helgaas
2020-12-09 21:20 ` Vladimir Oltean
2020-12-09 21:20 ` Vladimir Oltean
2020-12-09 21:20 ` Vladimir Oltean
2020-12-09 21:20 ` Vladimir Oltean
2020-12-09 21:34 ` Bjorn Helgaas
2020-12-09 21:34 ` Bjorn Helgaas
2020-12-09 21:34 ` Bjorn Helgaas
2020-12-09 21:34 ` Bjorn Helgaas
2020-12-09 21:43 ` Vladimir Oltean
2020-12-09 21:43 ` Vladimir Oltean
2020-12-09 21:43 ` Vladimir Oltean
2020-12-09 21:43 ` Vladimir Oltean
2020-12-09 22:05 ` Bjorn Helgaas
2020-12-09 22:05 ` Bjorn Helgaas
2020-12-09 22:05 ` Bjorn Helgaas
2020-12-09 22:05 ` Bjorn Helgaas
2020-12-10 17:38 ` Bjorn Helgaas
2020-12-10 17:38 ` Bjorn Helgaas
2020-12-10 17:38 ` Bjorn Helgaas
2020-12-10 17:38 ` Bjorn Helgaas
2020-12-10 19:58 ` Michael Walle
2020-12-10 19:58 ` Michael Walle
2020-12-10 19:58 ` Michael Walle
2020-12-10 19:58 ` Michael Walle
2020-12-08 16:07 ` Qian Cai
2020-12-08 16:07 ` Qian Cai
2020-12-08 16:07 ` Qian Cai
2020-12-08 16:07 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8UQFER3uccborBf@rocinante \
--to=kw@linux.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=jonathan.derrick@intel.com \
--cc=jonnyc@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michal.simek@xilinx.com \
--cc=mpe@ellerman.id.au \
--cc=nsaenzjulienne@suse.de \
--cc=paulus@samba.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=rrichter@marvell.com \
--cc=sbranden@broadcom.com \
--cc=shawn.lin@rock-chips.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=toan@os.amperecomputing.com \
--cc=wangzhou1@hisilicon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.