From: Nathan Chancellor <nathan@kernel.org> To: Andy Chiu <andy.chiu@sifive.com> Cc: linux-riscv@lists.infradead.org, palmer@dabbelt.com, anup@brainfault.org, atishp@atishpatra.org, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, vineetg@rivosinc.com, greentime.hu@sifive.com, guoren@linux.alibaba.com, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, kernel test robot <lkp@intel.com> Subject: Re: [PATCH -next v14 19/19] riscv: Enable Vector code to be built Date: Wed, 1 Mar 2023 11:00:00 -0700 [thread overview] Message-ID: <Y/+SoGfspjGwlH7g@dev-arch.thelio-3990X> (raw) In-Reply-To: <202302250924.ukv4ZxOc-lkp@intel.com> Hi Andy, On Sat, Feb 25, 2023 at 09:33:30AM +0800, kernel test robot wrote: > Hi Andy, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on next-20230224] > > url: https://github.com/intel-lab-lkp/linux/commits/Andy-Chiu/riscv-Rename-__switch_to_aux-fpu/20230225-011059 > patch link: https://lore.kernel.org/r/20230224170118.16766-20-andy.chiu%40sifive.com > patch subject: [PATCH -next v14 19/19] riscv: Enable Vector code to be built > config: riscv-randconfig-r014-20230222 (https://download.01.org/0day-ci/archive/20230225/202302250924.ukv4ZxOc-lkp@intel.com/config) > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project db89896bbbd2251fff457699635acbbedeead27f) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install riscv cross compiling tool for clang build > # apt-get install binutils-riscv64-linux-gnu > # https://github.com/intel-lab-lkp/linux/commit/cd0ad21a9ef9d63f1eef80fd3b09ae6e0d884ce3 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Andy-Chiu/riscv-Rename-__switch_to_aux-fpu/20230225-011059 > git checkout cd0ad21a9ef9d63f1eef80fd3b09ae6e0d884ce3 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash lib/zstd/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@intel.com> > | Link: https://lore.kernel.org/oe-kbuild-all/202302250924.ukv4ZxOc-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> warning: Invalid size request on a scalable vector; Cannot implicitly convert a scalable size to a fixed-width size in `TypeSize::operator ScalarTy()` Please consider adding the following diff to patch 19 to avoid this issue (see the upstream bug report for more details): diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index eb691dd8ee4f..187cd6c1d8c9 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -423,6 +423,8 @@ config TOOLCHAIN_HAS_V depends on !64BIT || $(cc-option,-mabi=lp64 -march=rv64iv) depends on !32BIT || $(cc-option,-mabi=ilp32 -march=rv32iv) depends on LLD_VERSION >= 140000 || LD_VERSION >= 23800 + # https://github.com/llvm/llvm-project/issues/61096 + depends on !(CC_IS_CLANG && CLANG_VERSION >= 160000 && KASAN) config RISCV_ISA_V bool "VECTOR extension support" --- Additionally, with older versions of clang 15.x and older, I see: arch/riscv/kernel/vector.c:50:3: error: expected expression u32 width = RVV_EXRACT_VL_VS_WIDTH(insn_buf); ^ arch/riscv/kernel/vector.c:52:7: error: use of undeclared identifier 'width' if (width == RVV_VL_VS_WIDTH_8 || width == RVV_VL_VS_WIDTH_16 || ^ arch/riscv/kernel/vector.c:52:37: error: use of undeclared identifier 'width' if (width == RVV_VL_VS_WIDTH_8 || width == RVV_VL_VS_WIDTH_16 || ^ arch/riscv/kernel/vector.c:53:7: error: use of undeclared identifier 'width' width == RVV_VL_VS_WIDTH_32 || width == RVV_VL_VS_WIDTH_64) ^ arch/riscv/kernel/vector.c:53:38: error: use of undeclared identifier 'width' width == RVV_VL_VS_WIDTH_32 || width == RVV_VL_VS_WIDTH_64) ^ arch/riscv/kernel/vector.c:57:3: error: expected expression u32 csr = RVG_EXTRACT_SYSTEM_CSR(insn_buf); ^ arch/riscv/kernel/vector.c:59:8: error: use of undeclared identifier 'csr' if ((csr >= CSR_VSTART && csr <= CSR_VCSR) || ^ arch/riscv/kernel/vector.c:59:29: error: use of undeclared identifier 'csr' if ((csr >= CSR_VSTART && csr <= CSR_VCSR) || ^ arch/riscv/kernel/vector.c:60:8: error: use of undeclared identifier 'csr' (csr >= CSR_VL && csr <= CSR_VLENB)) ^ arch/riscv/kernel/vector.c:60:25: error: use of undeclared identifier 'csr' (csr >= CSR_VL && csr <= CSR_VLENB)) ^ 10 errors generated. which is fixed by: diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c index 585e2c51b28e..8c98db9c0ae1 100644 --- a/arch/riscv/kernel/vector.c +++ b/arch/riscv/kernel/vector.c @@ -46,14 +46,15 @@ static bool insn_is_vector(u32 insn_buf) is_vector = true; break; case RVV_OPCODE_VL: - case RVV_OPCODE_VS: + case RVV_OPCODE_VS: { u32 width = RVV_EXRACT_VL_VS_WIDTH(insn_buf); if (width == RVV_VL_VS_WIDTH_8 || width == RVV_VL_VS_WIDTH_16 || width == RVV_VL_VS_WIDTH_32 || width == RVV_VL_VS_WIDTH_64) is_vector = true; break; - case RVG_OPCODE_SYSTEM: + } + case RVG_OPCODE_SYSTEM: { u32 csr = RVG_EXTRACT_SYSTEM_CSR(insn_buf); if ((csr >= CSR_VSTART && csr <= CSR_VCSR) || @@ -61,6 +62,7 @@ static bool insn_is_vector(u32 insn_buf) is_vector = true; break; } + } return is_vector; } --- Cheers, Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org> To: Andy Chiu <andy.chiu@sifive.com> Cc: linux-riscv@lists.infradead.org, palmer@dabbelt.com, anup@brainfault.org, atishp@atishpatra.org, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, vineetg@rivosinc.com, greentime.hu@sifive.com, guoren@linux.alibaba.com, Paul Walmsley <paul.walmsley@sifive.com>, Albert Ou <aou@eecs.berkeley.edu>, kernel test robot <lkp@intel.com> Subject: Re: [PATCH -next v14 19/19] riscv: Enable Vector code to be built Date: Wed, 1 Mar 2023 11:00:00 -0700 [thread overview] Message-ID: <Y/+SoGfspjGwlH7g@dev-arch.thelio-3990X> (raw) In-Reply-To: <202302250924.ukv4ZxOc-lkp@intel.com> Hi Andy, On Sat, Feb 25, 2023 at 09:33:30AM +0800, kernel test robot wrote: > Hi Andy, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on next-20230224] > > url: https://github.com/intel-lab-lkp/linux/commits/Andy-Chiu/riscv-Rename-__switch_to_aux-fpu/20230225-011059 > patch link: https://lore.kernel.org/r/20230224170118.16766-20-andy.chiu%40sifive.com > patch subject: [PATCH -next v14 19/19] riscv: Enable Vector code to be built > config: riscv-randconfig-r014-20230222 (https://download.01.org/0day-ci/archive/20230225/202302250924.ukv4ZxOc-lkp@intel.com/config) > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project db89896bbbd2251fff457699635acbbedeead27f) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install riscv cross compiling tool for clang build > # apt-get install binutils-riscv64-linux-gnu > # https://github.com/intel-lab-lkp/linux/commit/cd0ad21a9ef9d63f1eef80fd3b09ae6e0d884ce3 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Andy-Chiu/riscv-Rename-__switch_to_aux-fpu/20230225-011059 > git checkout cd0ad21a9ef9d63f1eef80fd3b09ae6e0d884ce3 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash lib/zstd/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@intel.com> > | Link: https://lore.kernel.org/oe-kbuild-all/202302250924.ukv4ZxOc-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> warning: Invalid size request on a scalable vector; Cannot implicitly convert a scalable size to a fixed-width size in `TypeSize::operator ScalarTy()` Please consider adding the following diff to patch 19 to avoid this issue (see the upstream bug report for more details): diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index eb691dd8ee4f..187cd6c1d8c9 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -423,6 +423,8 @@ config TOOLCHAIN_HAS_V depends on !64BIT || $(cc-option,-mabi=lp64 -march=rv64iv) depends on !32BIT || $(cc-option,-mabi=ilp32 -march=rv32iv) depends on LLD_VERSION >= 140000 || LD_VERSION >= 23800 + # https://github.com/llvm/llvm-project/issues/61096 + depends on !(CC_IS_CLANG && CLANG_VERSION >= 160000 && KASAN) config RISCV_ISA_V bool "VECTOR extension support" --- Additionally, with older versions of clang 15.x and older, I see: arch/riscv/kernel/vector.c:50:3: error: expected expression u32 width = RVV_EXRACT_VL_VS_WIDTH(insn_buf); ^ arch/riscv/kernel/vector.c:52:7: error: use of undeclared identifier 'width' if (width == RVV_VL_VS_WIDTH_8 || width == RVV_VL_VS_WIDTH_16 || ^ arch/riscv/kernel/vector.c:52:37: error: use of undeclared identifier 'width' if (width == RVV_VL_VS_WIDTH_8 || width == RVV_VL_VS_WIDTH_16 || ^ arch/riscv/kernel/vector.c:53:7: error: use of undeclared identifier 'width' width == RVV_VL_VS_WIDTH_32 || width == RVV_VL_VS_WIDTH_64) ^ arch/riscv/kernel/vector.c:53:38: error: use of undeclared identifier 'width' width == RVV_VL_VS_WIDTH_32 || width == RVV_VL_VS_WIDTH_64) ^ arch/riscv/kernel/vector.c:57:3: error: expected expression u32 csr = RVG_EXTRACT_SYSTEM_CSR(insn_buf); ^ arch/riscv/kernel/vector.c:59:8: error: use of undeclared identifier 'csr' if ((csr >= CSR_VSTART && csr <= CSR_VCSR) || ^ arch/riscv/kernel/vector.c:59:29: error: use of undeclared identifier 'csr' if ((csr >= CSR_VSTART && csr <= CSR_VCSR) || ^ arch/riscv/kernel/vector.c:60:8: error: use of undeclared identifier 'csr' (csr >= CSR_VL && csr <= CSR_VLENB)) ^ arch/riscv/kernel/vector.c:60:25: error: use of undeclared identifier 'csr' (csr >= CSR_VL && csr <= CSR_VLENB)) ^ 10 errors generated. which is fixed by: diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c index 585e2c51b28e..8c98db9c0ae1 100644 --- a/arch/riscv/kernel/vector.c +++ b/arch/riscv/kernel/vector.c @@ -46,14 +46,15 @@ static bool insn_is_vector(u32 insn_buf) is_vector = true; break; case RVV_OPCODE_VL: - case RVV_OPCODE_VS: + case RVV_OPCODE_VS: { u32 width = RVV_EXRACT_VL_VS_WIDTH(insn_buf); if (width == RVV_VL_VS_WIDTH_8 || width == RVV_VL_VS_WIDTH_16 || width == RVV_VL_VS_WIDTH_32 || width == RVV_VL_VS_WIDTH_64) is_vector = true; break; - case RVG_OPCODE_SYSTEM: + } + case RVG_OPCODE_SYSTEM: { u32 csr = RVG_EXTRACT_SYSTEM_CSR(insn_buf); if ((csr >= CSR_VSTART && csr <= CSR_VCSR) || @@ -61,6 +62,7 @@ static bool insn_is_vector(u32 insn_buf) is_vector = true; break; } + } return is_vector; } --- Cheers, Nathan _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-03-01 18:00 UTC|newest] Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-24 17:00 [PATCH -next v14 00/19] riscv: Add vector ISA support Andy Chiu 2023-02-24 17:00 ` Andy Chiu 2023-02-24 17:01 ` [PATCH -next v14 01/19] riscv: Rename __switch_to_aux -> fpu Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-02-28 21:56 ` Conor Dooley 2023-02-28 21:56 ` Conor Dooley 2023-02-24 17:01 ` [PATCH -next v14 02/19] riscv: Extending cpufeature.c to detect V-extension Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-02-28 22:07 ` Conor Dooley 2023-02-28 22:07 ` Conor Dooley 2023-02-24 17:01 ` [PATCH -next v14 03/19] riscv: Add new csr defines related to vector extension Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-02-28 22:31 ` Conor Dooley 2023-02-28 22:31 ` Conor Dooley 2023-02-24 17:01 ` [PATCH -next v14 04/19] riscv: Clear vector regfile on bootup Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-02-28 22:17 ` Conor Dooley 2023-02-28 22:17 ` Conor Dooley 2023-02-24 17:01 ` [PATCH -next v14 05/19] riscv: Disable Vector Instructions for kernel itself Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-02-24 17:01 ` [PATCH -next v14 06/19] riscv: Introduce Vector enable/disable helpers Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-02-28 22:36 ` Conor Dooley 2023-02-28 22:36 ` Conor Dooley 2023-02-24 17:01 ` [PATCH -next v14 07/19] riscv: Introduce riscv_v_vsize to record size of Vector context Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-02-28 22:38 ` Conor Dooley 2023-02-28 22:38 ` Conor Dooley 2023-02-24 17:01 ` [PATCH -next v14 08/19] riscv: Introduce struct/helpers to save/restore per-task Vector state Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-02-28 23:00 ` Conor Dooley 2023-02-28 23:00 ` Conor Dooley 2023-03-15 4:00 ` Andy Chiu 2023-03-15 4:00 ` Andy Chiu 2023-03-02 11:12 ` Björn Töpel 2023-03-02 11:12 ` Björn Töpel 2023-03-15 4:05 ` Andy Chiu 2023-03-15 4:05 ` Andy Chiu 2023-02-24 17:01 ` [PATCH -next v14 09/19] riscv: Add task switch support for vector Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-03-01 16:41 ` Conor Dooley 2023-03-01 16:41 ` Conor Dooley 2023-03-01 16:57 ` Björn Töpel 2023-03-01 16:57 ` Björn Töpel 2023-03-02 11:07 ` Björn Töpel 2023-03-02 11:07 ` Björn Töpel 2023-02-24 17:01 ` [PATCH -next v14 10/19] riscv: Allocate user's vector context in the first-use trap Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-03-01 16:53 ` Conor Dooley 2023-03-01 16:53 ` Conor Dooley 2023-02-24 17:01 ` [PATCH -next v14 11/19] riscv: Add ptrace vector support Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-03-01 17:29 ` Conor Dooley 2023-03-01 17:29 ` Conor Dooley 2023-03-02 11:27 ` Björn Töpel 2023-03-02 11:27 ` Björn Töpel 2023-03-14 10:39 ` Andy Chiu 2023-03-14 10:39 ` Andy Chiu 2023-03-14 10:44 ` Conor Dooley 2023-03-14 10:44 ` Conor Dooley 2023-02-24 17:01 ` [PATCH -next v14 12/19] riscv: signal: check fp-reserved words unconditionally Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-03-01 17:56 ` Conor Dooley 2023-03-01 17:56 ` Conor Dooley 2023-02-24 17:01 ` [PATCH -next v14 13/19] riscv: signal: Add sigcontext save/restore for vector Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-03-01 18:27 ` Conor Dooley 2023-03-01 18:27 ` Conor Dooley 2023-03-02 12:42 ` Björn Töpel 2023-03-02 12:42 ` Björn Töpel 2023-02-24 17:01 ` [PATCH -next v14 14/19] riscv: signal: Report signal frame size to userspace via auxv Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-03-01 19:21 ` Conor Dooley 2023-03-01 19:21 ` Conor Dooley 2023-03-02 12:47 ` Björn Töpel 2023-03-02 12:47 ` Björn Töpel 2023-02-24 17:01 ` [PATCH -next v14 15/19] riscv: signal: validate altstack to reflect Vector Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-03-01 21:00 ` Conor Dooley 2023-03-01 21:00 ` Conor Dooley 2023-02-24 17:01 ` [PATCH -next v14 16/19] riscv: prevent stack corruption by reserving task_pt_regs(p) early Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-03-01 21:34 ` Conor Dooley 2023-03-01 21:34 ` Conor Dooley 2023-02-24 17:01 ` [PATCH -next v14 17/19] riscv: kvm: Add V extension to KVM ISA Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-03-01 21:38 ` Conor Dooley 2023-03-01 21:38 ` Conor Dooley 2023-02-24 17:01 ` [PATCH -next v14 18/19] riscv: KVM: Add vector lazy save/restore support Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-02-24 17:01 ` [PATCH -next v14 19/19] riscv: Enable Vector code to be built Andy Chiu 2023-02-24 17:01 ` Andy Chiu 2023-02-24 21:35 ` kernel test robot 2023-02-24 21:35 ` kernel test robot 2023-02-25 1:33 ` kernel test robot 2023-02-25 1:33 ` kernel test robot 2023-03-01 18:00 ` Nathan Chancellor [this message] 2023-03-01 18:00 ` Nathan Chancellor 2023-03-01 18:44 ` Conor Dooley 2023-03-01 18:44 ` Conor Dooley 2023-02-25 8:28 ` kernel test robot 2023-02-25 8:28 ` kernel test robot 2023-02-27 10:18 ` Conor Dooley 2023-02-27 10:18 ` Conor Dooley 2023-02-27 13:40 ` Darius Rad 2023-02-27 13:40 ` Darius Rad 2023-02-27 13:58 ` Conor Dooley 2023-02-27 13:58 ` Conor Dooley
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y/+SoGfspjGwlH7g@dev-arch.thelio-3990X \ --to=nathan@kernel.org \ --cc=andy.chiu@sifive.com \ --cc=anup@brainfault.org \ --cc=aou@eecs.berkeley.edu \ --cc=atishp@atishpatra.org \ --cc=greentime.hu@sifive.com \ --cc=guoren@linux.alibaba.com \ --cc=kvm-riscv@lists.infradead.org \ --cc=kvm@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=lkp@intel.com \ --cc=llvm@lists.linux.dev \ --cc=oe-kbuild-all@lists.linux.dev \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=vineetg@rivosinc.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.