From: Ming Lei <ming.lei@redhat.com>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: kernel test robot <yujie.liu@intel.com>,
lkp@lists.01.org, lkp@intel.com, Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
ying.huang@intel.com, feng.tang@intel.com,
zhengjun.xing@linux.intel.com, fengwei.yin@intel.com,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [blk] 8c5035dfbb: fio.read_iops -10.6% regression
Date: Sun, 9 Oct 2022 16:43:04 +0800 [thread overview]
Message-ID: <Y0KJmODYOh83OtGa@T590> (raw)
In-Reply-To: <d5279fc2-38b3-6d20-4404-604d5c7277e2@huaweicloud.com>
On Sat, Oct 08, 2022 at 04:00:10PM +0800, Yu Kuai wrote:
> Hi,
>
> 在 2022/10/08 10:50, kernel test robot 写道:
> > Greeting,
> >
> > FYI, we noticed a -10.6% regression of fio.read_iops due to commit:
>
> I don't know how this is working but I'm *sure* this commit won't affect
Looks it is wrong to move
wbt_set_write_cache(q, test_bit(QUEUE_FLAG_WC, &q->queue_flags));
before rq_qos_add() in wbt_init().
Without adding wbt rq_qos, wbt_set_write_cache is just a nop.
thanks,
Ming
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: lkp@lists.01.org
Subject: Re: [blk] 8c5035dfbb: fio.read_iops -10.6% regression
Date: Sun, 09 Oct 2022 16:43:04 +0800 [thread overview]
Message-ID: <Y0KJmODYOh83OtGa@T590> (raw)
In-Reply-To: <d5279fc2-38b3-6d20-4404-604d5c7277e2@huaweicloud.com>
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
On Sat, Oct 08, 2022 at 04:00:10PM +0800, Yu Kuai wrote:
> Hi,
>
> 在 2022/10/08 10:50, kernel test robot 写道:
> > Greeting,
> >
> > FYI, we noticed a -10.6% regression of fio.read_iops due to commit:
>
> I don't know how this is working but I'm *sure* this commit won't affect
Looks it is wrong to move
wbt_set_write_cache(q, test_bit(QUEUE_FLAG_WC, &q->queue_flags));
before rq_qos_add() in wbt_init().
Without adding wbt rq_qos, wbt_set_write_cache is just a nop.
thanks,
Ming
next prev parent reply other threads:[~2022-10-09 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 2:50 [blk] 8c5035dfbb: fio.read_iops -10.6% regression kernel test robot
2022-10-08 2:50 ` kernel test robot
2022-10-08 8:00 ` Yu Kuai
2022-10-08 8:00 ` Yu Kuai
2022-10-09 5:47 ` [LKP] " Yin Fengwei
2022-10-09 5:47 ` Yin Fengwei
2022-10-09 6:14 ` [LKP] " Yu Kuai
2022-10-09 6:14 ` Yu Kuai
2022-10-09 8:43 ` Ming Lei [this message]
2022-10-09 8:43 ` Ming Lei
2022-10-09 9:32 ` Yu Kuai
2022-10-09 9:32 ` Yu Kuai
2022-10-13 7:42 ` Feng Tang
2022-10-13 7:42 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0KJmODYOh83OtGa@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=feng.tang@intel.com \
--cc=fengwei.yin@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=ying.huang@intel.com \
--cc=yujie.liu@intel.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.