From: Daniel Thompson <daniel.thompson@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 4/7] gpiolib: of: add a quirk for reset line for Marvell NFC controller
Date: Wed, 12 Oct 2022 11:29:02 +0100 [thread overview]
Message-ID: <Y0aW7vDxfNa/8bAk@maple.lan> (raw)
In-Reply-To: <20221011-gpiolib-quirks-v1-4-e01d9d3e7b29@gmail.com>
On Tue, Oct 11, 2022 at 03:19:32PM -0700, Dmitry Torokhov wrote:
> The controller is using non-standard "reset-n-io" name for its reset
> gpio property, whereas gpiod API expects "<name>-gpios". Add a quirk
> so that gpiod API will still work on unmodified DTSes.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
How/when has/will the DT bindings documentation for this hardware be
updated to describe the new bindings?
Delivering the quirks ahead of driver updates is great for avoiding
merge conflicts but it also conceals the rename from reviewers so
risks neglecting to update the bindings.
Other than that:
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
> ---
> drivers/gpio/gpiolib-of.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 576f2f0c3432..7d4193fe36e5 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -383,6 +383,16 @@ static struct gpio_desc *of_find_gpio_rename(struct device_node *np,
> #if IS_ENABLED(CONFIG_MFD_ARIZONA)
> { "wlf,reset", NULL, NULL },
> #endif
> +
> +#if IS_ENABLED(CONFIG_NFC_MRVL_I2C)
> + { "reset", "reset-n-io", "marvell,nfc-i2c" },
> +#endif
> +#if IS_ENABLED(CONFIG_NFC_MRVL_SPI)
> + { "reset", "reset-n-io", "marvell,nfc-spi" },
> +#endif
> +#if IS_ENABLED(CONFIG_NFC_MRVL_UART)
> + { "reset", "reset-n-io", "marvell,nfc-uart" },
> +#endif
> #if !IS_ENABLED(CONFIG_PCI_LANTIQ)
> /* MIPS Lantiq PCI */
> { "reset", "gpios-reset", "lantiq,pci-xway" },
>
> --
> b4 0.11.0-dev-5166b
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 4/7] gpiolib: of: add a quirk for reset line for Marvell NFC controller
Date: Wed, 12 Oct 2022 11:29:02 +0100 [thread overview]
Message-ID: <Y0aW7vDxfNa/8bAk@maple.lan> (raw)
In-Reply-To: <20221011-gpiolib-quirks-v1-4-e01d9d3e7b29@gmail.com>
On Tue, Oct 11, 2022 at 03:19:32PM -0700, Dmitry Torokhov wrote:
> The controller is using non-standard "reset-n-io" name for its reset
> gpio property, whereas gpiod API expects "<name>-gpios". Add a quirk
> so that gpiod API will still work on unmodified DTSes.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
How/when has/will the DT bindings documentation for this hardware be
updated to describe the new bindings?
Delivering the quirks ahead of driver updates is great for avoiding
merge conflicts but it also conceals the rename from reviewers so
risks neglecting to update the bindings.
Other than that:
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
> ---
> drivers/gpio/gpiolib-of.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 576f2f0c3432..7d4193fe36e5 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -383,6 +383,16 @@ static struct gpio_desc *of_find_gpio_rename(struct device_node *np,
> #if IS_ENABLED(CONFIG_MFD_ARIZONA)
> { "wlf,reset", NULL, NULL },
> #endif
> +
> +#if IS_ENABLED(CONFIG_NFC_MRVL_I2C)
> + { "reset", "reset-n-io", "marvell,nfc-i2c" },
> +#endif
> +#if IS_ENABLED(CONFIG_NFC_MRVL_SPI)
> + { "reset", "reset-n-io", "marvell,nfc-spi" },
> +#endif
> +#if IS_ENABLED(CONFIG_NFC_MRVL_UART)
> + { "reset", "reset-n-io", "marvell,nfc-uart" },
> +#endif
> #if !IS_ENABLED(CONFIG_PCI_LANTIQ)
> /* MIPS Lantiq PCI */
> { "reset", "gpios-reset", "lantiq,pci-xway" },
>
> --
> b4 0.11.0-dev-5166b
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-12 10:29 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 22:19 [PATCH 0/7] gpiolib: more quirks to handle legacy names Dmitry Torokhov
2022-10-11 22:19 ` Dmitry Torokhov
2022-10-11 22:19 ` [PATCH 1/7] gpiolib: of: add a quirk for legacy names in Mediatek mt2701-cs42448 Dmitry Torokhov
2022-10-11 22:19 ` Dmitry Torokhov
2022-10-12 10:14 ` Daniel Thompson
2022-10-12 10:14 ` Daniel Thompson
2022-10-17 10:07 ` Linus Walleij
2022-10-17 10:07 ` Linus Walleij
2022-10-11 22:19 ` [PATCH 2/7] gpiolib: of: consolidate simple renames into a single quirk Dmitry Torokhov
2022-10-11 22:19 ` Dmitry Torokhov
2022-10-12 10:12 ` Daniel Thompson
2022-10-12 10:12 ` Daniel Thompson
2022-10-12 19:20 ` Dmitry Torokhov
2022-10-12 19:20 ` Dmitry Torokhov
2022-10-13 12:59 ` Daniel Thompson
2022-10-13 12:59 ` Daniel Thompson
2022-10-11 22:19 ` [PATCH 3/7] gpiolib: of: add quirk for locating reset lines with legacy bindings Dmitry Torokhov
2022-10-11 22:19 ` Dmitry Torokhov
2022-10-12 10:19 ` Daniel Thompson
2022-10-12 10:19 ` Daniel Thompson
2022-10-11 22:19 ` [PATCH 4/7] gpiolib: of: add a quirk for reset line for Marvell NFC controller Dmitry Torokhov
2022-10-11 22:19 ` Dmitry Torokhov
2022-10-12 10:29 ` Daniel Thompson [this message]
2022-10-12 10:29 ` Daniel Thompson
2022-10-12 18:45 ` Dmitry Torokhov
2022-10-12 18:45 ` Dmitry Torokhov
2022-10-12 18:50 ` Daniel Thompson
2022-10-12 18:50 ` Daniel Thompson
2022-10-12 18:55 ` Dmitry Torokhov
2022-10-12 18:55 ` Dmitry Torokhov
2022-10-13 13:00 ` Daniel Thompson
2022-10-13 13:00 ` Daniel Thompson
2022-10-11 22:19 ` [PATCH 5/7] gpiolib: of: add a quirk for reset line for Cirrus CS42L56 codec Dmitry Torokhov
2022-10-11 22:19 ` Dmitry Torokhov
2022-10-12 10:30 ` Daniel Thompson
2022-10-12 10:30 ` Daniel Thompson
2022-10-11 22:19 ` [PATCH 6/7] gpiolib: of: factor out code overriding gpio line polarity Dmitry Torokhov
2022-10-11 22:19 ` Dmitry Torokhov
2022-10-12 11:10 ` Andy Shevchenko
2022-10-12 11:10 ` Andy Shevchenko
2022-10-12 15:30 ` Dmitry Torokhov
2022-10-12 15:30 ` Dmitry Torokhov
2022-10-11 22:19 ` [PATCH 7/7] gpiolib: of: add quirk for phy reset polarity for Freescale Ethernet Dmitry Torokhov
2022-10-11 22:19 ` Dmitry Torokhov
2022-10-12 6:14 ` Alexander Stein
2022-10-12 6:14 ` Alexander Stein
2022-10-12 15:25 ` Dmitry Torokhov
2022-10-12 15:25 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0aW7vDxfNa/8bAk@maple.lan \
--to=daniel.thompson@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.