From: Al Viro <viro@zeniv.linux.org.uk>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: au88x0: use explicitly signed char
Date: Mon, 24 Oct 2022 22:11:36 +0100 [thread overview]
Message-ID: <Y1b/iNMncyKI/W5c@ZenIV> (raw)
In-Reply-To: <20221024162929.536004-1-Jason@zx2c4.com>
On Mon, Oct 24, 2022 at 06:29:29PM +0200, Jason A. Donenfeld wrote:
> With char becoming unsigned by default, and with `char` alone being
> ambiguous and based on architecture, signed chars need to be marked
> explicitly as such. This fixes warnings like:
It might make sparse to STFU, but it does *not* resolve the underlying
issue:
vortex_adb_checkinout() returns a number in range of 0..31 on success
and -ENOMEM on failure. Quite a few callers don't bother to check...
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: au88x0: use explicitly signed char
Date: Mon, 24 Oct 2022 22:11:36 +0100 [thread overview]
Message-ID: <Y1b/iNMncyKI/W5c@ZenIV> (raw)
In-Reply-To: <20221024162929.536004-1-Jason@zx2c4.com>
On Mon, Oct 24, 2022 at 06:29:29PM +0200, Jason A. Donenfeld wrote:
> With char becoming unsigned by default, and with `char` alone being
> ambiguous and based on architecture, signed chars need to be marked
> explicitly as such. This fixes warnings like:
It might make sparse to STFU, but it does *not* resolve the underlying
issue:
vortex_adb_checkinout() returns a number in range of 0..31 on success
and -ENOMEM on failure. Quite a few callers don't bother to check...
next prev parent reply other threads:[~2022-10-24 21:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 16:29 [PATCH] ALSA: au88x0: use explicitly signed char Jason A. Donenfeld
2022-10-24 16:29 ` Jason A. Donenfeld
2022-10-24 21:11 ` Al Viro [this message]
2022-10-24 21:11 ` Al Viro
2022-10-24 23:59 ` Jason A. Donenfeld
2022-10-24 23:59 ` Jason A. Donenfeld
2022-10-25 6:21 ` Takashi Iwai
2022-10-25 6:21 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1b/iNMncyKI/W5c@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=Jason@zx2c4.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.