From: Minchan Kim <minchan@kernel.org> To: Petr Vorel <pvorel@suse.cz> Cc: ltp@lists.linux.it, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Nitin Gupta <ngupta@vflare.org>, Sergey Senozhatsky <senozhatsky@chromium.org>, Jens Axboe <axboe@kernel.dk>, OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>, Martin Doucha <mdoucha@suse.cz>, Yang Xu <xuyang2018.jy@fujitsu.com> Subject: Re: [PATCH 0/1] Possible bug in zram on ppc64le on vfat Date: Mon, 7 Nov 2022 13:25:16 -0800 [thread overview] Message-ID: <Y2l3vJb1y2Jynf50@google.com> (raw) In-Reply-To: <20221107191136.18048-1-pvorel@suse.cz> On Mon, Nov 07, 2022 at 08:11:35PM +0100, Petr Vorel wrote: > Hi all, > > following bug is trying to workaround an error on ppc64le, where > zram01.sh LTP test (there is also kernel selftest > tools/testing/selftests/zram/zram01.sh, but LTP test got further > updates) has often mem_used_total 0 although zram is already filled. Hi, Petr, Is it happening on only ppc64le? Is it a new regression? What kernel version did you use? Actually, mem_used_total indicates how many *physical memory* were currently used to keep original data size. However, if the test data is repeated pattern of unsigned long (https://github.com/torvalds/linux/blob/master/drivers/block/zram/zram_drv.c#L210) zram doesn't allocate the physical memory but just mark the unsigned long's value in meta area for decompression later. Not sure you hit the this case. > > Patch tries to repeatedly read /sys/block/zram*/mm_stat for 1 sec, > waiting for mem_used_total > 0. The question if this is expected and > should be workarounded or a bug which should be fixed. > > REPRODUCE THE ISSUE > Quickest way to install only zram tests and their dependencies: > make autotools && ./configure && for i in testcases/lib/ testcases/kernel/device-drivers/zram/; do cd $i && make -j$(getconf _NPROCESSORS_ONLN) && make install && cd -; done > > Run the test (only on vfat) > PATH="/opt/ltp/testcases/bin:$PATH" LTP_SINGLE_FS_TYPE=vfat zram01.sh > > Petr Vorel (1): > zram01.sh: Workaround division by 0 on vfat on ppc64le > > .../kernel/device-drivers/zram/zram01.sh | 27 +++++++++++++++++-- > 1 file changed, 25 insertions(+), 2 deletions(-) > > -- > 2.38.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org> To: Petr Vorel <pvorel@suse.cz> Cc: Jens Axboe <axboe@kernel.dk>, OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Sergey Senozhatsky <senozhatsky@chromium.org>, ltp@lists.linux.it, linux-kselftest@vger.kernel.org, Nitin Gupta <ngupta@vflare.org> Subject: Re: [LTP] [PATCH 0/1] Possible bug in zram on ppc64le on vfat Date: Mon, 7 Nov 2022 13:25:16 -0800 [thread overview] Message-ID: <Y2l3vJb1y2Jynf50@google.com> (raw) In-Reply-To: <20221107191136.18048-1-pvorel@suse.cz> On Mon, Nov 07, 2022 at 08:11:35PM +0100, Petr Vorel wrote: > Hi all, > > following bug is trying to workaround an error on ppc64le, where > zram01.sh LTP test (there is also kernel selftest > tools/testing/selftests/zram/zram01.sh, but LTP test got further > updates) has often mem_used_total 0 although zram is already filled. Hi, Petr, Is it happening on only ppc64le? Is it a new regression? What kernel version did you use? Actually, mem_used_total indicates how many *physical memory* were currently used to keep original data size. However, if the test data is repeated pattern of unsigned long (https://github.com/torvalds/linux/blob/master/drivers/block/zram/zram_drv.c#L210) zram doesn't allocate the physical memory but just mark the unsigned long's value in meta area for decompression later. Not sure you hit the this case. > > Patch tries to repeatedly read /sys/block/zram*/mm_stat for 1 sec, > waiting for mem_used_total > 0. The question if this is expected and > should be workarounded or a bug which should be fixed. > > REPRODUCE THE ISSUE > Quickest way to install only zram tests and their dependencies: > make autotools && ./configure && for i in testcases/lib/ testcases/kernel/device-drivers/zram/; do cd $i && make -j$(getconf _NPROCESSORS_ONLN) && make install && cd -; done > > Run the test (only on vfat) > PATH="/opt/ltp/testcases/bin:$PATH" LTP_SINGLE_FS_TYPE=vfat zram01.sh > > Petr Vorel (1): > zram01.sh: Workaround division by 0 on vfat on ppc64le > > .../kernel/device-drivers/zram/zram01.sh | 27 +++++++++++++++++-- > 1 file changed, 25 insertions(+), 2 deletions(-) > > -- > 2.38.0 > -- Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-11-07 21:25 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-07 19:11 [PATCH 0/1] Possible bug in zram on ppc64le on vfat Petr Vorel 2022-11-07 19:11 ` [LTP] " Petr Vorel 2022-11-07 19:11 ` [PATCH 1/1] zram01.sh: Workaround division by 0 on vfat on ppc64le Petr Vorel 2022-11-07 19:11 ` [LTP] " Petr Vorel 2022-11-21 7:14 ` Li Wang 2022-11-21 8:59 ` Petr Vorel 2022-11-21 8:59 ` Petr Vorel 2023-09-18 9:38 ` Richard Palethorpe 2022-11-07 21:25 ` Minchan Kim [this message] 2022-11-07 21:25 ` [LTP] [PATCH 0/1] Possible bug in zram on ppc64le on vfat Minchan Kim 2022-11-07 21:47 ` Petr Vorel 2022-11-07 21:47 ` [LTP] " Petr Vorel 2022-11-07 22:42 ` Petr Vorel 2022-11-07 22:42 ` [LTP] " Petr Vorel 2022-11-08 1:05 ` Sergey Senozhatsky 2022-11-08 1:05 ` [LTP] " Sergey Senozhatsky 2022-11-09 22:08 ` Petr Vorel 2022-11-09 22:08 ` [LTP] " Petr Vorel 2022-11-10 23:04 ` Minchan Kim 2022-11-10 23:04 ` [LTP] " Minchan Kim 2022-11-11 9:29 ` Petr Vorel 2022-11-11 9:29 ` [LTP] " Petr Vorel 2022-11-10 14:29 ` Martin Doucha 2022-11-10 14:29 ` [LTP] " Martin Doucha 2022-11-11 0:48 ` Sergey Senozhatsky 2022-11-11 0:48 ` [LTP] " Sergey Senozhatsky 2022-11-21 9:41 ` Petr Vorel 2022-11-21 9:41 ` [LTP] " Petr Vorel 2022-11-22 14:56 ` Martin Doucha 2022-11-22 14:56 ` Martin Doucha 2022-11-22 15:07 ` Petr Vorel 2022-11-22 15:07 ` [LTP] " Petr Vorel 2022-11-29 4:38 ` Sergey Senozhatsky 2022-11-29 4:38 ` [LTP] " Sergey Senozhatsky 2023-05-02 15:23 ` Martin Doucha 2023-05-02 15:23 ` [LTP] " Martin Doucha 2022-11-11 9:18 ` Petr Vorel 2022-11-11 9:18 ` [LTP] " Petr Vorel 2023-08-04 6:37 ` Ian Wienand 2023-08-04 6:37 ` Ian Wienand 2023-08-07 4:44 ` Ian Wienand 2023-08-07 4:44 ` [LTP] " Ian Wienand 2023-08-07 5:19 ` Sergey Senozhatsky 2023-08-07 5:19 ` [LTP] " Sergey Senozhatsky
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y2l3vJb1y2Jynf50@google.com \ --to=minchan@kernel.org \ --cc=axboe@kernel.dk \ --cc=hirofumi@mail.parknet.co.jp \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=ltp@lists.linux.it \ --cc=mdoucha@suse.cz \ --cc=ngupta@vflare.org \ --cc=pvorel@suse.cz \ --cc=senozhatsky@chromium.org \ --cc=xuyang2018.jy@fujitsu.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.