From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Albert Zhou <albert.zhou.50@gmail.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, lukas@wunner.de
Subject: Re: [PATCH v2 1/2] pci: hotplug: add dependency info to Kconfig
Date: Mon, 14 Nov 2022 12:37:48 +0200 [thread overview]
Message-ID: <Y3IafGm+ewR5LJL9@black.fi.intel.com> (raw)
In-Reply-To: <20221113112811.22266-2-albert.zhou.50@gmail.com>
On Sun, Nov 13, 2022 at 10:28:10PM +1100, Albert Zhou wrote:
> Thunderbolt and USB4 PCI cards require the hotplug feature. This is now
> recorded in the help message for HOTPLUG_PCI. Further, HOTPLUG_PCI is
> defaulted to Y if USB4 is selected.
>
> Signed-off-by: Albert Zhou <albert.zhou.50@gmail.com>
> ---
> drivers/pci/hotplug/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/Kconfig b/drivers/pci/hotplug/Kconfig
> index 840a84bb5ee2..06cc373834f5 100644
> --- a/drivers/pci/hotplug/Kconfig
> +++ b/drivers/pci/hotplug/Kconfig
> @@ -6,10 +6,12 @@
> menuconfig HOTPLUG_PCI
> bool "Support for PCI Hotplug"
> depends on PCI && SYSFS
> + default y if USB4
> help
> Say Y here if you have a motherboard with a PCI Hotplug controller.
> This allows you to add and remove PCI cards while the machine is
> - powered up and running.
> + powered up and running. Thunderbolt and USB4 PCI cards require
> + Hotplug.
I would not say they "require" this. PCIe is completely optional in USB4
systems and it is perfectly fine to have host controllers or
add-in-cards that don't have a single PCIe adapter.
Not objeting the patch, though. For Linux I guess it makes sense to have
this like what you are suggesting. Just perhaps changing the wordirng
;-)
next prev parent reply other threads:[~2022-11-14 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 11:28 [PATCH v2 0/2] add hotplug depedency info Albert Zhou
2022-11-13 11:28 ` [PATCH v2 1/2] pci: hotplug: add dependency info to Kconfig Albert Zhou
2022-11-14 10:37 ` Mika Westerberg [this message]
2022-11-15 1:38 ` Albert Zhou
2022-11-15 7:23 ` Mika Westerberg
2022-11-13 11:28 ` [PATCH v2 2/2] pci: pcie: " Albert Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3IafGm+ewR5LJL9@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=albert.zhou.50@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.