From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Albert Zhou <albert.zhou.50@gmail.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, lukas@wunner.de
Subject: Re: [PATCH v2 1/2] pci: hotplug: add dependency info to Kconfig
Date: Tue, 15 Nov 2022 09:23:32 +0200 [thread overview]
Message-ID: <Y3M+dMJyvnS0uKZ2@black.fi.intel.com> (raw)
In-Reply-To: <213e1035-b3c7-3d4c-5691-fd936a762745@gmail.com>
Hi,
On Tue, Nov 15, 2022 at 12:38:11PM +1100, Albert Zhou wrote:
> On 14/11/22 21:37, Mika Westerberg wrote:
> > > + default y if USB4
> > > help
> > > Say Y here if you have a motherboard with a PCI Hotplug controller.
> > > This allows you to add and remove PCI cards while the machine is
> > > - powered up and running.
> > > + powered up and running. Thunderbolt and USB4 PCI cards require
> > > + Hotplug.
> > I would not say they "require" this. PCIe is completely optional in USB4
> > systems and it is perfectly fine to have host controllers or
> > add-in-cards that don't have a single PCIe adapter.
> >
> > Not objeting the patch, though. For Linux I guess it makes sense to have
> > this like what you are suggesting. Just perhaps changing the wordirng
> > 😉
>
> How about “Thunderbolt and USB4 use Hotplug”
Or
"Thunderbolt/USB4 PCIe tunneling needs Native PCIe Hotplug to be enabled"
> Do you agree with the “default y if USB4” for PCIEPORTBUS, HOTPLUG_PCI_PCIE, HOTPLUG_PCI.
Yes, I think for Linux perspective it makes sense to have them enabled
by default.
next prev parent reply other threads:[~2022-11-15 7:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 11:28 [PATCH v2 0/2] add hotplug depedency info Albert Zhou
2022-11-13 11:28 ` [PATCH v2 1/2] pci: hotplug: add dependency info to Kconfig Albert Zhou
2022-11-14 10:37 ` Mika Westerberg
2022-11-15 1:38 ` Albert Zhou
2022-11-15 7:23 ` Mika Westerberg [this message]
2022-11-13 11:28 ` [PATCH v2 2/2] pci: pcie: " Albert Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3M+dMJyvnS0uKZ2@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=albert.zhou.50@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.