From: Tony Lindgren <tony@atomide.com>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
"Manjunathappa, Prakash" <prakash.pm@ti.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] pinctrl: single: Fix potential division by zero
Date: Fri, 18 Nov 2022 10:15:21 +0200 [thread overview]
Message-ID: <Y3c/GSZEW60ZgSkM@atomide.com> (raw)
In-Reply-To: <20221117123034.27383-1-korotkov.maxim.s@gmail.com>
* Maxim Korotkov <korotkov.maxim.s@gmail.com> [221117 12:22]:
> There is a possibility of dividing by zero due to the pcs->bits_per_pin
> if pcs->fmask() also has a value of zero and called fls
> from asm-generic/bitops/builtin-fls.h or arch/x86/include/asm/bitops.h.
> The function pcs_probe() has the branch that assigned to fmask 0 before
> pcs_allocate_pin_table() was called
Reviewed-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
"Manjunathappa, Prakash" <prakash.pm@ti.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] pinctrl: single: Fix potential division by zero
Date: Fri, 18 Nov 2022 10:15:21 +0200 [thread overview]
Message-ID: <Y3c/GSZEW60ZgSkM@atomide.com> (raw)
In-Reply-To: <20221117123034.27383-1-korotkov.maxim.s@gmail.com>
* Maxim Korotkov <korotkov.maxim.s@gmail.com> [221117 12:22]:
> There is a possibility of dividing by zero due to the pcs->bits_per_pin
> if pcs->fmask() also has a value of zero and called fls
> from asm-generic/bitops/builtin-fls.h or arch/x86/include/asm/bitops.h.
> The function pcs_probe() has the branch that assigned to fmask 0 before
> pcs_allocate_pin_table() was called
Reviewed-by: Tony Lindgren <tony@atomide.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-18 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 12:30 [PATCH] pinctrl: single: Fix potential division by zero Maxim Korotkov
2022-11-17 12:30 ` Maxim Korotkov
2022-11-18 8:15 ` Tony Lindgren [this message]
2022-11-18 8:15 ` Tony Lindgren
2022-11-21 13:42 ` Linus Walleij
2022-11-21 13:42 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3c/GSZEW60ZgSkM@atomide.com \
--to=tony@atomide.com \
--cc=haojian.zhuang@linaro.org \
--cc=korotkov.maxim.s@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=prakash.pm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.