All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: kernel test robot <lkp@intel.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] drm: rcar-du: Fix Kconfig dependency between DRM and RZG2L_MIPI_DSI
Date: Tue, 22 Nov 2022 02:17:49 +0200	[thread overview]
Message-ID: <Y3wVLU01mHp2zozI@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221121181121.168278-1-biju.das.jz@bp.renesas.com>

Hi Biju,

Thank you for the patch.

On Mon, Nov 21, 2022 at 06:11:21PM +0000, Biju Das wrote:
> When CONFIG_DRM=m and CONFIG_DRM_RZG2L_MIPI_DSI=y, it results in a
> build failure. This patch fixes the build issue by adding dependency
> to DRM.
> 
> Fixes: 7a043f978ed1 ("drm: rcar-du: Add RZ/G2L DSI driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Ref:
>  * https://lore.kernel.org/linux-renesas-soc/OS0PR01MB592298E75153A52245D789D4860A9@OS0PR01MB5922.jpnprd01.prod.outlook.com/T/#u
> ---
>  drivers/gpu/drm/rcar-du/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> index 1065dca885ef..b2bddbeca878 100644
> --- a/drivers/gpu/drm/rcar-du/Kconfig
> +++ b/drivers/gpu/drm/rcar-du/Kconfig
> @@ -56,7 +56,7 @@ config DRM_RCAR_MIPI_DSI
>  
>  config DRM_RZG2L_MIPI_DSI
>  	tristate "RZ/G2L MIPI DSI Encoder Support"
> -	depends on DRM_BRIDGE && OF
> +	depends on DRM && DRM_BRIDGE && OF
>  	depends on ARCH_RENESAS || COMPILE_TEST
>  	select DRM_MIPI_DSI
>  	help

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] drm: rcar-du: Fix Kconfig dependency between DRM and RZG2L_MIPI_DSI
Date: Tue, 22 Nov 2022 02:17:49 +0200	[thread overview]
Message-ID: <Y3wVLU01mHp2zozI@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221121181121.168278-1-biju.das.jz@bp.renesas.com>

Hi Biju,

Thank you for the patch.

On Mon, Nov 21, 2022 at 06:11:21PM +0000, Biju Das wrote:
> When CONFIG_DRM=m and CONFIG_DRM_RZG2L_MIPI_DSI=y, it results in a
> build failure. This patch fixes the build issue by adding dependency
> to DRM.
> 
> Fixes: 7a043f978ed1 ("drm: rcar-du: Add RZ/G2L DSI driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Ref:
>  * https://lore.kernel.org/linux-renesas-soc/OS0PR01MB592298E75153A52245D789D4860A9@OS0PR01MB5922.jpnprd01.prod.outlook.com/T/#u
> ---
>  drivers/gpu/drm/rcar-du/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> index 1065dca885ef..b2bddbeca878 100644
> --- a/drivers/gpu/drm/rcar-du/Kconfig
> +++ b/drivers/gpu/drm/rcar-du/Kconfig
> @@ -56,7 +56,7 @@ config DRM_RCAR_MIPI_DSI
>  
>  config DRM_RZG2L_MIPI_DSI
>  	tristate "RZ/G2L MIPI DSI Encoder Support"
> -	depends on DRM_BRIDGE && OF
> +	depends on DRM && DRM_BRIDGE && OF
>  	depends on ARCH_RENESAS || COMPILE_TEST
>  	select DRM_MIPI_DSI
>  	help

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2022-11-22  0:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21 18:11 [PATCH] drm: rcar-du: Fix Kconfig dependency between DRM and RZG2L_MIPI_DSI Biju Das
2022-11-21 18:11 ` Biju Das
2022-11-22  0:17 ` Laurent Pinchart [this message]
2022-11-22  0:17   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3wVLU01mHp2zozI@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.