From: Lorenzo Pieralisi <lpieralisi@kernel.org> To: John Thomson <git@johnthomson.fastmail.com.au> Cc: "Sergio Paracuellos" <sergio.paracuellos@gmail.com>, "Kishon Vijay Abraham I" <kishon@ti.com>, "Vinod Koul" <vkoul@kernel.org>, "Rob Herring" <robh@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, "Bjorn Helgaas" <bhelgaas@google.com>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Arınç ÜNAL" <arinc.unal@arinc9.com>, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] PCI: mt7621: add sentinel to quirks table Date: Mon, 5 Dec 2022 17:26:00 +0100 [thread overview] Message-ID: <Y44bmGfgEJNd8VhK@lpieralisi> (raw) In-Reply-To: <20221104205242.3440388-3-git@johnthomson.fastmail.com.au> Always capitalize the sentence in the subject. "PCI: mt7621: Add sentinel to quirks table" On Sat, Nov 05, 2022 at 06:52:42AM +1000, John Thomson wrote: > With mt7621 soc_dev_attr fixed to register the soc as a device, > kernel will experience an oops in soc_device_match_attr Can we reword this please ? What you are describing *exposes* the bug but it is not describing the bug per-se. The bug is related to a missing sentinel in the struct soc_device_attribute array and that's true regardless of whether it is actually triggered or not. Please update the commit log promptly and I shall send it upstream. Thanks, Lorenzo > This quirk test was introduced in the staging driver in > commit b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision > using 'soc_device_attribute'"), and the staging driver was moved in > commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host > controller driver") for the 5.16 kernel > > Link: https://lore.kernel.org/lkml/26ebbed1-0fe9-4af9-8466-65f841d0b382@app.fastmail.com > Fixes: b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision > using 'soc_device_attribute'") > Signed-off-by: John Thomson <git@johnthomson.fastmail.com.au> > --- > drivers/pci/controller/pcie-mt7621.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c > index 4bd1abf26008..ee7aad09d627 100644 > --- a/drivers/pci/controller/pcie-mt7621.c > +++ b/drivers/pci/controller/pcie-mt7621.c > @@ -466,7 +466,8 @@ static int mt7621_pcie_register_host(struct pci_host_bridge *host) > } > > static const struct soc_device_attribute mt7621_pcie_quirks_match[] = { > - { .soc_id = "mt7621", .revision = "E2" } > + { .soc_id = "mt7621", .revision = "E2" }, > + { /* sentinel */ } > }; > > static int mt7621_pcie_probe(struct platform_device *pdev) > -- > 2.37.2 >
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lpieralisi@kernel.org> To: John Thomson <git@johnthomson.fastmail.com.au> Cc: "Sergio Paracuellos" <sergio.paracuellos@gmail.com>, "Kishon Vijay Abraham I" <kishon@ti.com>, "Vinod Koul" <vkoul@kernel.org>, "Rob Herring" <robh@kernel.org>, "Krzysztof Wilczyński" <kw@linux.com>, "Bjorn Helgaas" <bhelgaas@google.com>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Arınç ÜNAL" <arinc.unal@arinc9.com>, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] PCI: mt7621: add sentinel to quirks table Date: Mon, 5 Dec 2022 17:26:00 +0100 [thread overview] Message-ID: <Y44bmGfgEJNd8VhK@lpieralisi> (raw) In-Reply-To: <20221104205242.3440388-3-git@johnthomson.fastmail.com.au> Always capitalize the sentence in the subject. "PCI: mt7621: Add sentinel to quirks table" On Sat, Nov 05, 2022 at 06:52:42AM +1000, John Thomson wrote: > With mt7621 soc_dev_attr fixed to register the soc as a device, > kernel will experience an oops in soc_device_match_attr Can we reword this please ? What you are describing *exposes* the bug but it is not describing the bug per-se. The bug is related to a missing sentinel in the struct soc_device_attribute array and that's true regardless of whether it is actually triggered or not. Please update the commit log promptly and I shall send it upstream. Thanks, Lorenzo > This quirk test was introduced in the staging driver in > commit b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision > using 'soc_device_attribute'"), and the staging driver was moved in > commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host > controller driver") for the 5.16 kernel > > Link: https://lore.kernel.org/lkml/26ebbed1-0fe9-4af9-8466-65f841d0b382@app.fastmail.com > Fixes: b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision > using 'soc_device_attribute'") > Signed-off-by: John Thomson <git@johnthomson.fastmail.com.au> > --- > drivers/pci/controller/pcie-mt7621.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c > index 4bd1abf26008..ee7aad09d627 100644 > --- a/drivers/pci/controller/pcie-mt7621.c > +++ b/drivers/pci/controller/pcie-mt7621.c > @@ -466,7 +466,8 @@ static int mt7621_pcie_register_host(struct pci_host_bridge *host) > } > > static const struct soc_device_attribute mt7621_pcie_quirks_match[] = { > - { .soc_id = "mt7621", .revision = "E2" } > + { .soc_id = "mt7621", .revision = "E2" }, > + { /* sentinel */ } > }; > > static int mt7621_pcie_probe(struct platform_device *pdev) > -- > 2.37.2 > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-12-05 16:26 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-04 20:52 [PATCH 0/2] mt7621 pci & phy-pci fix future oops from soc_device_match_attr John Thomson 2022-11-04 20:52 ` John Thomson 2022-11-04 20:52 ` [PATCH 1/2] phy: ralink: mt7621-pci: add sentinel to quirks table John Thomson 2022-11-04 20:52 ` John Thomson 2022-11-05 6:24 ` Sergio Paracuellos 2022-11-05 6:24 ` Sergio Paracuellos 2022-11-05 7:31 ` Vinod Koul 2022-11-05 7:31 ` Vinod Koul 2022-11-04 20:52 ` [PATCH 2/2] PCI: mt7621: " John Thomson 2022-11-04 20:52 ` John Thomson 2022-11-05 6:25 ` Sergio Paracuellos 2022-11-05 6:25 ` Sergio Paracuellos 2022-11-11 18:55 ` John Thomson 2022-12-05 16:26 ` Lorenzo Pieralisi [this message] 2022-12-05 16:26 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Y44bmGfgEJNd8VhK@lpieralisi \ --to=lpieralisi@kernel.org \ --cc=arinc.unal@arinc9.com \ --cc=bhelgaas@google.com \ --cc=git@johnthomson.fastmail.com.au \ --cc=gregkh@linuxfoundation.org \ --cc=kishon@ti.com \ --cc=kw@linux.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=robh@kernel.org \ --cc=sergio.paracuellos@gmail.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.