Re: [PATCH net-next v4 1/3] net: devlink: let the core report the driver name instead of the drivers

From: Ido Schimmel <idosch@nvidia.com>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: Jiri Pirko <jiri@nvidia.com>,
	netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	linux-kernel@vger.kernel.org,
	Boris Brezillon <bbrezillon@kernel.org>,
	Arnaud Ebalard <arno@natisbad.org>,
	Srujana Challa <schalla@marvell.com>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	Michael Chan <michael.chan@broadcom.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Dimitris Michailidis <dmichail@fungible.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Salil Mehta <salil.mehta@huawei.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Sunil Goutham <sgoutham@marvell.com>,
	Linu Cherian <lcherian@marvell.com>,
	Geetha sowjanya <gakula@marvell.com>,
	Jerin Jacob <jerinj@marvell.com>, hariprasad <hkelam@marvell.com>,
	Subbaraya Sundeep <sbhatta@marvell.com>,
	Taras Chornyi <tchornyi@marvell.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Leon Romanovsky <leon@kernel.org>,
	Petr Machata <petrm@nvidia.com>,
	Simon Horman <simon.horman@corigine.com>,
	Shannon Nelson <snelson@pensando.io>,
	drivers@pensando.io, Ariel Elior <aelior@marvell.com>,
	Manish Chopra <manishc@marvell.com>,
	Jonathan Lemon <jonathan.lemon@gmail.com>,
	Vadim Fedorenko <vadfed@fb.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Vadim Pasternak <vadimp@mellanox.com>,
	Shalom Toledo <shalomt@mellanox.com>,
	linux-crypto@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	linux-rdma@vger.kernel.org, oss-drivers@corigine.com,
	Jiri Pirko <jiri@mellanox.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Hao Chen <chenhao288@hisilicon.com>,
	Guangbin Huang <huangguangbin2@huawei.com>,
	Minghao Chi <chi.minghao@zte.com.cn>,
	Shijith Thotton <sthotton@marvell.com>
Subject: Re: [PATCH net-next v4 1/3] net: devlink: let the core report the driver name instead of the drivers
Date: Mon, 28 Nov 2022 13:49:16 +0200	[thread overview]
Message-ID: <Y4SgPF7ON6aD6yaZ@shredder> (raw)
In-Reply-To: <20221128041545.3170897-2-mailhol.vincent@wanadoo.fr>

On Mon, Nov 28, 2022 at 01:15:43PM +0900, Vincent Mailhol wrote:
> The driver name is available in device_driver::name. Right now,
> drivers still have to report this piece of information themselves in
> their devlink_ops::info_get callback function.
> 
> In order to factorize code, make devlink_nl_info_fill() add the driver
> name attribute.
> 
> nla_put() does not check if an attribute already exists and
> unconditionally reserves new space, c.f. [1]. To avoid attribute
> duplication, clean-up all the drivers which are currently reporting
> the driver name in their callback.
> 
> [1] __nla_put() from lib/nlattr.c
> Link: https://elixir.bootlin.com/linux/v6.0/source/lib/nlattr.c#L993
> 
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

For mlxsw:

Tested-by: Ido Schimmel <idosch@nvidia.com>

I don't see a difference in "devlink dev info" output before and after
the patchset. Tested with mlxsw_spectrum and mlxsw_minimal.