Re: [PATCH v3 3/4] ext4: rename xattr_find_entry() and __xattr_check_inode()

From: "Theodore Ts'o" <tytso@mit.edu>
To: Ye Bin <yebin@huaweicloud.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org, jack@suse.cz,
	Ye Bin <yebin10@huawei.com>
Subject: Re: [PATCH v3 3/4] ext4: rename xattr_find_entry() and __xattr_check_inode()
Date: Fri, 9 Dec 2022 00:38:29 -0500	[thread overview]
Message-ID: <Y5LJ1QU1JND2fuVK@mit.edu> (raw)
In-Reply-To: <20221208023233.1231330-4-yebin@huaweicloud.com>

On Thu, Dec 08, 2022 at 10:32:32AM +0800, Ye Bin wrote:
> From: Ye Bin <yebin10@huawei.com>
> 
> Prepend ext4 prefix to function names of xattr_find_entry() and
> __xattr_check_inode() for consistency with other functions in ext4
> xattr module.

The reason why these function names don't have the ext4 prefix is
because functions are static, so there is need to worry about
namespace pollution.

For static functions, there is no real need to add the ext4 prefix, so
why not keep the functions shorter?  Yes, there are places where
static functions have the ext4 prefix.  The main reason why we have
changed it is that it's not worth the code churn.  Similarly, adding
the ext4 prefix is *definitely* not worth the code churn.

Cheers,

					- Ted