From: "Theodore Ts'o" <tytso@mit.edu>
To: Ye Bin <yebin@huaweicloud.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, jack@suse.cz,
Ye Bin <yebin10@huawei.com>
Subject: Re: [PATCH v3 4/4] ext4: fix inode leak in 'ext4_xattr_inode_create()'
Date: Fri, 9 Dec 2022 00:39:12 -0500 [thread overview]
Message-ID: <Y5LKAJCDgvB65gGm@mit.edu> (raw)
In-Reply-To: <20221208023233.1231330-5-yebin@huaweicloud.com>
On Thu, Dec 08, 2022 at 10:32:33AM +0800, Ye Bin wrote:
> From: Ye Bin <yebin10@huawei.com>
>
> There is issue as follows when do setxattr with inject fault:
> [localhost]#fsck.ext4 -fn /dev/sda
> e2fsck 1.46.6-rc1 (12-Sep-2022)
> Pass 1: Checking inodes, blocks, and sizes
> Pass 2: Checking directory structure
> Pass 3: Checking directory connectivity
> Pass 4: Checking reference counts
> Unattached zero-length inode 15. Clear? no
>
> Unattached inode 15
> Connect to /lost+found? no
>
> Pass 5: Checking group summary information
>
> /dev/sda: ********** WARNING: Filesystem still has errors **********
>
> /dev/sda: 15/655360 files (0.0% non-contiguous), 66755/2621440 blocks
>
> This occurs in 'ext4_xattr_inode_create()'. If 'ext4_mark_inode_dirty()'
> fails, dropping i_nlink of the inode is needed. Or will lead to inode leak.
>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2022-12-09 5:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 2:32 [PATCH v3 0/4] Fix two issue about ext4 extended attribute Ye Bin
2022-12-08 2:32 ` [PATCH v3 1/4] ext4: fix WARNING in ext4_expand_extra_isize_ea Ye Bin
2022-12-09 5:35 ` Theodore Ts'o
2022-12-08 2:32 ` [PATCH v3 2/4] ext4: allocate extended attribute value in vmalloc area Ye Bin
2022-12-09 5:35 ` Theodore Ts'o
2022-12-08 2:32 ` [PATCH v3 3/4] ext4: rename xattr_find_entry() and __xattr_check_inode() Ye Bin
2022-12-09 5:38 ` Theodore Ts'o
2022-12-08 2:32 ` [PATCH v3 4/4] ext4: fix inode leak in 'ext4_xattr_inode_create()' Ye Bin
2022-12-09 5:39 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5LKAJCDgvB65gGm@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yebin10@huawei.com \
--cc=yebin@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.