All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Seija K." <doremylover123@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Chris Zankel <chris@zankel.net>,
	Max Filippov <jcmvbkbc@gmail.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH] arch: change variable types to match those of what is assigned to them
Date: Tue, 13 Dec 2022 17:45:23 +0000	[thread overview]
Message-ID: <Y5i6M/9XEr0zvenj@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAA42iKx2f2LsAQ9C5rxnCTPhOB6n+L35Winc5WK1K2EySAjvXA@mail.gmail.com>

On Tue, Dec 13, 2022 at 12:35:35PM -0500, Seija K. wrote:
> There are many places where "int len = strlen(foo);" is written, just
> for len to be passed as a parameter of size_t. This causes truncation
> and then expansion back from int to size_t. Not to mention this is
> poor logic and needless truncations can add extra unneeded
> instructions.
> 
> This patch aims to fix the worst offenders.

I suggested to test _not_ on the mailing lists, because it adds
unnecessary noise - and remember that your email needlessly gets
sent to thousands of recipients.

Yet again, the patch is mangled, but is better than the last one.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Seija K." <doremylover123@gmail.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Chris Zankel <chris@zankel.net>,
	Max Filippov <jcmvbkbc@gmail.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH] arch: change variable types to match those of what is assigned to them
Date: Tue, 13 Dec 2022 17:45:23 +0000	[thread overview]
Message-ID: <Y5i6M/9XEr0zvenj@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAA42iKx2f2LsAQ9C5rxnCTPhOB6n+L35Winc5WK1K2EySAjvXA@mail.gmail.com>

On Tue, Dec 13, 2022 at 12:35:35PM -0500, Seija K. wrote:
> There are many places where "int len = strlen(foo);" is written, just
> for len to be passed as a parameter of size_t. This causes truncation
> and then expansion back from int to size_t. Not to mention this is
> poor logic and needless truncations can add extra unneeded
> instructions.
> 
> This patch aims to fix the worst offenders.

I suggested to test _not_ on the mailing lists, because it adds
unnecessary noise - and remember that your email needlessly gets
sent to thousands of recipients.

Yet again, the patch is mangled, but is better than the last one.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-12-13 17:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 17:35 [PATCH] arch: change variable types to match those of what is assigned to them Seija K.
2022-12-13 17:35 ` Seija K.
2022-12-13 17:40 ` Randy Dunlap
2022-12-13 17:40   ` Randy Dunlap
2022-12-13 17:45 ` Russell King (Oracle) [this message]
2022-12-13 17:45   ` Russell King (Oracle)
  -- strict thread matches above, loose matches on Subject: below --
2022-12-14  0:51 Seija Kijin
2022-12-14  0:51 ` Seija Kijin
2022-12-14  1:48 ` Max Filippov
2022-12-14  1:48   ` Max Filippov
2022-12-13 17:03 Seija K.
2022-12-13 17:03 ` Seija K.
2022-12-13 17:28 ` Russell King (Oracle)
2022-12-13 17:28   ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5i6M/9XEr0zvenj@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=chris@zankel.net \
    --cc=doremylover123@gmail.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=sstabellini@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.