From: Christoph Hellwig <hch@infradead.org>
To: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Andreas Gruenbacher <agruenba@redhat.com>,
"Darrick J . Wong" <djwong@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <willy@infradead.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, cluster-devel@redhat.com
Subject: Re: [RFC v3 2/7] iomap: Add iomap_folio_done helper
Date: Fri, 23 Dec 2022 23:22:31 -0800 [thread overview]
Message-ID: <Y6aot0pDtWl/c5Nb@infradead.org> (raw)
In-Reply-To: <CAHpGcMJAnyn_7hHvsPL5GAiwbJs_DX04+Tt0P+6jfi_kb7jGUg@mail.gmail.com>
On Fri, Dec 23, 2022 at 09:54:34PM +0100, Andreas Grünbacher wrote:
> > But for the current version I don't really understand why the error
> > unwinding changes here.
>
> Currently, we have this order of operations in iomap_write_begin():
>
> folio_unlock() // folio_put() // iomap_write_failed() // ->page_done()
>
> and this order in iomap_write_end():
>
> folio_unlock() // ->page_done() // folio_put() // iomap_write_failed()
>
> The unwinding in iomap_write_begin() works because this is the trivial
> case in which nothing happens to the page. We might just as well use
> the same order of operations there as in iomap_write_end() though, and
> when you switch to that, this is what you get.
Please document this in the commit message.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [RFC v3 2/7] iomap: Add iomap_folio_done helper
Date: Fri, 23 Dec 2022 23:22:31 -0800 [thread overview]
Message-ID: <Y6aot0pDtWl/c5Nb@infradead.org> (raw)
In-Reply-To: <CAHpGcMJAnyn_7hHvsPL5GAiwbJs_DX04+Tt0P+6jfi_kb7jGUg@mail.gmail.com>
On Fri, Dec 23, 2022 at 09:54:34PM +0100, Andreas Gr?nbacher wrote:
> > But for the current version I don't really understand why the error
> > unwinding changes here.
>
> Currently, we have this order of operations in iomap_write_begin():
>
> folio_unlock() // folio_put() // iomap_write_failed() // ->page_done()
>
> and this order in iomap_write_end():
>
> folio_unlock() // ->page_done() // folio_put() // iomap_write_failed()
>
> The unwinding in iomap_write_begin() works because this is the trivial
> case in which nothing happens to the page. We might just as well use
> the same order of operations there as in iomap_write_end() though, and
> when you switch to that, this is what you get.
Please document this in the commit message.
next prev parent reply other threads:[~2022-12-24 7:22 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 15:06 [RFC v3 0/7] Turn iomap_page_ops into iomap_folio_ops Andreas Gruenbacher
2022-12-16 15:06 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-16 15:06 ` [RFC v3 1/7] fs: Add folio_may_straddle_isize helper Andreas Gruenbacher
2022-12-16 15:06 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-23 14:56 ` Christoph Hellwig
2022-12-23 14:56 ` [Cluster-devel] " Christoph Hellwig
2022-12-23 22:04 ` Andreas Grünbacher
2022-12-23 22:04 ` [Cluster-devel] " Andreas Grünbacher
2022-12-24 7:21 ` Christoph Hellwig
2022-12-16 15:06 ` [RFC v3 2/7] iomap: Add iomap_folio_done helper Andreas Gruenbacher
2022-12-16 15:06 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-23 15:02 ` Christoph Hellwig
2022-12-23 15:02 ` [Cluster-devel] " Christoph Hellwig
2022-12-23 20:54 ` Andreas Grünbacher
2022-12-23 20:54 ` [Cluster-devel] " Andreas Grünbacher
2022-12-24 7:22 ` Christoph Hellwig [this message]
2022-12-24 7:22 ` Christoph Hellwig
2022-12-16 15:06 ` [RFC v3 3/7] iomap/gfs2: Unlock and put folio in page_done handler Andreas Gruenbacher
2022-12-16 15:06 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-23 15:03 ` Christoph Hellwig
2022-12-23 15:03 ` [Cluster-devel] " Christoph Hellwig
2022-12-16 15:06 ` [RFC v3 4/7] iomap: Add iomap_folio_prepare helper Andreas Gruenbacher
2022-12-16 15:06 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-23 15:04 ` Christoph Hellwig
2022-12-23 15:04 ` [Cluster-devel] " Christoph Hellwig
2022-12-23 21:05 ` Andreas Grünbacher
2022-12-23 21:05 ` [Cluster-devel] " Andreas Grünbacher
2022-12-24 7:23 ` Christoph Hellwig
2022-12-24 7:23 ` [Cluster-devel] " Christoph Hellwig
2022-12-25 9:12 ` Matthew Wilcox
2022-12-25 9:12 ` [Cluster-devel] " Matthew Wilcox
2022-12-28 15:55 ` Christoph Hellwig
2022-12-28 15:55 ` [Cluster-devel] " Christoph Hellwig
2022-12-16 15:06 ` [RFC v3 5/7] iomap: Get page in page_prepare handler Andreas Gruenbacher
2022-12-16 15:06 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-16 16:30 ` Matthew Wilcox
2022-12-16 16:30 ` [Cluster-devel] " Matthew Wilcox
2022-12-16 17:15 ` Andreas Gruenbacher
2022-12-16 17:15 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-23 15:07 ` Christoph Hellwig
2022-12-23 15:07 ` [Cluster-devel] " Christoph Hellwig
2022-12-16 15:06 ` [RFC v3 6/7] iomap/xfs: Eliminate the iomap_valid handler Andreas Gruenbacher
2022-12-16 15:06 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-23 15:10 ` Christoph Hellwig
2022-12-23 15:10 ` [Cluster-devel] " Christoph Hellwig
2022-12-16 15:06 ` [RFC v3 7/7] iomap: Rename page_ops to folio_ops Andreas Gruenbacher
2022-12-16 15:06 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 0/7] Turn iomap_page_ops into iomap_folio_ops Andreas Gruenbacher
2022-12-18 22:10 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 1/7] fs: Add folio_may_straddle_isize helper Andreas Gruenbacher
2022-12-18 22:10 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 2/7] iomap: Add iomap_folio_done helper Andreas Gruenbacher
2022-12-18 22:10 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 3/7] iomap/gfs2: Unlock and put folio in page_done handler Andreas Gruenbacher
2022-12-18 22:10 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 4/7] iomap: Add iomap_folio_prepare helper Andreas Gruenbacher
2022-12-18 22:10 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 5/7] iomap/gfs2: Get page in page_prepare handler Andreas Gruenbacher
2022-12-18 22:10 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 6/7] iomap/xfs: Eliminate the iomap_valid handler Andreas Gruenbacher
2022-12-18 22:10 ` [Cluster-devel] " Andreas Gruenbacher
2022-12-18 22:10 ` [RFC v4 7/7] iomap: Rename page_ops to folio_ops Andreas Gruenbacher
2022-12-18 22:10 ` [Cluster-devel] " Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6aot0pDtWl/c5Nb@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=andreas.gruenbacher@gmail.com \
--cc=cluster-devel@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.