From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Mark Brown <broonie@kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Subject: Re: [PATCH v1 2/6] ASoC: Intel: bytcht_es8316: Drop reference count of ACPI device after use
Date: Thu, 12 Jan 2023 13:24:47 +0200 [thread overview]
Message-ID: <Y7/t/2LCY2R+nZ8e@smile.fi.intel.com> (raw)
In-Reply-To: <edde76c0-a444-1c3a-3541-af79897701fa@linux.intel.com>
On Tue, Jan 10, 2023 at 07:20:08PM -0600, Pierre-Louis Bossart wrote:
> On 1/2/23 14:30, Andy Shevchenko wrote:
> > Theoretically the device might gone if its reference count drops to 0.
> > This might be the case when we try to find the first physical node of
> > the ACPI device. We need to keep reference to it until we get a result
> > of the above mentioned call. Refactor the code to drop the reference
> > count at the correct place.
> >
> > While at it, move to acpi_dev_put() as symmetrical call to the
> > acpi_dev_get_first_match_dev().
> >
> > Fixes: 3c22a73fb873 ("ASoC: Intel: bytcht_es8316: fix HID handling")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> How do we proceed for this patchset? I am happy to ack a v2 if Andy
> splits the AMD and Intel patches w/ a cover letter, but this could also
> be added directly if there is no objection.
I have split out the AMD stuff, so I will resend v2 without it and with cover
letter.
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
Hans de Goede <hdegoede@redhat.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: Re: [PATCH v1 2/6] ASoC: Intel: bytcht_es8316: Drop reference count of ACPI device after use
Date: Thu, 12 Jan 2023 13:24:47 +0200 [thread overview]
Message-ID: <Y7/t/2LCY2R+nZ8e@smile.fi.intel.com> (raw)
In-Reply-To: <edde76c0-a444-1c3a-3541-af79897701fa@linux.intel.com>
On Tue, Jan 10, 2023 at 07:20:08PM -0600, Pierre-Louis Bossart wrote:
> On 1/2/23 14:30, Andy Shevchenko wrote:
> > Theoretically the device might gone if its reference count drops to 0.
> > This might be the case when we try to find the first physical node of
> > the ACPI device. We need to keep reference to it until we get a result
> > of the above mentioned call. Refactor the code to drop the reference
> > count at the correct place.
> >
> > While at it, move to acpi_dev_put() as symmetrical call to the
> > acpi_dev_get_first_match_dev().
> >
> > Fixes: 3c22a73fb873 ("ASoC: Intel: bytcht_es8316: fix HID handling")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> How do we proceed for this patchset? I am happy to ack a v2 if Andy
> splits the AMD and Intel patches w/ a cover letter, but this could also
> be added directly if there is no objection.
I have split out the AMD stuff, so I will resend v2 without it and with cover
letter.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-12 11:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 20:30 [PATCH v1 1/6] ASoC: amd: acp-es8336: Drop reference count of ACPI device after use Andy Shevchenko
2023-01-02 20:30 ` Andy Shevchenko
2023-01-02 20:30 ` [PATCH v1 2/6] ASoC: Intel: bytcht_es8316: " Andy Shevchenko
2023-01-02 20:30 ` Andy Shevchenko
2023-01-11 1:20 ` Pierre-Louis Bossart
2023-01-11 1:20 ` Pierre-Louis Bossart
2023-01-12 11:24 ` Andy Shevchenko [this message]
2023-01-12 11:24 ` Andy Shevchenko
2023-01-02 20:30 ` [PATCH v1 3/6] ASoC: Intel: bytcr_rt5651: " Andy Shevchenko
2023-01-02 20:30 ` Andy Shevchenko
2023-01-02 20:30 ` [PATCH v1 4/6] ASoC: Intel: bytcr_rt5640: " Andy Shevchenko
2023-01-02 20:30 ` Andy Shevchenko
2023-01-02 20:30 ` [PATCH v1 5/6] ASoC: Intel: bytcr_wm5102: " Andy Shevchenko
2023-01-02 20:30 ` Andy Shevchenko
2023-01-02 20:30 ` [PATCH v1 6/6] ASoC: Intel: sof_es8336: " Andy Shevchenko
2023-01-02 20:30 ` Andy Shevchenko
2023-01-11 3:05 ` [PATCH v1 1/6] ASoC: amd: acp-es8336: " Mukunda,Vijendar
2023-01-11 3:05 ` Mukunda,Vijendar
2023-01-12 11:24 ` Andy Shevchenko
2023-01-12 11:24 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7/t/2LCY2R+nZ8e@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.