From: Sam Ravnborg <sam@ravnborg.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings
Date: Fri, 6 Jan 2023 14:04:51 +0100 [thread overview]
Message-ID: <Y7gcc1tjge3wHOf7@ravnborg.org> (raw)
In-Reply-To: <877fc236-5f86-3853-0877-33df32689d8c@linaro.org>
Hi Neil,
> > > +properties:
> > > + compatible:
> > > + const: visionox,vtdr6130
> > > +
> > > + vddio-supply: true
> > > + vci-supply: true
> > > + vdd-supply: true
> > These 3 looks wrong to me, as the above are not documented in panel-common.
> > But maybe I miss something and this is OK?
>
> It should be OK, the XXXX-supply properties are standard properties
Thanks for the explanation - patch is then:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings
Date: Fri, 6 Jan 2023 14:04:51 +0100 [thread overview]
Message-ID: <Y7gcc1tjge3wHOf7@ravnborg.org> (raw)
In-Reply-To: <877fc236-5f86-3853-0877-33df32689d8c@linaro.org>
Hi Neil,
> > > +properties:
> > > + compatible:
> > > + const: visionox,vtdr6130
> > > +
> > > + vddio-supply: true
> > > + vci-supply: true
> > > + vdd-supply: true
> > These 3 looks wrong to me, as the above are not documented in panel-common.
> > But maybe I miss something and this is OK?
>
> It should be OK, the XXXX-supply properties are standard properties
Thanks for the explanation - patch is then:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
next prev parent reply other threads:[~2023-01-06 13:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 14:22 [PATCH 0/2] drm/panel: add support for the Visionox VTDR6130 AMOLED DSI panel Neil Armstrong
2023-01-03 14:22 ` Neil Armstrong
2023-01-03 14:22 ` [PATCH 1/2] dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings Neil Armstrong
2023-01-03 14:22 ` Neil Armstrong
2023-01-03 17:57 ` Sam Ravnborg
2023-01-03 17:57 ` Sam Ravnborg
2023-01-05 9:55 ` Neil Armstrong
2023-01-05 9:55 ` Neil Armstrong
2023-01-06 13:04 ` Sam Ravnborg [this message]
2023-01-06 13:04 ` Sam Ravnborg
2023-01-06 12:54 ` Krzysztof Kozlowski
2023-01-06 12:54 ` Krzysztof Kozlowski
2023-01-03 14:22 ` [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver Neil Armstrong
2023-01-03 14:22 ` Neil Armstrong
2023-01-03 18:15 ` Sam Ravnborg
2023-01-03 18:15 ` Sam Ravnborg
2023-01-04 8:53 ` Neil Armstrong
2023-01-04 8:53 ` Neil Armstrong
2023-01-04 9:27 ` Sam Ravnborg
2023-01-04 9:27 ` Sam Ravnborg
2023-01-04 18:25 ` Rayyan Ansari
2023-01-04 18:25 ` Rayyan Ansari
2023-01-05 9:17 ` Neil Armstrong
2023-01-05 9:17 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7gcc1tjge3wHOf7@ravnborg.org \
--to=sam@ravnborg.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.