From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: sam@ravnborg.org
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Helge Deller <deller@gmx.de>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Antonino Daplas <adaplas@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Robin van der Gracht <robin@protonic.nl>,
Miguel Ojeda <ojeda@kernel.org>, Lee Jones <lee@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org,
Stephen Kitt <steve@sk2.org>
Subject: Re: [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank()
Date: Mon, 9 Jan 2023 13:13:00 +0200 [thread overview]
Message-ID: <Y7v2vJtsWuhhiB2b@smile.fi.intel.com> (raw)
In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-9-1bd9bafb351f@ravnborg.org>
On Sat, Jan 07, 2023 at 07:26:23PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
>
> Avoiding direct access to backlight_properties.props.
>
> Access to the deprecated props.fb_blank replaced by backlight_is_blank().
> Access to props.power is dropped - it was only used for debug.
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Stephen Kitt <steve@sk2.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: linux-fbdev@vger.kernel.org
Not sure why you have this (at least) explicitly mentioned as get_maintainer.pl
can generate it and git send-email can utilize the script output...
...
> - write_reg(par, 0xB5, on ? 0x03 : 0x02);
> + write_reg(par, 0xB5, !blank ? 0x03 : 0x02);
Why not positive conditional?
write_reg(par, 0xB5, blank ? 0x02 : 0x03);
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: sam@ravnborg.org
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-omap@vger.kernel.org, Stephen Kitt <steve@sk2.org>,
Antonino Daplas <adaplas@gmail.com>,
Robin van der Gracht <robin@protonic.nl>,
Helge Deller <deller@gmx.de>, Lee Jones <lee@kernel.org>,
linux-staging@lists.linux.dev,
Nicolas Ferre <nicolas.ferre@microchip.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Jingoo Han <jingoohan1@gmail.com>,
Paul Mackerras <paulus@samba.org>,
linux-fbdev@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Miguel Ojeda <ojeda@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
linuxppc-dev@lists.ozlabs.org,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank()
Date: Mon, 9 Jan 2023 13:13:00 +0200 [thread overview]
Message-ID: <Y7v2vJtsWuhhiB2b@smile.fi.intel.com> (raw)
In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-9-1bd9bafb351f@ravnborg.org>
On Sat, Jan 07, 2023 at 07:26:23PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
>
> Avoiding direct access to backlight_properties.props.
>
> Access to the deprecated props.fb_blank replaced by backlight_is_blank().
> Access to props.power is dropped - it was only used for debug.
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Stephen Kitt <steve@sk2.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: linux-fbdev@vger.kernel.org
Not sure why you have this (at least) explicitly mentioned as get_maintainer.pl
can generate it and git send-email can utilize the script output...
...
> - write_reg(par, 0xB5, on ? 0x03 : 0x02);
> + write_reg(par, 0xB5, !blank ? 0x03 : 0x02);
Why not positive conditional?
write_reg(par, 0xB5, blank ? 0x02 : 0x03);
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: sam@ravnborg.org
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-omap@vger.kernel.org, Stephen Kitt <steve@sk2.org>,
Antonino Daplas <adaplas@gmail.com>,
Robin van der Gracht <robin@protonic.nl>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Helge Deller <deller@gmx.de>, Lee Jones <lee@kernel.org>,
linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Jingoo Han <jingoohan1@gmail.com>,
Paul Mackerras <paulus@samba.org>,
linux-fbdev@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Miguel Ojeda <ojeda@kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
linuxppc-dev@lists.ozlabs.org,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank()
Date: Mon, 9 Jan 2023 13:13:00 +0200 [thread overview]
Message-ID: <Y7v2vJtsWuhhiB2b@smile.fi.intel.com> (raw)
In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-9-1bd9bafb351f@ravnborg.org>
On Sat, Jan 07, 2023 at 07:26:23PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
>
> Avoiding direct access to backlight_properties.props.
>
> Access to the deprecated props.fb_blank replaced by backlight_is_blank().
> Access to props.power is dropped - it was only used for debug.
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Stephen Kitt <steve@sk2.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: linux-fbdev@vger.kernel.org
Not sure why you have this (at least) explicitly mentioned as get_maintainer.pl
can generate it and git send-email can utilize the script output...
...
> - write_reg(par, 0xB5, on ? 0x03 : 0x02);
> + write_reg(par, 0xB5, !blank ? 0x03 : 0x02);
Why not positive conditional?
write_reg(par, 0xB5, blank ? 0x02 : 0x03);
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-09 11:13 UTC|newest]
Thread overview: 183+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 18:26 [PATCH 00/15] backlight: Drop use of deprecated fb_blank property Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 20:36 ` Stephen Kitt
2023-01-07 20:36 ` Stephen Kitt
2023-01-07 20:36 ` Stephen Kitt
2023-01-07 20:53 ` Sam Ravnborg
2023-01-07 20:53 ` Sam Ravnborg
2023-01-07 20:53 ` Sam Ravnborg
2023-01-08 7:45 ` Stephen Kitt
2023-01-08 7:45 ` Stephen Kitt
2023-01-08 7:45 ` Stephen Kitt
2023-01-08 7:47 ` Stephen Kitt
2023-01-08 7:47 ` Stephen Kitt
2023-01-08 7:47 ` Stephen Kitt
2023-01-08 20:24 ` Sam Ravnborg
2023-01-08 20:24 ` Sam Ravnborg
2023-01-08 20:24 ` Sam Ravnborg
2023-01-09 19:53 ` Stephen Kitt
2023-01-09 19:53 ` Stephen Kitt
2023-01-09 19:53 ` Stephen Kitt
2023-01-09 20:03 ` Stephen Kitt
2023-01-09 20:03 ` Stephen Kitt
2023-01-09 20:03 ` Stephen Kitt
2023-01-08 17:26 ` Helge Deller
2023-01-08 17:26 ` Helge Deller
2023-01-08 17:26 ` Helge Deller
2023-01-08 20:26 ` Sam Ravnborg
2023-01-08 20:26 ` Sam Ravnborg
2023-01-08 20:26 ` Sam Ravnborg
2023-01-09 20:18 ` Stephen Kitt
2023-01-09 20:18 ` Stephen Kitt
2023-01-09 20:18 ` Stephen Kitt
2023-01-09 20:34 ` Helge Deller
2023-01-09 20:34 ` Helge Deller
2023-01-09 20:34 ` Helge Deller
2023-01-09 9:14 ` Jani Nikula
2023-01-09 9:14 ` Jani Nikula
2023-01-09 9:14 ` Jani Nikula
2023-01-07 18:26 ` [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness() Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-09 17:44 ` Christophe Leroy
2023-01-09 17:44 ` Christophe Leroy
2023-01-09 17:44 ` Christophe Leroy
2023-01-09 17:44 ` Christophe Leroy
2023-01-09 18:21 ` Sam Ravnborg
2023-01-09 18:21 ` Sam Ravnborg
2023-01-09 18:21 ` Sam Ravnborg
2023-01-09 18:21 ` Sam Ravnborg
2023-01-07 18:26 ` [PATCH 03/15] video: fbdev: nvidia: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 04/15] video: fbdev: radeon: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 05/15] video: fbdev: riva: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 06/15] video: fbdev: aty128fb: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 07/15] video: fbdev: mx3fb: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 08/15] video: fbdev: omap2: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank() Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:28 ` Stephen Kitt
2023-01-08 19:28 ` Stephen Kitt
2023-01-08 19:28 ` Stephen Kitt
2023-01-08 20:29 ` Sam Ravnborg
2023-01-08 20:29 ` Sam Ravnborg
2023-01-08 20:29 ` Sam Ravnborg
2023-01-09 7:04 ` Stephen Kitt
2023-01-09 7:04 ` Stephen Kitt
2023-01-09 7:04 ` Stephen Kitt
2023-01-09 11:16 ` Daniel Thompson
2023-01-09 11:16 ` Daniel Thompson
2023-01-09 11:16 ` Daniel Thompson
2023-01-09 11:13 ` Andy Shevchenko [this message]
2023-01-09 11:13 ` Andy Shevchenko
2023-01-09 11:13 ` Andy Shevchenko
2023-01-07 18:26 ` [PATCH 10/15] staging: fbtft: core: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:29 ` Stephen Kitt
2023-01-08 19:29 ` Stephen Kitt
2023-01-08 19:29 ` Stephen Kitt
2023-01-09 11:15 ` Andy Shevchenko
2023-01-09 11:15 ` Andy Shevchenko
2023-01-09 11:15 ` Andy Shevchenko
2023-01-07 18:26 ` [PATCH 11/15] powerpc: via-pmu-backlight: Introduce backlight_get_brightness() Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:36 ` Stephen Kitt
2023-01-08 19:36 ` Stephen Kitt
2023-01-08 19:36 ` Stephen Kitt
2023-01-07 18:26 ` [PATCH 12/15] auxdisplay: ht16k33: " Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 21:02 ` Miguel Ojeda
2023-01-07 21:02 ` Miguel Ojeda
2023-01-07 21:02 ` Miguel Ojeda
2023-01-08 9:29 ` Sam Ravnborg
2023-01-08 9:29 ` Sam Ravnborg
2023-01-08 9:29 ` Sam Ravnborg
2023-01-09 10:12 ` Robin van der Gracht
2023-01-09 10:12 ` Robin van der Gracht
2023-01-09 10:12 ` Robin van der Gracht
2023-03-19 13:44 ` Stephen Kitt
2023-03-19 13:44 ` Stephen Kitt
2023-03-19 13:44 ` Stephen Kitt
2023-03-19 18:44 ` Sam Ravnborg
2023-03-19 18:44 ` Sam Ravnborg
2023-03-19 18:44 ` Sam Ravnborg
2023-01-07 18:26 ` [PATCH 13/15] backlight: omap1: Use backlight helpers Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:32 ` Stephen Kitt
2023-01-08 19:32 ` Stephen Kitt
2023-01-08 19:32 ` Stephen Kitt
2023-01-09 11:02 ` Daniel Thompson
2023-01-09 11:02 ` Daniel Thompson
2023-01-09 11:02 ` Daniel Thompson
2023-01-19 21:54 ` Lee Jones
2023-01-19 21:59 ` Konstantin Ryabitsev
2023-01-20 8:10 ` Lee Jones
2023-01-07 18:26 ` [PATCH 14/15] backlight: tosa: Use backlight helper Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-09 11:04 ` Daniel Thompson
2023-01-09 11:04 ` Daniel Thompson
2023-01-09 11:04 ` Daniel Thompson
2023-01-07 18:26 ` [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-07 18:26 ` Sam Ravnborg
2023-01-07 18:26 ` Sam Ravnborg via B4 Submission Endpoint
2023-01-08 19:32 ` Stephen Kitt
2023-01-08 19:32 ` Stephen Kitt
2023-01-08 19:32 ` Stephen Kitt
2023-01-09 11:06 ` Daniel Thompson
2023-01-09 11:06 ` Daniel Thompson
2023-01-09 11:06 ` Daniel Thompson
2023-01-09 16:27 ` Sam Ravnborg
2023-01-09 16:27 ` Sam Ravnborg
2023-01-09 16:27 ` Sam Ravnborg
2023-01-10 10:09 ` Lee Jones
2023-01-10 10:09 ` Lee Jones
2023-01-10 10:09 ` Lee Jones
2023-01-26 14:27 ` Lee Jones
2023-01-26 14:27 ` Lee Jones
2023-01-26 14:27 ` Lee Jones
2023-01-26 16:11 ` Sam Ravnborg
2023-01-26 16:11 ` Sam Ravnborg
2023-01-26 16:11 ` Sam Ravnborg
2023-01-26 16:30 ` Lee Jones
2023-01-26 16:30 ` Lee Jones
2023-01-26 16:30 ` Lee Jones
2023-01-09 11:18 ` [PATCH 00/15] backlight: Drop use of " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7v2vJtsWuhhiB2b@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adaplas@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=benh@kernel.crashing.org \
--cc=claudiu.beznea@microchip.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicolas.ferre@microchip.com \
--cc=ojeda@kernel.org \
--cc=paulus@samba.org \
--cc=robin@protonic.nl \
--cc=sam@ravnborg.org \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.