Re: [PATCH v2] drm: rcar-du: depend on DRM_RCAR_DU for components on that SoC

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] drm: rcar-du: depend on DRM_RCAR_DU for components on that SoC
Date: Wed, 18 Jan 2023 21:16:25 +0200	[thread overview]
Message-ID: <Y8hFiZVPi8XCRPxa@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20230108060401.391061-1-pbrobinson@gmail.com>

Hi Peter,

Thank you for the patch.

On Sun, Jan 08, 2023 at 06:04:01AM +0000, Peter Robinson wrote:
> There's a few components in the rcar-du drm directory that
> don't make sense to be selectable if DRM_RCAR_DU isn't because
> they are part of the IP block so add a dependency and add
> compile check to ensure they're still tested.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
> 
> v2:
> - typo fix in commit message
> - s/ARCH_RENESAS/DRM_RCAR_DU
> 
>  drivers/gpu/drm/rcar-du/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> index b2bddbeca878..362fb6099e9f 100644
> --- a/drivers/gpu/drm/rcar-du/Kconfig
> +++ b/drivers/gpu/drm/rcar-du/Kconfig
> @@ -25,6 +25,7 @@ config DRM_RCAR_CMM
>  config DRM_RCAR_DW_HDMI
>  	tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support"
>  	depends on DRM && OF
> +	depends on DRM_RCAR_DU || COMPILE_TEST

How about dropping COMPILE_TEST ? DRM_RCAR_DU itself has

	depends on ARCH_RENESAS || COMPILE_TEST

so if COMPILE_TEST is set we'll be able to test these drivers when
DRM_RCAR_DU is enabled. Same below.

I can update this when taking the patch in my tree, there's no need to
send a v3.

>  	select DRM_DW_HDMI
>  	help
>  	  Enable support for R-Car Gen3 or RZ/G2 internal HDMI encoder.
> @@ -32,6 +33,7 @@ config DRM_RCAR_DW_HDMI
>  config DRM_RCAR_USE_LVDS
>  	bool "R-Car DU LVDS Encoder Support"
>  	depends on DRM_BRIDGE && OF
> +	depends on DRM_RCAR_DU || COMPILE_TEST
>  	default DRM_RCAR_DU
>  	help
>  	  Enable support for the R-Car Display Unit embedded LVDS encoders.
> @@ -45,6 +47,7 @@ config DRM_RCAR_LVDS
>  config DRM_RCAR_USE_MIPI_DSI
>  	bool "R-Car DU MIPI DSI Encoder Support"
>  	depends on DRM_BRIDGE && OF
> +	depends on DRM_RCAR_DU || COMPILE_TEST
>  	default DRM_RCAR_DU
>  	help
>  	  Enable support for the R-Car Display Unit embedded MIPI DSI encoders.

-- 
Regards,

Laurent Pinchart