Re: [PATCH 2/2] tcg: use QTree instead of GTree

From: Emilio Cota <cota@braap.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 2/2] tcg: use QTree instead of GTree
Date: Sun, 5 Feb 2023 11:41:37 -0500	[thread overview]
Message-ID: <Y9/cQX8rXCAt0Own@cota-l14> (raw)
In-Reply-To: <b105124a-4711-29d1-81bd-b3929ff74651@linaro.org>

On Mon, Jan 30, 2023 at 09:09:47 -1000, Richard Henderson wrote:
> On 1/29/23 23:27, Daniel P. Berrangé wrote:
> > On Sun, Jan 29, 2023 at 05:38:08PM -0500, Emilio Cota wrote:
> > > Since this is a correctness issue, I think we should ship with qtree
> > > and use it when configuring with glib <2.76.0. For later glib versions
> > > we would just use gtree, e.g. via typedef + inline functions.
> > > 
> > > Once the minimum glib required by the configure script is >= 2.76.0,
> > > then we'd remove qtree.
> > > 
> > > If that sounds like a good plan, I can send a v2.
> > 
> > I'm fine with it, but be good to have an opinion here from the TCG
> > subsystem maintainers, CC'ing them
> 
> I agree the correctness issue wants the fix now,
> and typedef + inlines sounds like a good way moving forward.

Thanks, just sent a v2 implementing the above.

		Emilio