From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Emilio Cota" <cota@braap.org>,
qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 2/2] tcg: use QTree instead of GTree
Date: Wed, 25 Jan 2023 15:58:25 +0000 [thread overview]
Message-ID: <Y9FRoUI3I5LfQsjW@redhat.com> (raw)
In-Reply-To: <Y76s1VNBUYwlpIGo@redhat.com>
On Wed, Jan 11, 2023 at 12:34:29PM +0000, Daniel P. Berrangé wrote:
> On Tue, Jan 10, 2023 at 10:55:36PM -0500, Emilio Cota wrote:
> > qemu-user can hang in a multi-threaded fork. One common
> > reason is that when creating a TB, between fork and exec
> > we manipulate a GTree whose memory allocator (GSlice) is
> > not fork-safe.
>
> BTW, I just checked latest glib status
>
> https://gitlab.gnome.org/GNOME/glib/-/issues/1079
>
> it appears they're pretty close to deciding to delete the
> GSlice impl and always use system malloc.
They have now merged the code to delete the GSlice custom allocator.
So glib >= 2.76.0 should not exhibit a hang
> So if we do take this patch series it'll hopefully be a time
> limited thing to carry.
So the question is whether the issue is critical enough that we want
to carry a workaround for a while, vs telling users to upgrade to
newer glib (once 2.76 actually gets released)
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-01-25 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 3:55 [PATCH 0/2] fix for #285 Emilio Cota
2023-01-11 3:55 ` [PATCH 1/2] util: import GTree as QTree Emilio Cota
2023-01-11 12:08 ` Daniel P. Berrangé
2023-01-29 22:28 ` Emilio Cota
2023-01-11 3:55 ` [PATCH 2/2] tcg: use QTree instead of GTree Emilio Cota
2023-01-11 12:10 ` Daniel P. Berrangé
2023-01-29 22:32 ` Emilio Cota
2023-01-11 12:34 ` Daniel P. Berrangé
2023-01-25 15:58 ` Daniel P. Berrangé [this message]
2023-01-29 22:38 ` Emilio Cota
2023-01-30 9:27 ` Daniel P. Berrangé
2023-01-30 19:09 ` Richard Henderson
2023-02-05 16:41 ` Emilio Cota
2023-01-11 12:26 ` [PATCH 0/2] fix for #285 Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9FRoUI3I5LfQsjW@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.