From: Ido Schimmel <idosch@nvidia.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: Petr Machata <petrm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Roopa Prabhu <roopa@nvidia.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next 08/16] net: bridge: Add netlink knobs for number / maximum MDB entries
Date: Sun, 29 Jan 2023 16:58:42 +0200 [thread overview]
Message-ID: <Y9aJom7VhuqY+1+X@shredder> (raw)
In-Reply-To: <e46f0af5-ef19-5260-5524-e53b4e4438f1@blackwall.org>
Thanks for the review, Nik!
On Sun, Jan 29, 2023 at 12:07:31PM +0200, Nikolay Aleksandrov wrote:
> On 26/01/2023 19:01, Petr Machata wrote:
> > +static int
> > +br_multicast_pmctx_ngroups_set_max(struct net_bridge_mcast_port *pmctx,
> > + u32 max, struct netlink_ext_ack *extack)
> > +{
> > + if (max && max < pmctx->mdb_n_entries) {
> > + NL_SET_ERR_MSG_FMT_MOD(extack, "Can't set mcast_max_groups=%u, which is below mcast_n_groups=%u",
> > + max, pmctx->mdb_n_entries);
>
> Why not? All new entries will be rejected anyway, at most some will expire and make room.
Looking at the code of the global limit ('mcast_hash_max') and also
testing it, I see that the above is not enforced there either so doing
what you suggest will at least make the port and port-vlan limits
consistent with the global limit in this regard.
>
> > + return -EINVAL;
> > + }
> > +
> > + pmctx->mdb_max_entries = max;
> > + return 0;
> > +}
WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@nvidia.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: Petr Machata <petrm@nvidia.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Eric Dumazet <edumazet@google.com>,
Roopa Prabhu <roopa@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net-next 08/16] net: bridge: Add netlink knobs for number / maximum MDB entries
Date: Sun, 29 Jan 2023 16:58:42 +0200 [thread overview]
Message-ID: <Y9aJom7VhuqY+1+X@shredder> (raw)
In-Reply-To: <e46f0af5-ef19-5260-5524-e53b4e4438f1@blackwall.org>
Thanks for the review, Nik!
On Sun, Jan 29, 2023 at 12:07:31PM +0200, Nikolay Aleksandrov wrote:
> On 26/01/2023 19:01, Petr Machata wrote:
> > +static int
> > +br_multicast_pmctx_ngroups_set_max(struct net_bridge_mcast_port *pmctx,
> > + u32 max, struct netlink_ext_ack *extack)
> > +{
> > + if (max && max < pmctx->mdb_n_entries) {
> > + NL_SET_ERR_MSG_FMT_MOD(extack, "Can't set mcast_max_groups=%u, which is below mcast_n_groups=%u",
> > + max, pmctx->mdb_n_entries);
>
> Why not? All new entries will be rejected anyway, at most some will expire and make room.
Looking at the code of the global limit ('mcast_hash_max') and also
testing it, I see that the above is not enforced there either so doing
what you suggest will at least make the port and port-vlan limits
consistent with the global limit in this regard.
>
> > + return -EINVAL;
> > + }
> > +
> > + pmctx->mdb_max_entries = max;
> > + return 0;
> > +}
next prev parent reply other threads:[~2023-01-29 14:59 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 17:01 [PATCH net-next 00/16] bridge: Limit number of MDB entries per port, port-vlan Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-26 17:01 ` [PATCH net-next 01/16] net: bridge: Set strict_start_type at two policies Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-26 19:18 ` Stephen Hemminger
2023-01-26 19:18 ` [Bridge] " Stephen Hemminger
2023-01-26 20:27 ` Nikolay Aleksandrov
2023-01-26 20:27 ` [Bridge] " Nikolay Aleksandrov
2023-01-29 9:09 ` Nikolay Aleksandrov
2023-01-29 9:09 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 17:01 ` [PATCH net-next 02/16] net: bridge: Add extack to br_multicast_new_port_group() Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 9:09 ` Nikolay Aleksandrov
2023-01-29 9:09 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 17:01 ` [PATCH net-next 03/16] net: bridge: Move extack-setting " Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 9:09 ` Nikolay Aleksandrov
2023-01-29 9:09 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 17:01 ` [PATCH net-next 04/16] net: bridge: Add br_multicast_del_port_group() Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 9:11 ` Nikolay Aleksandrov
2023-01-29 9:11 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 17:01 ` [PATCH net-next 05/16] net: bridge: Change a cleanup in br_multicast_new_port_group() to goto Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 9:11 ` Nikolay Aleksandrov
2023-01-29 9:11 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 17:01 ` [PATCH net-next 06/16] net: bridge: Add a tracepoint for MDB overflows Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-26 17:53 ` Steven Rostedt
2023-01-26 17:53 ` [Bridge] " Steven Rostedt
2023-01-27 14:29 ` Petr Machata
2023-01-27 14:29 ` [Bridge] " Petr Machata
2023-01-30 15:50 ` Petr Machata
2023-01-30 15:50 ` [Bridge] " Petr Machata
2023-01-30 23:23 ` Steven Rostedt
2023-01-30 23:23 ` [Bridge] " Steven Rostedt
2023-01-26 17:01 ` [PATCH net-next 07/16] net: bridge: Maintain number of MDB entries in net_bridge_mcast_port Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 9:40 ` Nikolay Aleksandrov
2023-01-29 9:40 ` [Bridge] " Nikolay Aleksandrov
2023-01-29 16:55 ` Nikolay Aleksandrov
2023-01-29 16:55 ` [Bridge] " Nikolay Aleksandrov
2023-01-30 8:08 ` Ido Schimmel
2023-01-30 8:08 ` [Bridge] " Ido Schimmel
2023-01-30 8:56 ` Nikolay Aleksandrov
2023-01-30 8:56 ` [Bridge] " Nikolay Aleksandrov
2023-01-30 15:02 ` Petr Machata
2023-01-30 15:02 ` [Bridge] " Petr Machata
2023-01-26 17:01 ` [PATCH net-next 08/16] net: bridge: Add netlink knobs for number / maximum MDB entries Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 10:07 ` Nikolay Aleksandrov
2023-01-29 10:07 ` [Bridge] " Nikolay Aleksandrov
2023-01-29 14:58 ` Ido Schimmel [this message]
2023-01-29 14:58 ` Ido Schimmel
2023-01-30 11:07 ` Petr Machata
2023-01-30 11:07 ` [Bridge] " Petr Machata
2023-01-26 17:01 ` [PATCH net-next 09/16] selftests: forwarding: Move IGMP- and MLD-related functions to lib Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 10:08 ` Nikolay Aleksandrov
2023-01-29 10:08 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 17:01 ` [PATCH net-next 10/16] selftests: forwarding: bridge_mdb: Fix a typo Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 10:09 ` Nikolay Aleksandrov
2023-01-29 10:09 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 17:01 ` [PATCH net-next 11/16] selftests: forwarding: lib: Add helpers for IP address handling Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 10:09 ` Nikolay Aleksandrov
2023-01-29 10:09 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 17:01 ` [PATCH net-next 12/16] selftests: forwarding: lib: Add helpers for checksum handling Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 10:10 ` Nikolay Aleksandrov
2023-01-29 10:10 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 17:01 ` [PATCH net-next 13/16] selftests: forwarding: lib: Parameterize IGMPv3/MLDv2 generation Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 10:10 ` Nikolay Aleksandrov
2023-01-29 10:10 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 17:01 ` [PATCH net-next 14/16] selftests: forwarding: lib: Allow list of IPs for IGMPv3/MLDv2 Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 10:11 ` Nikolay Aleksandrov
2023-01-29 10:11 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 17:01 ` [PATCH net-next 15/16] selftests: forwarding: lib: Add helpers to build IGMP/MLD leave packets Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 10:11 ` Nikolay Aleksandrov
2023-01-29 10:11 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 17:01 ` [PATCH net-next 16/16] selftests: forwarding: bridge_mdb_max: Add a new selftest Petr Machata
2023-01-26 17:01 ` [Bridge] " Petr Machata
2023-01-29 10:12 ` Nikolay Aleksandrov
2023-01-29 10:12 ` [Bridge] " Nikolay Aleksandrov
2023-01-26 20:28 ` [PATCH net-next 00/16] bridge: Limit number of MDB entries per port, port-vlan Nikolay Aleksandrov
2023-01-26 20:28 ` [Bridge] " Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9aJom7VhuqY+1+X@shredder \
--to=idosch@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.