From: Tejun Heo <tj@kernel.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Zefan Li" <lizefan.x@bytedance.com>,
"Dave Airlie" <airlied@redhat.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Rob Clark" <robdclark@chromium.org>,
"Stéphane Marchesin" <marcheu@chromium.org>,
"T . J . Mercier" <tjmercier@google.com>,
Kenny.Ho@amd.com, "Christian König" <christian.koenig@amd.com>,
"Brian Welty" <brian.welty@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>
Subject: Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control
Date: Thu, 2 Feb 2023 10:00:14 -1000 [thread overview]
Message-ID: <Y9wWTspETnYYodDc@slm.duckdns.org> (raw)
In-Reply-To: <27b7882e-1201-b173-6f56-9ececb5780e8@linux.intel.com>
Hello,
On Thu, Feb 02, 2023 at 02:26:06PM +0000, Tvrtko Ursulin wrote:
> When you say active/inactive - to what you are referring in the cgroup
> world? Offline/online? For those my understanding was offline was a
> temporary state while css is getting destroyed.
Oh, it's just based on activity. So, for example, iocost puts a cgroup on
its active list which is canned periodically when an IO is issued from an
inactive cgroup. If an active cgroup doesn't have any activity between two
scans, it becomes inactive and dropped from the list. drm can prolly use the
same approach?
> Also, I am really postponing implementing those changes until I hear at
> least something from the DRM community.
Yeah, that sounds like a good idea.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: "Rob Clark" <robdclark@chromium.org>,
Kenny.Ho@amd.com, "Dave Airlie" <airlied@redhat.com>,
"Stéphane Marchesin" <marcheu@chromium.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
Intel-gfx@lists.freedesktop.org,
"Brian Welty" <brian.welty@intel.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@intel.com>,
"Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
cgroups@vger.kernel.org, "T . J . Mercier" <tjmercier@google.com>
Subject: Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control
Date: Thu, 2 Feb 2023 10:00:14 -1000 [thread overview]
Message-ID: <Y9wWTspETnYYodDc@slm.duckdns.org> (raw)
In-Reply-To: <27b7882e-1201-b173-6f56-9ececb5780e8@linux.intel.com>
Hello,
On Thu, Feb 02, 2023 at 02:26:06PM +0000, Tvrtko Ursulin wrote:
> When you say active/inactive - to what you are referring in the cgroup
> world? Offline/online? For those my understanding was offline was a
> temporary state while css is getting destroyed.
Oh, it's just based on activity. So, for example, iocost puts a cgroup on
its active list which is canned periodically when an IO is issued from an
inactive cgroup. If an active cgroup doesn't have any activity between two
scans, it becomes inactive and dropped from the list. drm can prolly use the
same approach?
> Also, I am really postponing implementing those changes until I hear at
> least something from the DRM community.
Yeah, that sounds like a good idea.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: "Rob Clark" <robdclark@chromium.org>,
Kenny.Ho@amd.com, "Dave Airlie" <airlied@redhat.com>,
"Stéphane Marchesin" <marcheu@chromium.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
Intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>,
"Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
cgroups@vger.kernel.org, "T . J . Mercier" <tjmercier@google.com>
Subject: Re: [Intel-gfx] [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control
Date: Thu, 2 Feb 2023 10:00:14 -1000 [thread overview]
Message-ID: <Y9wWTspETnYYodDc@slm.duckdns.org> (raw)
In-Reply-To: <27b7882e-1201-b173-6f56-9ececb5780e8@linux.intel.com>
Hello,
On Thu, Feb 02, 2023 at 02:26:06PM +0000, Tvrtko Ursulin wrote:
> When you say active/inactive - to what you are referring in the cgroup
> world? Offline/online? For those my understanding was offline was a
> temporary state while css is getting destroyed.
Oh, it's just based on activity. So, for example, iocost puts a cgroup on
its active list which is canned periodically when an IO is issued from an
inactive cgroup. If an active cgroup doesn't have any activity between two
scans, it becomes inactive and dropped from the list. drm can prolly use the
same approach?
> Also, I am really postponing implementing those changes until I hear at
> least something from the DRM community.
Yeah, that sounds like a good idea.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Tvrtko Ursulin <tvrtko.ursulin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Johannes Weiner"
<hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
"Zefan Li" <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
"Dave Airlie" <airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Daniel Vetter" <daniel.vetter-/w4YWyX8dFk@public.gmane.org>,
"Rob Clark" <robdclark-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"Stéphane Marchesin"
<marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"T . J . Mercier"
<tjmercier-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Kenny.Ho-5C7GfCeVMHo@public.gmane.org,
"Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>,
"Brian Welty"
<brian.welty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Tvrtko Ursulin"
<tvrtko.ursulin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control
Date: Thu, 2 Feb 2023 10:00:14 -1000 [thread overview]
Message-ID: <Y9wWTspETnYYodDc@slm.duckdns.org> (raw)
In-Reply-To: <27b7882e-1201-b173-6f56-9ececb5780e8-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Hello,
On Thu, Feb 02, 2023 at 02:26:06PM +0000, Tvrtko Ursulin wrote:
> When you say active/inactive - to what you are referring in the cgroup
> world? Offline/online? For those my understanding was offline was a
> temporary state while css is getting destroyed.
Oh, it's just based on activity. So, for example, iocost puts a cgroup on
its active list which is canned periodically when an IO is issued from an
inactive cgroup. If an active cgroup doesn't have any activity between two
scans, it becomes inactive and dropped from the list. drm can prolly use the
same approach?
> Also, I am really postponing implementing those changes until I hear at
> least something from the DRM community.
Yeah, that sounds like a good idea.
Thanks.
--
tejun
next prev parent reply other threads:[~2023-02-02 20:00 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 16:55 [Intel-gfx] [RFC v3 00/12] DRM scheduling cgroup controller Tvrtko Ursulin
2023-01-12 16:55 ` Tvrtko Ursulin
2023-01-12 16:55 ` Tvrtko Ursulin
2023-01-12 16:55 ` Tvrtko Ursulin
2023-01-12 16:55 ` [RFC 01/12] drm: Track clients by tgid and not tid Tvrtko Ursulin
2023-01-12 16:55 ` Tvrtko Ursulin
2023-01-12 16:55 ` Tvrtko Ursulin
2023-01-12 16:55 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-12 16:55 ` [RFC 02/12] drm: Update file owner during use Tvrtko Ursulin
2023-01-12 16:55 ` Tvrtko Ursulin
2023-01-12 16:55 ` Tvrtko Ursulin
2023-01-12 16:55 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-12 16:56 ` [RFC 03/12] cgroup: Add the DRM cgroup controller Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-12 16:56 ` [RFC 04/12] drm/cgroup: Track clients per owning process Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-17 16:03 ` Stanislaw Gruszka
2023-01-17 16:03 ` Stanislaw Gruszka
2023-01-17 16:03 ` [Intel-gfx] " Stanislaw Gruszka
2023-01-17 16:03 ` Stanislaw Gruszka
2023-01-17 16:25 ` Tvrtko Ursulin
2023-01-17 16:25 ` Tvrtko Ursulin
2023-01-17 16:25 ` Tvrtko Ursulin
2023-01-17 16:25 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-12 16:56 ` [RFC 05/12] drm/cgroup: Allow safe external access to file_priv Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-12 16:56 ` [RFC 06/12] drm/cgroup: Add ability to query drm cgroup GPU time Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-12 16:56 ` [RFC 07/12] drm/cgroup: Add over budget signalling callback Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-12 16:56 ` [RFC 08/12] drm/cgroup: Only track clients which are providing drm_cgroup_ops Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-12 16:56 ` [RFC 09/12] cgroup/drm: Client exit hook Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-12 16:56 ` [RFC 10/12] cgroup/drm: Introduce weight based drm cgroup control Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-14 21:20 ` kernel test robot
2023-01-27 13:01 ` Michal Koutný
2023-01-27 13:01 ` Michal Koutný
2023-01-27 13:01 ` [Intel-gfx] " Michal Koutný
2023-01-27 13:01 ` Michal Koutný
2023-01-27 13:31 ` Tvrtko Ursulin
2023-01-27 13:31 ` Tvrtko Ursulin
2023-01-27 13:31 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-27 13:31 ` Tvrtko Ursulin
2023-01-27 14:11 ` Michal Koutný
2023-01-27 14:11 ` [Intel-gfx] " Michal Koutný
2023-01-27 14:11 ` Michal Koutný
2023-01-27 15:21 ` Tvrtko Ursulin
2023-01-27 15:21 ` Tvrtko Ursulin
2023-01-27 15:21 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-27 15:21 ` Tvrtko Ursulin
2023-01-28 1:11 ` Tejun Heo
2023-01-28 1:11 ` Tejun Heo
2023-01-28 1:11 ` [Intel-gfx] " Tejun Heo
2023-01-28 1:11 ` Tejun Heo
2023-02-02 14:26 ` Tvrtko Ursulin
2023-02-02 14:26 ` Tvrtko Ursulin
2023-02-02 14:26 ` [Intel-gfx] " Tvrtko Ursulin
2023-02-02 14:26 ` Tvrtko Ursulin
2023-02-02 20:00 ` Tejun Heo [this message]
2023-02-02 20:00 ` Tejun Heo
2023-02-02 20:00 ` [Intel-gfx] " Tejun Heo
2023-02-02 20:00 ` Tejun Heo
2023-01-12 16:56 ` [RFC 11/12] drm/i915: Wire up with drm controller GPU time query Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-12 16:56 ` [RFC 12/12] drm/i915: Implement cgroup controller over budget throttling Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` Tvrtko Ursulin
2023-01-12 16:56 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-12 17:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DRM scheduling cgroup controller (rev3) Patchwork
2023-01-12 18:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-01-13 6:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-01-23 15:42 ` [RFC v3 00/12] DRM scheduling cgroup controller Michal Koutný
2023-01-23 15:42 ` Michal Koutný
2023-01-23 15:42 ` [Intel-gfx] " Michal Koutný
2023-01-23 15:42 ` Michal Koutný
2023-01-25 18:11 ` Tvrtko Ursulin
2023-01-25 18:11 ` Tvrtko Ursulin
2023-01-25 18:11 ` Tvrtko Ursulin
2023-01-25 18:11 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-26 13:00 ` Michal Koutný
2023-01-26 13:00 ` Michal Koutný
2023-01-26 13:00 ` [Intel-gfx] " Michal Koutný
2023-01-26 13:00 ` Michal Koutný
2023-01-26 17:04 ` Tejun Heo
2023-01-26 17:04 ` Tejun Heo
2023-01-26 17:04 ` [Intel-gfx] " Tejun Heo
2023-01-26 17:04 ` Tejun Heo
2023-01-26 17:57 ` Tvrtko Ursulin
2023-01-26 17:57 ` Tvrtko Ursulin
2023-01-26 17:57 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-26 17:57 ` Tvrtko Ursulin
2023-01-26 18:14 ` Tvrtko Ursulin
2023-01-26 18:14 ` Tvrtko Ursulin
2023-01-26 18:14 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-26 18:14 ` Tvrtko Ursulin
2023-01-27 10:04 ` Michal Koutný
2023-01-27 10:04 ` Michal Koutný
2023-01-27 10:04 ` [Intel-gfx] " Michal Koutný
2023-01-27 10:04 ` Michal Koutný
2023-01-27 11:40 ` Tvrtko Ursulin
2023-01-27 11:40 ` Tvrtko Ursulin
2023-01-27 11:40 ` Tvrtko Ursulin
2023-01-27 11:40 ` [Intel-gfx] " Tvrtko Ursulin
2023-01-27 13:00 ` Michal Koutný
2023-01-27 13:00 ` [Intel-gfx] " Michal Koutný
2023-01-27 13:00 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9wWTspETnYYodDc@slm.duckdns.org \
--to=tj@kernel.org \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=Kenny.Ho@amd.com \
--cc=airlied@redhat.com \
--cc=brian.welty@intel.com \
--cc=cgroups@vger.kernel.org \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=marcheu@chromium.org \
--cc=robdclark@chromium.org \
--cc=tjmercier@google.com \
--cc=tvrtko.ursulin@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.