From: Daniel Vetter <daniel@ffwll.ch> To: Pekka Paalanen <ppaalanen@gmail.com> Cc: stylon.wang@amd.com, thong.thai@amd.com, shashank.sharma@amd.com, dri-devel@lists.freedesktop.org, nicholas.kazlauskas@amd.com, Aurabindo Pillai <aurabindo.pillai@amd.com>, amd-gfx@lists.freedesktop.org, wayne.lin@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com Subject: Re: [PATCH 0/3] Experimental freesync video mode optimization Date: Fri, 22 Jan 2021 10:42:53 +0100 [thread overview] Message-ID: <YAqeHZlDBrgALLo9@phenom.ffwll.local> (raw) In-Reply-To: <20210122103248.779e70bf@eldfell> On Fri, Jan 22, 2021 at 10:32:48AM +0200, Pekka Paalanen wrote: > On Tue, 19 Jan 2021 10:50:26 -0500 > Aurabindo Pillai <aurabindo.pillai@amd.com> wrote: > > > Changes in V5 > > ============= > > > > * More info in commit messages on the rationale of changes being added > > to the kernel. > > * Minor fixes > > Hi, > > thank you for adding the explanations in the commit messages I asked > for. It is now up to DRM maintainers to determine if this is > conceptually fine. > > I do see that apparently setting the opt-in option does not yet taint > the kernel although Daniel Vetter suggested it might be a good idea. I > guess tainting the kernel would make it easier to remove this feature > in the future because it would be easier to dismiss people that claim a > kernel regression due to the removal. Reading the descriptions I'm honestly not sure why this isn't enabled by default? Maybe the explanations should also capture why this is maybe not a good idea ... -Daniel > > > Thanks, > pq > > > > -- > > > > This patchset enables freesync video mode usecase where the userspace > > can request a freesync compatible video mode such that switching to this > > mode does not trigger blanking. > > > > This feature is guarded by a module parameter which is disabled by > > default. Enabling this paramters adds additional modes to the driver > > modelist, and also enables the optimization to skip modeset when using > > one of these modes. > > > > -- > > > > Aurabindo Pillai (3): > > drm/amd/display: Add module parameter for freesync video mode > > drm/amd/display: Add freesync video modes based on preferred modes > > drm/amd/display: Skip modeset for front porch change > > > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 + > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 401 ++++++++++++++++-- > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 + > > 4 files changed, 382 insertions(+), 35 deletions(-) > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: Pekka Paalanen <ppaalanen@gmail.com> Cc: stylon.wang@amd.com, thong.thai@amd.com, shashank.sharma@amd.com, dri-devel@lists.freedesktop.org, nicholas.kazlauskas@amd.com, Aurabindo Pillai <aurabindo.pillai@amd.com>, amd-gfx@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>, wayne.lin@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com Subject: Re: [PATCH 0/3] Experimental freesync video mode optimization Date: Fri, 22 Jan 2021 10:42:53 +0100 [thread overview] Message-ID: <YAqeHZlDBrgALLo9@phenom.ffwll.local> (raw) In-Reply-To: <20210122103248.779e70bf@eldfell> On Fri, Jan 22, 2021 at 10:32:48AM +0200, Pekka Paalanen wrote: > On Tue, 19 Jan 2021 10:50:26 -0500 > Aurabindo Pillai <aurabindo.pillai@amd.com> wrote: > > > Changes in V5 > > ============= > > > > * More info in commit messages on the rationale of changes being added > > to the kernel. > > * Minor fixes > > Hi, > > thank you for adding the explanations in the commit messages I asked > for. It is now up to DRM maintainers to determine if this is > conceptually fine. > > I do see that apparently setting the opt-in option does not yet taint > the kernel although Daniel Vetter suggested it might be a good idea. I > guess tainting the kernel would make it easier to remove this feature > in the future because it would be easier to dismiss people that claim a > kernel regression due to the removal. Reading the descriptions I'm honestly not sure why this isn't enabled by default? Maybe the explanations should also capture why this is maybe not a good idea ... -Daniel > > > Thanks, > pq > > > > -- > > > > This patchset enables freesync video mode usecase where the userspace > > can request a freesync compatible video mode such that switching to this > > mode does not trigger blanking. > > > > This feature is guarded by a module parameter which is disabled by > > default. Enabling this paramters adds additional modes to the driver > > modelist, and also enables the optimization to skip modeset when using > > one of these modes. > > > > -- > > > > Aurabindo Pillai (3): > > drm/amd/display: Add module parameter for freesync video mode > > drm/amd/display: Add freesync video modes based on preferred modes > > drm/amd/display: Skip modeset for front porch change > > > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 12 + > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 401 ++++++++++++++++-- > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 + > > 4 files changed, 382 insertions(+), 35 deletions(-) > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-01-22 9:43 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-19 15:50 [PATCH 0/3] Experimental freesync video mode optimization Aurabindo Pillai 2021-01-19 15:50 ` Aurabindo Pillai 2021-01-19 15:50 ` [PATCH 1/3] drm/amd/display: Add module parameter for freesync video mode Aurabindo Pillai 2021-01-19 15:50 ` Aurabindo Pillai 2021-01-19 15:50 ` [PATCH 2/3] drm/amd/display: Add freesync video modes based on preferred modes Aurabindo Pillai 2021-01-19 15:50 ` Aurabindo Pillai 2021-01-19 15:50 ` [PATCH 3/3] drm/amd/display: Skip modeset for front porch change Aurabindo Pillai 2021-01-19 15:50 ` Aurabindo Pillai 2021-01-21 19:05 ` Kazlauskas, Nicholas 2021-01-21 19:05 ` Kazlauskas, Nicholas 2021-01-25 4:00 ` Aurabindo Pillai 2021-01-25 4:00 ` Aurabindo Pillai 2021-02-08 15:06 ` Kazlauskas, Nicholas 2021-02-08 15:06 ` Kazlauskas, Nicholas 2021-02-12 20:01 ` Aurabindo Pillai 2021-02-12 20:01 ` Aurabindo Pillai 2021-01-22 8:32 ` [PATCH 0/3] Experimental freesync video mode optimization Pekka Paalanen 2021-01-22 8:32 ` Pekka Paalanen 2021-01-22 9:42 ` Daniel Vetter [this message] 2021-01-22 9:42 ` Daniel Vetter 2021-01-22 9:44 ` Daniel Vetter 2021-01-22 9:44 ` Daniel Vetter 2021-01-22 15:16 ` Alex Deucher 2021-01-22 15:16 ` Alex Deucher 2021-02-02 14:27 ` Daniel Vetter 2021-02-02 14:27 ` Daniel Vetter -- strict thread matches above, loose matches on Subject: below -- 2020-12-10 2:45 Aurabindo Pillai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YAqeHZlDBrgALLo9@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=aurabindo.pillai@amd.com \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=nicholas.kazlauskas@amd.com \ --cc=ppaalanen@gmail.com \ --cc=shashank.sharma@amd.com \ --cc=stylon.wang@amd.com \ --cc=thong.thai@amd.com \ --cc=wayne.lin@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.