Re: [PATCH 2/2] dt-bindings: display: Add "disable-hpd" binding

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mykyta Poturai <ddone@aruko.org>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: display: Add "disable-hpd" binding
Date: Tue, 9 Feb 2021 02:55:19 +0200	[thread overview]
Message-ID: <YCHdd1msOsodLn+v@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210131095701.965147-1-ddone@aruko.org>

Hi Mykyta,

Thank you for the patch.

On Sun, Jan 31, 2021 at 11:57:01AM +0200, Mykyta Poturai wrote:
> Add the "disable-hpd" binding, used to disable hotplug detected
> functionality in the driver. When it's enabled the driver assumes that
> the connector is always connected and disables the hotplug detect
> related IRQ.
> 
> Signed-off-by: Mykyta Poturai <ddone@aruko.org>
> ---
>  .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt       | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> index 3f6072651182..b2b899f46b86 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> @@ -39,6 +39,7 @@ Optional properties:
>  
>  - power-domains: Shall reference the power domain that contains the DWC HDMI,
>    if any.
> +- disable-hpd: Disables the hotplug detect feature

A similar property has been added to the ti,sn65dsi86 bindings in commit
1dbc979172af ("dt-bindings: drm/bridge: ti-sn65dsi86: Document no-hpd").
A property with the same name exists in panel-common.yaml. Could we
standardize on that name ?

The description should also explain the hardware architecture, not the
driver behaviour. This is what the ti,sn65dsi86 binding documents:

  no-hpd:
    type: boolean
    description:
      Set if the HPD line on the bridge isn't hooked up to anything or is
      otherwise unusable.

You could use the same description, assuming this is the use case you
want to support. Could you perhaps describe your problem in a bit more
details ? Do you have a system with an HDMI panel that is always
connected, with the HPD signal of the dw-hdmi not connected ?

>  Example:

-- 
Regards,

Laurent Pinchart