From: "Krzysztof Wilczyński" <kw@linux.com>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3] PCI: mediatek: Configure FC and FTS for functions other than 0
Date: Sun, 21 Feb 2021 20:29:02 +0100 [thread overview]
Message-ID: <YDK0fr/UiKjit+ty@rocinante> (raw)
In-Reply-To: <c529dbfc066f4bda9b87edbdbf771f207e69b84e.1604510053.git.ryder.lee@mediatek.com>
[+cc Lorenzo for visiblity]
Hi,
Thank you for taking care of this!
[...]
> PCI_FUNC(port->slot << 3)" is always 0, so previously
> mtk_pcie_startup_port() only configured FC credits and FTs for
> function 0.
[...]
A small nit. The commit message is missing the opening quote, see
Bjorn's suggestion:
https://lore.kernel.org/linux-pci/20201104131054.GA307984@bjorn-Precision-5520/
But, it's probably not worth sending another patch, and perhaps either
Bjorn or Lorenzo could fix this when applying changes.
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: linux-pci@vger.kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <helgaas@kernel.org>,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v3] PCI: mediatek: Configure FC and FTS for functions other than 0
Date: Sun, 21 Feb 2021 20:29:02 +0100 [thread overview]
Message-ID: <YDK0fr/UiKjit+ty@rocinante> (raw)
In-Reply-To: <c529dbfc066f4bda9b87edbdbf771f207e69b84e.1604510053.git.ryder.lee@mediatek.com>
[+cc Lorenzo for visiblity]
Hi,
Thank you for taking care of this!
[...]
> PCI_FUNC(port->slot << 3)" is always 0, so previously
> mtk_pcie_startup_port() only configured FC credits and FTs for
> function 0.
[...]
A small nit. The commit message is missing the opening quote, see
Bjorn's suggestion:
https://lore.kernel.org/linux-pci/20201104131054.GA307984@bjorn-Precision-5520/
But, it's probably not worth sending another patch, and perhaps either
Bjorn or Lorenzo could fix this when applying changes.
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-02-21 19:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 20:58 [PATCH v3] PCI: mediatek: Configure FC and FTS for functions other than 0 Ryder Lee
2020-11-04 20:58 ` Ryder Lee
2020-11-05 18:22 ` Frank Wunderlich
2020-11-05 18:22 ` Frank Wunderlich
2021-02-21 19:29 ` Krzysztof Wilczyński [this message]
2021-02-21 19:29 ` Krzysztof Wilczyński
2021-03-26 15:51 ` Lorenzo Pieralisi
2021-03-26 15:51 ` Lorenzo Pieralisi
2021-03-26 23:53 ` Krzysztof Wilczyński
2021-03-26 23:53 ` Krzysztof Wilczyński
2021-03-29 15:03 ` Lorenzo Pieralisi
2021-03-29 15:03 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDK0fr/UiKjit+ty@rocinante \
--to=kw@linux.com \
--cc=helgaas@kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.