All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Dirk Behme <Dirk.Behme@de.bosch.com>,
	Peter Erben <Peter.Erben@de.bosch.com>
Subject: Re: [PATCH 7/7] arm64: configs: Add R-Car DAB support
Date: Fri, 26 Feb 2021 14:52:51 +0200	[thread overview]
Message-ID: <YDjvI6DTcBfWdA3G@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210225225147.29920-8-fabrizio.castro.jz@renesas.com>

Hi Fabrizio,

Thank you for the patch.

On Thu, Feb 25, 2021 at 10:51:47PM +0000, Fabrizio Castro wrote:
> Make sure that the R-Car DAB device driver gets compiled as a
> module since R-Car E3 and R-Car M3-N come with the DAB IP.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

Do we need this in the defconfig ? It's not required to have a bootable
E3 or M3-N with the set of standard features, and would result in all
ARM64 platforms having one module they don't care about.

> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d612f633b771..3b9996c7f1fc 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -274,6 +274,7 @@ CONFIG_PCI_ENDPOINT_TEST=m
>  CONFIG_EEPROM_AT24=m
>  CONFIG_EEPROM_AT25=m
>  CONFIG_UACCE=m
> +CONFIG_RCAR_DAB=m
>  # CONFIG_SCSI_PROC_FS is not set
>  CONFIG_BLK_DEV_SD=y
>  CONFIG_SCSI_SAS_ATA=y

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Cc: devicetree@vger.kernel.org,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Peter Erben <Peter.Erben@de.bosch.com>,
	linux-kernel@vger.kernel.org,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	linux-renesas-soc@vger.kernel.org,
	Dirk Behme <Dirk.Behme@de.bosch.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-api@vger.kernel.org, Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/7] arm64: configs: Add R-Car DAB support
Date: Fri, 26 Feb 2021 14:52:51 +0200	[thread overview]
Message-ID: <YDjvI6DTcBfWdA3G@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210225225147.29920-8-fabrizio.castro.jz@renesas.com>

Hi Fabrizio,

Thank you for the patch.

On Thu, Feb 25, 2021 at 10:51:47PM +0000, Fabrizio Castro wrote:
> Make sure that the R-Car DAB device driver gets compiled as a
> module since R-Car E3 and R-Car M3-N come with the DAB IP.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

Do we need this in the defconfig ? It's not required to have a bootable
E3 or M3-N with the set of standard features, and would result in all
ARM64 platforms having one module they don't care about.

> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d612f633b771..3b9996c7f1fc 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -274,6 +274,7 @@ CONFIG_PCI_ENDPOINT_TEST=m
>  CONFIG_EEPROM_AT24=m
>  CONFIG_EEPROM_AT25=m
>  CONFIG_UACCE=m
> +CONFIG_RCAR_DAB=m
>  # CONFIG_SCSI_PROC_FS is not set
>  CONFIG_BLK_DEV_SD=y
>  CONFIG_SCSI_SAS_ATA=y

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-26 12:54 UTC|newest]

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 22:51 [PATCH 0/7] Add FFT Support for R-Car Gen3 devices Fabrizio Castro
2021-02-25 22:51 ` Fabrizio Castro
2021-02-25 22:51 ` [PATCH 1/7] clk: renesas: r8a77990: Add DAB clock Fabrizio Castro
2021-02-25 22:51   ` Fabrizio Castro
2021-02-26  8:34   ` Geert Uytterhoeven
2021-02-26  8:34     ` Geert Uytterhoeven
2021-03-01 14:47     ` Fabrizio Castro
2021-03-01 14:47       ` Fabrizio Castro
2021-03-03 10:22       ` Fabrizio Castro
2021-03-03 10:22         ` Fabrizio Castro
2021-02-25 22:51 ` [PATCH 2/7] clk: renesas: r8a77965: " Fabrizio Castro
2021-02-25 22:51   ` Fabrizio Castro
2021-02-26  8:45   ` Geert Uytterhoeven
2021-02-26  8:45     ` Geert Uytterhoeven
2021-02-26 12:48     ` Laurent Pinchart
2021-02-26 12:48       ` Laurent Pinchart
2021-03-01 15:01       ` Fabrizio Castro
2021-03-01 15:01         ` Fabrizio Castro
2021-03-03 10:23         ` Fabrizio Castro
2021-03-03 10:23           ` Fabrizio Castro
2021-03-01 14:58     ` Fabrizio Castro
2021-03-01 14:58       ` Fabrizio Castro
2021-02-25 22:51 ` [PATCH 3/7] dt-bindings: misc: Add binding for R-Car DAB Fabrizio Castro
2021-02-25 22:51   ` Fabrizio Castro
2021-02-26  8:41   ` Geert Uytterhoeven
2021-02-26  8:41     ` Geert Uytterhoeven
2021-03-01 15:10     ` Fabrizio Castro
2021-03-01 15:10       ` Fabrizio Castro
2021-02-26  9:06   ` Sergei Shtylyov
2021-02-26  9:06     ` Sergei Shtylyov
2021-03-01 15:11     ` Fabrizio Castro
2021-03-01 15:11       ` Fabrizio Castro
2021-02-26 13:01   ` Laurent Pinchart
2021-02-26 13:01     ` Laurent Pinchart
2021-03-01 15:13     ` Fabrizio Castro
2021-03-01 15:13       ` Fabrizio Castro
2021-02-25 22:51 ` [PATCH 4/7] misc: Add driver for DAB IP found on Renesas R-Car devices Fabrizio Castro
2021-02-25 22:51   ` Fabrizio Castro
2021-02-26  4:57   ` kernel test robot
2021-02-26  4:57     ` kernel test robot
2021-02-26  9:34   ` Geert Uytterhoeven
2021-02-26  9:34     ` Geert Uytterhoeven
2021-03-01 16:19     ` Fabrizio Castro
2021-03-01 16:19       ` Fabrizio Castro
2021-02-26 10:37   ` Arnd Bergmann
2021-02-26 10:37     ` Arnd Bergmann
2021-02-26 13:05     ` Laurent Pinchart
2021-02-26 13:05       ` Laurent Pinchart
2021-03-01 17:54       ` Fabrizio Castro
2021-03-01 17:54         ` Fabrizio Castro
2021-03-01 17:26     ` Fabrizio Castro
2021-03-01 17:26       ` Fabrizio Castro
2021-03-02 11:16       ` Ezequiel Garcia
2021-03-02 11:16         ` Ezequiel Garcia
2021-03-02 12:20         ` Fabrizio Castro
2021-03-02 12:20           ` Fabrizio Castro
2021-03-02 12:32           ` Laurent Pinchart
2021-03-02 12:32             ` Laurent Pinchart
2021-03-03 10:20             ` Fabrizio Castro
2021-03-03 10:20               ` Fabrizio Castro
2021-03-03 10:26               ` Geert Uytterhoeven
2021-03-03 10:26                 ` Geert Uytterhoeven
2021-03-03 10:43                 ` Fabrizio Castro
2021-03-03 10:43                   ` Fabrizio Castro
2021-02-25 22:51 ` [PATCH 5/7] arm64: dts: renesas: r8a77990: Add DAB support Fabrizio Castro
2021-02-25 22:51   ` Fabrizio Castro
2021-02-26  9:37   ` Geert Uytterhoeven
2021-02-26  9:37     ` Geert Uytterhoeven
2021-03-01 14:51     ` Fabrizio Castro
2021-03-01 14:51       ` Fabrizio Castro
2021-02-26 12:47   ` Laurent Pinchart
2021-02-26 12:47     ` Laurent Pinchart
2021-03-01 14:53     ` Fabrizio Castro
2021-03-01 14:53       ` Fabrizio Castro
2021-02-25 22:51 ` [PATCH 6/7] arm64: dts: renesas: r8a77965: " Fabrizio Castro
2021-02-25 22:51   ` Fabrizio Castro
2021-02-26  9:37   ` Geert Uytterhoeven
2021-02-26  9:37     ` Geert Uytterhoeven
2021-03-01 14:54     ` Fabrizio Castro
2021-03-01 14:54       ` Fabrizio Castro
2021-02-26 12:47   ` Laurent Pinchart
2021-02-26 12:47     ` Laurent Pinchart
2021-03-01 14:55     ` Fabrizio Castro
2021-03-01 14:55       ` Fabrizio Castro
2021-02-25 22:51 ` [PATCH 7/7] arm64: configs: Add R-Car " Fabrizio Castro
2021-02-25 22:51   ` Fabrizio Castro
2021-02-26 12:52   ` Laurent Pinchart [this message]
2021-02-26 12:52     ` Laurent Pinchart
2021-02-26 13:05     ` Geert Uytterhoeven
2021-02-26 13:05       ` Geert Uytterhoeven
2021-02-26 12:20 ` [PATCH 0/7] Add FFT Support for R-Car Gen3 devices Laurent Pinchart
2021-02-26 12:20   ` Laurent Pinchart
2021-03-01 14:50   ` Fabrizio Castro
2021-03-01 14:50     ` Fabrizio Castro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDjvI6DTcBfWdA3G@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=Dirk.Behme@de.bosch.com \
    --cc=Peter.Erben@de.bosch.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=phil.edworthy@renesas.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.