From: Lorenzo Bianconi <lorenzo@kernel.org> To: Ryder Lee <ryder.lee@mediatek.com> Cc: Felix Fietkau <nbd@nbd.name>, Lorenzo Bianconi <lorenzo.bianconi@redhat.com>, Shayne Chen <shayne.chen@mediatek.com>, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 4/5] mt76: mt7915: stop ext_phy queue when mac reset happens Date: Sat, 27 Feb 2021 11:26:18 +0100 [thread overview] Message-ID: <YDoeSgKugYwjQw4M@lore-desk> (raw) In-Reply-To: <20a4b03ba4a347a76df67291680704dfdb7da5d6.1614411256.git.ryder.lee@mediatek.com> [-- Attachment #1: Type: text/plain, Size: 1419 bytes --] > Stop Tx burst for ext_phy after mac reset. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > --- > drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c > index 6b6ea33bd320..c653cd01b8d8 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c > @@ -1607,9 +1607,10 @@ void mt7915_mac_reset_work(struct work_struct *work) > set_bit(MT76_MCU_RESET, &dev->mphy.state); > wake_up(&dev->mt76.mcu.wait); > cancel_delayed_work_sync(&dev->mphy.mac_work); > - if (phy2) > + if (phy2) { > + set_bit(MT76_RESET, &phy2->mt76->state); > cancel_delayed_work_sync(&phy2->mt76->mac_work); same question here as mt7615, do we really need this? Regards, Lorenzo > - > + } > /* lock/unlock all queues to ensure that no tx is pending */ > mt76_txq_schedule_all(&dev->mphy); > if (ext_phy) > @@ -1637,6 +1638,8 @@ void mt7915_mac_reset_work(struct work_struct *work) > > clear_bit(MT76_MCU_RESET, &dev->mphy.state); > clear_bit(MT76_RESET, &dev->mphy.state); > + if (phy2) > + clear_bit(MT76_RESET, &phy2->mt76->state); > > mt76_worker_enable(&dev->mt76.tx_worker); > napi_enable(&dev->mt76.tx_napi); > -- > 2.18.0 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Bianconi <lorenzo@kernel.org> To: Ryder Lee <ryder.lee@mediatek.com> Cc: linux-mediatek@lists.infradead.org, Lorenzo Bianconi <lorenzo.bianconi@redhat.com>, Shayne Chen <shayne.chen@mediatek.com>, linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name> Subject: Re: [PATCH 4/5] mt76: mt7915: stop ext_phy queue when mac reset happens Date: Sat, 27 Feb 2021 11:26:18 +0100 [thread overview] Message-ID: <YDoeSgKugYwjQw4M@lore-desk> (raw) In-Reply-To: <20a4b03ba4a347a76df67291680704dfdb7da5d6.1614411256.git.ryder.lee@mediatek.com> [-- Attachment #1.1: Type: text/plain, Size: 1419 bytes --] > Stop Tx burst for ext_phy after mac reset. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > --- > drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c > index 6b6ea33bd320..c653cd01b8d8 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c > @@ -1607,9 +1607,10 @@ void mt7915_mac_reset_work(struct work_struct *work) > set_bit(MT76_MCU_RESET, &dev->mphy.state); > wake_up(&dev->mt76.mcu.wait); > cancel_delayed_work_sync(&dev->mphy.mac_work); > - if (phy2) > + if (phy2) { > + set_bit(MT76_RESET, &phy2->mt76->state); > cancel_delayed_work_sync(&phy2->mt76->mac_work); same question here as mt7615, do we really need this? Regards, Lorenzo > - > + } > /* lock/unlock all queues to ensure that no tx is pending */ > mt76_txq_schedule_all(&dev->mphy); > if (ext_phy) > @@ -1637,6 +1638,8 @@ void mt7915_mac_reset_work(struct work_struct *work) > > clear_bit(MT76_MCU_RESET, &dev->mphy.state); > clear_bit(MT76_RESET, &dev->mphy.state); > + if (phy2) > + clear_bit(MT76_RESET, &phy2->mt76->state); > > mt76_worker_enable(&dev->mt76.tx_worker); > napi_enable(&dev->mt76.tx_napi); > -- > 2.18.0 > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 170 bytes --] _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-02-27 10:27 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-27 7:39 [PATCH 1/5] mt76: mt7615: fix CSA notification for DBDC Ryder Lee 2021-02-27 7:39 ` Ryder Lee 2021-02-27 7:39 ` [PATCH 2/5] mt76: mt7615: stop ext_phy queue when mac reset happens Ryder Lee 2021-02-27 7:39 ` Ryder Lee 2021-02-27 10:23 ` Lorenzo Bianconi 2021-02-27 10:23 ` Lorenzo Bianconi 2021-02-27 13:35 ` Ryder Lee 2021-02-27 13:35 ` Ryder Lee 2021-02-27 7:39 ` [PATCH 3/5] mt76: mt7915: fix CSA notification for DBDC Ryder Lee 2021-02-27 7:39 ` Ryder Lee 2021-02-27 7:39 ` [PATCH 4/5] mt76: mt7915: stop ext_phy queue when mac reset happens Ryder Lee 2021-02-27 7:39 ` Ryder Lee 2021-02-27 10:26 ` Lorenzo Bianconi [this message] 2021-02-27 10:26 ` Lorenzo Bianconi 2021-02-27 7:39 ` [PATCH 5/5] mt76: mt7915: fix PHY mode for DBDC Ryder Lee 2021-02-27 7:39 ` Ryder Lee
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YDoeSgKugYwjQw4M@lore-desk \ --to=lorenzo@kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=lorenzo.bianconi@redhat.com \ --cc=nbd@nbd.name \ --cc=ryder.lee@mediatek.com \ --cc=shayne.chen@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.