From: Daniel Vetter <daniel@ffwll.ch> To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: make drm_send_event_helper static Date: Mon, 1 Mar 2021 10:16:34 +0100 [thread overview] Message-ID: <YDyw8pmfBpDLP+gU@phenom.ffwll.local> (raw) In-Reply-To: <1614586790-130683-1-git-send-email-jiapeng.chong@linux.alibaba.com> On Mon, Mar 01, 2021 at 04:19:50PM +0800, Jiapeng Chong wrote: > Fix the following sparse warning: > > drivers/gpu/drm/drm_file.c:789:6: warning: symbol > 'drm_send_event_helper' was not declared. Should it be static? > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/gpu/drm/drm_file.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c > index 7efbccf..23d8ad4 100644 > --- a/drivers/gpu/drm/drm_file.c > +++ b/drivers/gpu/drm/drm_file.c > @@ -786,8 +786,8 @@ void drm_event_cancel_free(struct drm_device *dev, > * The timestamp variant of dma_fence_signal is used when the caller > * sends a valid timestamp. > */ > -void drm_send_event_helper(struct drm_device *dev, > - struct drm_pending_event *e, ktime_t timestamp) > +static void drm_send_event_helper(struct drm_device *dev, struct drm_pending_event *e, > + ktime_t timestamp) For static inline functions we also remove the kerneldoc, there's not really anything important in there. Can you pls do that and respin your patch? Thanks, Daniel > { > assert_spin_locked(&dev->event_lock); > > -- > 1.8.3.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Cc: tzimmermann@suse.de, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: make drm_send_event_helper static Date: Mon, 1 Mar 2021 10:16:34 +0100 [thread overview] Message-ID: <YDyw8pmfBpDLP+gU@phenom.ffwll.local> (raw) In-Reply-To: <1614586790-130683-1-git-send-email-jiapeng.chong@linux.alibaba.com> On Mon, Mar 01, 2021 at 04:19:50PM +0800, Jiapeng Chong wrote: > Fix the following sparse warning: > > drivers/gpu/drm/drm_file.c:789:6: warning: symbol > 'drm_send_event_helper' was not declared. Should it be static? > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/gpu/drm/drm_file.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c > index 7efbccf..23d8ad4 100644 > --- a/drivers/gpu/drm/drm_file.c > +++ b/drivers/gpu/drm/drm_file.c > @@ -786,8 +786,8 @@ void drm_event_cancel_free(struct drm_device *dev, > * The timestamp variant of dma_fence_signal is used when the caller > * sends a valid timestamp. > */ > -void drm_send_event_helper(struct drm_device *dev, > - struct drm_pending_event *e, ktime_t timestamp) > +static void drm_send_event_helper(struct drm_device *dev, struct drm_pending_event *e, > + ktime_t timestamp) For static inline functions we also remove the kerneldoc, there's not really anything important in there. Can you pls do that and respin your patch? Thanks, Daniel > { > assert_spin_locked(&dev->event_lock); > > -- > 1.8.3.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-01 9:17 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-01 8:19 [PATCH] drm: make drm_send_event_helper static Jiapeng Chong 2021-03-01 8:19 ` Jiapeng Chong 2021-03-01 9:16 ` Daniel Vetter [this message] 2021-03-01 9:16 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YDyw8pmfBpDLP+gU@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=jiapeng.chong@linux.alibaba.com \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.