From: Vipin Sharma <vipinsh@google.com>
To: Jacob Pan <jacob.jun.pan@intel.com>
Cc: tj@kernel.org, mkoutny@suse.com, rdunlap@infradead.org,
thomas.lendacky@amd.com, brijesh.singh@amd.com,
jon.grimm@amd.com, eric.vantassell@amd.com, pbonzini@redhat.com,
hannes@cmpxchg.org, frankja@linux.ibm.com,
borntraeger@de.ibm.com, corbet@lwn.net, seanjc@google.com,
vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, gingell@google.com,
rientjes@google.com, dionnaglaze@google.com, kvm@vger.kernel.org,
x86@kernel.org, cgroups@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "Tian,
Kevin" <kevin.tian@intel.com>, "Liu, Yi L" <yi.l.liu@intel.com>,
"Raj, Ashok" <ashok.raj@intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [RFC v2 2/2] cgroup: sev: Miscellaneous cgroup documentation.
Date: Wed, 3 Mar 2021 22:22:03 -0800 [thread overview]
Message-ID: <YEB8i6Chq4K/GGF6@google.com> (raw)
In-Reply-To: <20210303185513.27e18fce@jacob-builder>
On Wed, Mar 03, 2021 at 06:55:13PM -0800, Jacob Pan wrote:
> Hi Vipin,
>
> On Tue, 2 Mar 2021 00:17:05 -0800, Vipin Sharma <vipinsh@google.com> wrote:
>
> > +Migration and Ownership
> > +~~~~~~~~~~~~~~~~~~~~~~~
> > +
> > +A miscellaneous scalar resource is charged to the cgroup in which it is
> > used +first, and stays charged to that cgroup until that resource is
> > freed. Migrating +a process to a different cgroup does not move the
> > charge to the destination +cgroup where the process has moved.
> > +
> I am trying to see if IOASIDs cgroup can also fit in this misc controller
> as yet another resource type.
> https://lore.kernel.org/linux-iommu/20210303131726.7a8cb169@jacob-builder/T/#u
> However, unlike sev IOASIDs need to be migrated if the process is moved to
> another cgroup. i.e. charge the destination and uncharge the source.
>
> Do you think this behavior can be achieved by differentiating resource
> types? i.e. add attach callbacks for certain types. Having a single misc
> interface seems cleaner than creating another controller.
I think it makes sense to add support for migration for the resources
which need it. Resources like SEV, SEV-ES will not participate in
migration and won't stop can_attach() to succeed, other resources which
need migration will allow or stop based on their limits and capacity in
the destination.
next prev parent reply other threads:[~2021-03-04 6:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 8:17 [RFC v2 0/2] cgroup: New misc cgroup controller Vipin Sharma
2021-03-02 8:17 ` [RFC v2 1/2] cgroup: sev: Add " Vipin Sharma
2021-03-03 15:42 ` Tejun Heo
2021-03-04 6:12 ` Vipin Sharma
2021-03-04 6:12 ` Vipin Sharma
2021-03-04 8:53 ` Tejun Heo
2021-03-02 8:17 ` [RFC v2 2/2] cgroup: sev: Miscellaneous cgroup documentation Vipin Sharma
2021-03-04 2:55 ` Jacob Pan
2021-03-04 2:55 ` Jacob Pan
2021-03-04 6:22 ` Vipin Sharma [this message]
2021-03-04 8:51 ` Tejun Heo
2021-03-04 8:51 ` Tejun Heo
2021-03-12 20:58 ` Jacob Pan
2021-03-12 20:58 ` Jacob Pan
2021-03-12 21:15 ` Vipin Sharma
2021-03-12 21:15 ` Vipin Sharma
2021-03-12 22:59 ` Jacob Pan
2021-03-12 22:59 ` Jacob Pan
2021-03-13 10:20 ` Tejun Heo
2021-03-13 10:20 ` Tejun Heo
2021-03-13 16:57 ` Jacob Pan
2021-03-13 16:57 ` Jacob Pan
2021-03-13 18:05 ` Tejun Heo
2021-03-13 18:05 ` Tejun Heo
2021-03-15 22:11 ` Jacob Pan
2021-03-15 22:11 ` Jacob Pan
2021-03-15 22:19 ` Tejun Heo
2021-03-15 22:19 ` Tejun Heo
2021-03-15 23:40 ` Jacob Pan
2021-03-15 23:40 ` Jacob Pan
2021-03-15 23:54 ` Tejun Heo
2021-03-15 23:54 ` Tejun Heo
2021-03-16 1:30 ` Jacob Pan
2021-03-16 1:30 ` Jacob Pan
2021-03-16 2:22 ` Tejun Heo
2021-03-16 2:22 ` Tejun Heo
2021-03-16 18:19 ` Jacob Pan
2021-03-16 18:19 ` Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEB8i6Chq4K/GGF6@google.com \
--to=vipinsh@google.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dionnaglaze@google.com \
--cc=eric.vantassell@amd.com \
--cc=frankja@linux.ibm.com \
--cc=gingell@google.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@intel.com \
--cc=jgg@nvidia.com \
--cc=jmattson@google.com \
--cc=jon.grimm@amd.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=pbonzini@redhat.com \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tj@kernel.org \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.