From: Johan Hovold <johan@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Deák, Imre" <imre.deak@gmail.com>,
"Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>,
"Finn Thain" <fthain@telegraphics.com.au>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
"Linux Samsung SOC" <linux-samsung-soc@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Hector Martin" <marcan@marcan.st>,
"Arnd Bergmann" <arnd@kernel.org>
Subject: Re: [PATCH] tty: serial: samsung_tty: remove spinlock flags in interrupt handlers
Date: Fri, 19 Mar 2021 16:05:28 +0100 [thread overview]
Message-ID: <YFS9uBe1v28DL18r@hovoldconsulting.com> (raw)
In-Reply-To: <CAHp75VfAEj1X9-aOUxFYW52F2FeTxetPHA0KenAjCB49KXbx3A@mail.gmail.com>
On Fri, Mar 19, 2021 at 12:09:34PM +0200, Andy Shevchenko wrote:
> On Fri, Mar 19, 2021 at 10:09 AM Johan Hovold <johan@kernel.org> wrote:
> > > I think it is almost always wrong to call spin_lock_irqsave in
> > > hardirq.
> >
> > Again, no. It's even been a requirement due to "threadirqs" in some
> > cases (e.g. hrtimers) up until now (or rather until the above patch is
> > in mainline).
>
> By the way, a good question Imre (Cc'ed) and I have discussed is the
> in-kernel documentation, i.e.
> https://www.kernel.org/doc/html/latest/kernel-hacking/locking.html.
> Should it be adjusted to reality?
Once forced threading disables interrupts (as it should have all along)
we don't need to worry about this anymore. But yeah, otherwise it should
be documented.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Deák, Imre" <imre.deak@gmail.com>,
"Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>,
"Finn Thain" <fthain@telegraphics.com.au>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
"Linux Samsung SOC" <linux-samsung-soc@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Hector Martin" <marcan@marcan.st>,
"Arnd Bergmann" <arnd@kernel.org>
Subject: Re: [PATCH] tty: serial: samsung_tty: remove spinlock flags in interrupt handlers
Date: Fri, 19 Mar 2021 16:05:28 +0100 [thread overview]
Message-ID: <YFS9uBe1v28DL18r@hovoldconsulting.com> (raw)
In-Reply-To: <CAHp75VfAEj1X9-aOUxFYW52F2FeTxetPHA0KenAjCB49KXbx3A@mail.gmail.com>
On Fri, Mar 19, 2021 at 12:09:34PM +0200, Andy Shevchenko wrote:
> On Fri, Mar 19, 2021 at 10:09 AM Johan Hovold <johan@kernel.org> wrote:
> > > I think it is almost always wrong to call spin_lock_irqsave in
> > > hardirq.
> >
> > Again, no. It's even been a requirement due to "threadirqs" in some
> > cases (e.g. hrtimers) up until now (or rather until the above patch is
> > in mainline).
>
> By the way, a good question Imre (Cc'ed) and I have discussed is the
> in-kernel documentation, i.e.
> https://www.kernel.org/doc/html/latest/kernel-hacking/locking.html.
> Should it be adjusted to reality?
Once forced threading disables interrupts (as it should have all along)
we don't need to worry about this anymore. But yeah, otherwise it should
be documented.
Johan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-19 15:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 18:12 [PATCH] tty: serial: samsung_tty: remove spinlock flags in interrupt handlers Krzysztof Kozlowski
2021-03-15 18:12 ` Krzysztof Kozlowski
2021-03-15 18:16 ` Andy Shevchenko
2021-03-15 18:16 ` Andy Shevchenko
2021-03-16 9:02 ` Johan Hovold
2021-03-16 9:02 ` Johan Hovold
2021-03-16 9:40 ` Andy Shevchenko
2021-03-16 9:40 ` Andy Shevchenko
2021-03-19 6:36 ` Song Bao Hua (Barry Song)
2021-03-19 6:36 ` Song Bao Hua (Barry Song)
2021-03-19 8:10 ` Johan Hovold
2021-03-19 8:10 ` Johan Hovold
2021-03-19 10:09 ` Andy Shevchenko
2021-03-19 10:09 ` Andy Shevchenko
2021-03-19 15:05 ` Johan Hovold [this message]
2021-03-19 15:05 ` Johan Hovold
2021-03-16 9:47 ` Krzysztof Kozlowski
2021-03-16 9:47 ` Krzysztof Kozlowski
2021-03-16 9:56 ` Johan Hovold
2021-03-16 9:56 ` Johan Hovold
2021-03-16 10:11 ` Krzysztof Kozlowski
2021-03-16 10:11 ` Krzysztof Kozlowski
2021-03-16 11:25 ` Johan Hovold
2021-03-16 11:25 ` Johan Hovold
2021-03-22 11:23 ` Johan Hovold
2021-03-22 11:23 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFS9uBe1v28DL18r@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@kernel.org \
--cc=fthain@telegraphics.com.au \
--cc=gregkh@linuxfoundation.org \
--cc=imre.deak@gmail.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.