From: Heiko Carstens <hca@linux.ibm.com>
To: Li Wang <liwang@redhat.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
LTP List <ltp@lists.linux.it>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-s390@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [s390x vDSO Bug?] clock_gettime(CLOCK_MONOTONIC_RAW, ...) gets abnormal ts value
Date: Tue, 23 Mar 2021 08:11:41 +0100 [thread overview]
Message-ID: <YFmUrVOyX4q+8Dy9@osiris> (raw)
In-Reply-To: <CAEemH2cELFSMzEYM-Gd1LxNuFzVE2PcG1chzyaVhW2YCJjjzdw@mail.gmail.com>
On Tue, Mar 23, 2021 at 02:21:52PM +0800, Li Wang wrote:
> Hi linux-s390 experts,
>
> We observed that LTP/clock_gettime04 always FAIL on s390x with
> kernel-v5.12-rc3.
> To simply show the problem, I rewrite the LTP reproducer as a simple C
> below.
> Maybe it's a new bug introduced from the kernel-5.12 series branch?
>
> PASS:
> ------------
> # uname -r
> 5.11.0-*.s390x
>
> # grep TIME_NS /boot/config-5.11.0-*.s390x
> no TIME_NS enabled
>
> ## ./test-timer
> vdso_ts_nsec = 898169901815, vdso_ts.tv_sec = 898, vdso_ts.tv_nsec =
> 169901815
> sys_ts_nsec = 898169904269, sys_ts.tv_sec = 898, sys_ts.tv_nsec =
> 169904269
> ===> PASS
>
> FAIL:
> ----------
> # uname -r
> 5.12.0-0.rc3.*.s390x
>
> # grep TIME_NS /boot/config-5.12.0-0.rc3.s390x
> CONFIG_TIME_NS=y
> CONFIG_GENERIC_VDSO_TIME_NS=y
>
> # ./test-timer
> vdso_ts_nsec = 4484351380985507, vdso_ts.tv_sec = 4484351, vdso_ts.tv_nsec
> = 380985507
> sys_ts_nsec = 1446923235377, sys_ts.tv_sec = 1446, sys_ts.tv_nsec =
> 923235377
> ===> FAIL
Thanks for reporting!
I'll look later today into this. I would nearly bet that I broke it
with commit f8d8977a3d97 ("s390/time: convert tod_clock_base to
union")
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <hca@linux.ibm.com>
To: ltp@lists.linux.it
Subject: [LTP] [s390x vDSO Bug?] clock_gettime(CLOCK_MONOTONIC_RAW, ...) gets abnormal ts value
Date: Tue, 23 Mar 2021 08:11:41 +0100 [thread overview]
Message-ID: <YFmUrVOyX4q+8Dy9@osiris> (raw)
In-Reply-To: <CAEemH2cELFSMzEYM-Gd1LxNuFzVE2PcG1chzyaVhW2YCJjjzdw@mail.gmail.com>
On Tue, Mar 23, 2021 at 02:21:52PM +0800, Li Wang wrote:
> Hi linux-s390 experts,
>
> We observed that LTP/clock_gettime04 always FAIL on s390x with
> kernel-v5.12-rc3.
> To simply show the problem, I rewrite the LTP reproducer as a simple C
> below.
> Maybe it's a new bug introduced from the kernel-5.12 series branch?
>
> PASS:
> ------------
> # uname -r
> 5.11.0-*.s390x
>
> # grep TIME_NS /boot/config-5.11.0-*.s390x
> no TIME_NS enabled
>
> ## ./test-timer
> vdso_ts_nsec = 898169901815, vdso_ts.tv_sec = 898, vdso_ts.tv_nsec =
> 169901815
> sys_ts_nsec = 898169904269, sys_ts.tv_sec = 898, sys_ts.tv_nsec =
> 169904269
> ===> PASS
>
> FAIL:
> ----------
> # uname -r
> 5.12.0-0.rc3.*.s390x
>
> # grep TIME_NS /boot/config-5.12.0-0.rc3.s390x
> CONFIG_TIME_NS=y
> CONFIG_GENERIC_VDSO_TIME_NS=y
>
> # ./test-timer
> vdso_ts_nsec = 4484351380985507, vdso_ts.tv_sec = 4484351, vdso_ts.tv_nsec
> = 380985507
> sys_ts_nsec = 1446923235377, sys_ts.tv_sec = 1446, sys_ts.tv_nsec =
> 923235377
> ===> FAIL
Thanks for reporting!
I'll look later today into this. I would nearly bet that I broke it
with commit f8d8977a3d97 ("s390/time: convert tod_clock_base to
union")
next prev parent reply other threads:[~2021-03-23 7:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 6:21 [LTP] [s390x vDSO Bug?] clock_gettime(CLOCK_MONOTONIC_RAW, ...) gets abnormal ts value Li Wang
2021-03-23 7:11 ` Heiko Carstens [this message]
2021-03-23 7:11 ` Heiko Carstens
2021-03-23 13:48 ` Heiko Carstens
2021-03-23 13:48 ` [LTP] " Heiko Carstens
2021-03-23 21:58 ` [PATCH 0/3] s390 vdso fixes Heiko Carstens
2021-03-23 21:58 ` [LTP] " Heiko Carstens
2021-03-23 21:58 ` [PATCH 1/3] s390/vdso: fix tod clock steering Heiko Carstens
2021-03-23 21:58 ` [LTP] " Heiko Carstens
2021-03-24 9:50 ` Heiko Carstens
2021-03-24 9:50 ` [LTP] " Heiko Carstens
2021-03-23 21:58 ` [PATCH 2/3] s390/vdso: fix arch_data access for __arch_get_hw_counter() Heiko Carstens
2021-03-23 21:58 ` [LTP] " Heiko Carstens
2021-03-24 5:53 ` Heiko Carstens
2021-03-24 5:53 ` [LTP] " Heiko Carstens
2021-03-23 21:58 ` [PATCH 3/3] lib/vdso: remove struct arch_vdso_data from vdso data struct Heiko Carstens
2021-03-23 21:58 ` [LTP] " Heiko Carstens
2021-03-25 17:55 ` Thomas Gleixner
2021-03-25 17:55 ` [LTP] " Thomas Gleixner
2021-03-25 17:57 ` Thomas Gleixner
2021-03-25 17:57 ` [LTP] " Thomas Gleixner
2021-03-25 8:56 ` [LTP] [PATCH 0/3] s390 vdso fixes Li Wang
2021-03-25 12:33 ` Heiko Carstens
2021-03-25 12:33 ` [LTP] " Heiko Carstens
2021-03-25 14:11 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFmUrVOyX4q+8Dy9@osiris \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=svens@linux.ibm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.