From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Jeffle Xu <jefflexu@linux.alibaba.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com
Subject: Re: [PATCH V3 03/13] block: add helper of blk_create_io_context
Date: Thu, 25 Mar 2021 08:30:16 +0800 [thread overview]
Message-ID: <YFvZmB0LKCQRkoSG@T590> (raw)
In-Reply-To: <YFuCHvUFwhYRNa6Z@infradead.org>
On Wed, Mar 24, 2021 at 07:17:02PM +0100, Christoph Hellwig wrote:
> On Wed, Mar 24, 2021 at 08:19:17PM +0800, Ming Lei wrote:
> > Add one helper for creating io context and prepare for supporting
> > efficient bio based io poll.
>
> Looking at what gets added later here I do not think this helper is
> a good idea. Having a separate one for creating any needed poll-only
> context is a lot more clear.
The poll context actually depends on io_context, that is why I put them
all into one single helper.
thanks,
Ming
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Jeffle Xu <jefflexu@linux.alibaba.com>,
Mike Snitzer <snitzer@redhat.com>
Subject: Re: [dm-devel] [PATCH V3 03/13] block: add helper of blk_create_io_context
Date: Thu, 25 Mar 2021 08:30:16 +0800 [thread overview]
Message-ID: <YFvZmB0LKCQRkoSG@T590> (raw)
In-Reply-To: <YFuCHvUFwhYRNa6Z@infradead.org>
On Wed, Mar 24, 2021 at 07:17:02PM +0100, Christoph Hellwig wrote:
> On Wed, Mar 24, 2021 at 08:19:17PM +0800, Ming Lei wrote:
> > Add one helper for creating io context and prepare for supporting
> > efficient bio based io poll.
>
> Looking at what gets added later here I do not think this helper is
> a good idea. Having a separate one for creating any needed poll-only
> context is a lot more clear.
The poll context actually depends on io_context, that is why I put them
all into one single helper.
thanks,
Ming
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-03-25 0:31 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 12:19 [PATCH V3 00/13] block: support bio based io polling Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-24 12:19 ` [PATCH V3 01/13] block: add helper of blk_queue_poll Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-24 13:19 ` Hannes Reinecke
2021-03-24 13:19 ` [dm-devel] " Hannes Reinecke
2021-03-24 17:54 ` Christoph Hellwig
2021-03-24 17:54 ` [dm-devel] " Christoph Hellwig
2021-03-25 1:56 ` JeffleXu
2021-03-25 1:56 ` [dm-devel] " JeffleXu
2021-03-24 12:19 ` [PATCH V3 02/13] block: add one helper to free io_context Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-24 13:21 ` Hannes Reinecke
2021-03-24 13:21 ` [dm-devel] " Hannes Reinecke
2021-03-24 12:19 ` [PATCH V3 03/13] block: add helper of blk_create_io_context Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-24 13:22 ` Hannes Reinecke
2021-03-24 13:22 ` [dm-devel] " Hannes Reinecke
2021-03-24 15:52 ` Keith Busch
2021-03-24 15:52 ` [dm-devel] " Keith Busch
2021-03-24 18:17 ` Christoph Hellwig
2021-03-24 18:17 ` [dm-devel] " Christoph Hellwig
2021-03-25 0:30 ` Ming Lei [this message]
2021-03-25 0:30 ` Ming Lei
2021-03-24 12:19 ` [PATCH V3 04/13] block: create io poll context for submission and poll task Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-24 13:26 ` Hannes Reinecke
2021-03-24 13:26 ` [dm-devel] " Hannes Reinecke
2021-03-25 2:34 ` JeffleXu
2021-03-25 2:34 ` [dm-devel] " JeffleXu
2021-03-25 2:51 ` Ming Lei
2021-03-25 2:51 ` [dm-devel] " Ming Lei
2021-03-25 3:01 ` JeffleXu
2021-03-25 3:01 ` [dm-devel] " JeffleXu
2021-03-24 12:19 ` [PATCH V3 05/13] block: add req flag of REQ_POLL_CTX Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-24 15:32 ` Hannes Reinecke
2021-03-24 15:32 ` [dm-devel] " Hannes Reinecke
2021-03-25 0:32 ` Ming Lei
2021-03-25 0:32 ` [dm-devel] " Ming Lei
2021-03-25 6:55 ` JeffleXu
2021-03-25 6:55 ` [dm-devel] " JeffleXu
2021-03-24 12:19 ` [PATCH V3 06/13] block: add new field into 'struct bvec_iter' Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-24 15:33 ` Hannes Reinecke
2021-03-24 15:33 ` [dm-devel] " Hannes Reinecke
2021-03-24 12:19 ` [PATCH V3 07/13] block/mq: extract one helper function polling hw queue Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-25 6:50 ` Hannes Reinecke
2021-03-25 6:50 ` [dm-devel] " Hannes Reinecke
2021-03-24 12:19 ` [PATCH V3 08/13] block: prepare for supporting bio_list via other link Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-26 15:02 ` Hannes Reinecke
2021-03-26 15:02 ` [dm-devel] " Hannes Reinecke
2021-03-24 12:19 ` [PATCH V3 09/13] block: use per-task poll context to implement bio based io polling Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-25 6:34 ` JeffleXu
2021-03-25 6:34 ` [dm-devel] " JeffleXu
2021-03-25 8:05 ` Ming Lei
2021-03-25 8:05 ` [dm-devel] " Ming Lei
2021-03-25 9:18 ` JeffleXu
2021-03-25 9:18 ` [dm-devel] " JeffleXu
2021-03-25 9:56 ` Ming Lei
2021-03-25 9:56 ` [dm-devel] " Ming Lei
2021-03-24 12:19 ` [PATCH V3 10/13] blk-mq: limit hw queues to be polled in each blk_poll() Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-24 12:19 ` [PATCH V3 11/13] block: add queue_to_disk() to get gendisk from request_queue Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-24 12:19 ` [PATCH V3 12/13] block: add poll_capable method to support bio-based IO polling Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-24 12:19 ` [PATCH V3 13/13] dm: support IO polling for bio-based dm device Ming Lei
2021-03-24 12:19 ` [dm-devel] " Ming Lei
2021-03-25 18:45 ` Mike Snitzer
2021-03-25 18:45 ` [dm-devel] " Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFvZmB0LKCQRkoSG@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.